Uh oh!
There was an error while loading. Please reload this page.
fix(hiddenTextarea): A form field element should have an id or name attribute - #59
Merged
Merged
Conversation
zhe-he
commented
Jul 3, 2024
ContributorAuthor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #59 +/- ##
=======================================
Coverage 99.02% 99.02% =======================================
Files 3 3 Lines 205 206 +1 Branches 61 60 -1 =======================================
+ Hits 203 204 +1
Misses 2 2 ☔ View full report in Codecov by Sentry. |
什么时候可以merge呢 @afc163 |
Lomnus
approved these changes
Sep 20, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Form elements require a name or an ID, so I added a name to this element to resolve the browser warning