Skip to content

fix: trigger onChange twice when using IME input#78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SocietyNiu wants to merge 1 commit into
base:master
Choose a base branch
from
Open

fix: trigger onChange twice when using IME input #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/TextArea.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,12 +6,13 @@ import useControlledState from '@rc-component/util/lib/hooks/useControlledState'
import { clsx } from 'clsx';
import type { ReactNode } from 'react';
import React, { useEffect, useImperativeHandle, useRef } from 'react';
import ResizableTextArea from './ResizableTextArea';
import type {
ChangeEventInfo,
ResizableTextAreaRef,
TextAreaProps,
TextAreaRef,
} from './interface';
import ResizableTextArea from './ResizableTextArea';

const TextArea = React.forwardRef<TextAreaRef, TextAreaProps>(
(
Expand DownExpand Up@@ -105,6 +106,7 @@ const TextArea = React.forwardRef<TextAreaRef, TextAreaProps>(
| React.ChangeEvent<HTMLTextAreaElement>
| React.CompositionEvent<HTMLTextAreaElement>,
currentValue: string,
info: ChangeEventInfo,
) => {
let cutValue = currentValue;

Expand All@@ -124,6 +126,8 @@ const TextArea = React.forwardRef<TextAreaRef, TextAreaProps>(
getTextArea().selectionEnd || 0,
]);
}
} else if (info.source === 'compositionEnd') {
return;
}
setValue(cutValue);

Expand All@@ -142,12 +146,12 @@ const TextArea = React.forwardRef<TextAreaRef, TextAreaProps>(
HTMLTextAreaElement
> = (e) => {
compositionRef.current = false;
triggerChange(e, e.currentTarget.value);
triggerChange(e, e.currentTarget.value, { source: 'compositionEnd' });
onCompositionEnd?.(e);
};

const onInternalChange = (e: React.ChangeEvent<HTMLTextAreaElement>) => {
triggerChange(e, e.target.value);
triggerChange(e, e.target.value, { source: 'change' });
};

const handleKeyDown = (e: React.KeyboardEvent<HTMLTextAreaElement>) => {
Expand Down
4 changes: 4 additions & 0 deletions src/interface.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,3 +44,7 @@ export type TextAreaRef = {
blur: () => void;
nativeElement: HTMLElement;
};

export interface ChangeEventInfo {
source: 'compositionEnd' | 'change';
}