Skip to content

feat: Support milliseconds picker column (#149) - #151

Open
MrHeer wants to merge 2 commits into
react-component:masterfrom
MrHeer:feat-issues#149
Open

feat: Support milliseconds picker column (#149)#151
MrHeer wants to merge 2 commits into
react-component:masterfrom
MrHeer:feat-issues#149

Conversation

@MrHeer

Copy link
Copy Markdown

close#149

@codecov

codecovBot commented May 15, 2019

Copy link
Copy Markdown

Codecov Report

Merging #151 into master will increase coverage by 0.77%.
The diff coverage is 92.3%.

Impacted file tree graph

@@ Coverage Diff @@## master #151 +/- ##
==========================================
+ Coverage 91.86% 92.63% +0.77% 
==========================================
Files 6 6 Lines 381 421 +40 Branches 99 120 +21 ==========================================
+ Hits 350 390 +40 
Misses 31 31
Impacted FilesCoverage Δ
src/TimePicker.jsx96.61% <100%> (+2.49%)⬆️
src/Header.jsx88.09% <75%> (-0.52%)⬇️
src/Panel.jsx92.42% <90%> (+0.89%)⬆️
src/Combobox.jsx93.33% <91.66%> (-0.26%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88fa1ba...b871b80. Read the comment docs.

@MrHeer

Copy link
Copy Markdown
Author

@afc163 If you have time, please review. Thank you very much.

@MrHeerMrHeer closed this Nov 3, 2019
@abney317

Copy link
Copy Markdown

@MrHeer Why was this closed? I'd like to see this feature merged.

@MrHeer

Copy link
Copy Markdown
Author

@abney317 Because nobody handles it.

@abney317

Copy link
Copy Markdown

@afc163 Any updates here?

@afc163

Copy link
Copy Markdown
Member

You can

@afc163afc163 reopened this Feb 2, 2020
@vercel

vercelBot commented Feb 7, 2020

Copy link
Copy Markdown

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/time-picker/l19wuwlna
✅ Preview: https://time-picker-git-fork-mrheer-feat-issues149.react-component.now.sh

@MrHeer
MrHeer requested a review from afc163February 7, 2020 05:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support milliseconds picker column

3 participants

@MrHeer@abney317@afc163