Skip to content

Use virtual list - #197

Merged
zombieJ merged 52 commits into
masterfrom
virtual
Sep 26, 2019
Merged

Use virtual list#197
zombieJ merged 52 commits into
masterfrom
virtual

Conversation

@zombieJ

@zombieJzombieJ commented Sep 24, 2019

Copy link
Copy Markdown
Member

@codecov

codecovBot commented Sep 25, 2019

Copy link
Copy Markdown

Codecov Report

Merging #197 into master will increase coverage by 2.16%.
The diff coverage is 99.8%.

Impacted file tree graph

@@ Coverage Diff @@## master #197 +/- ##
=========================================
+ Coverage 97.63% 99.8% +2.16% 
=========================================
Files 16 11 -5 Lines 931 514 -417 Branches 219 150 -69 =========================================
- Hits 909 513 -396 + Misses 20 1 -19 + Partials 2 0 -2
Impacted FilesCoverage Δ
src/utils/warningPropsUtil.ts100% <100%> (ø)
src/hooks/useKeyValueMap.ts100% <100%> (ø)
src/hooks/useSelectValues.ts100% <100%> (ø)
src/utils/strategyUtil.ts100% <100%> (ø)
src/utils/legacyUtil.tsx100% <100%> (ø)
src/hooks/useKeyValueMapping.ts100% <100%> (ø)
src/Context.tsx100% <100%> (ø)
src/TreeSelect.tsx100% <100%> (ø)
src/hooks/useTreeData.ts100% <100%> (ø)
src/utils/valueUtil.ts100% <100%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe33eb7...1edf993. Read the comment docs.

@vercel
vercelBot temporarily deployed to staging September 26, 2019 11:44 Inactive
@zombieJ
zombieJ marked this pull request as ready for review September 26, 2019 12:34
@zombieJ
zombieJ merged commit 7f7208f into masterSep 26, 2019
@delete-merged-branch
delete-merged-branchBot deleted the virtual branch September 26, 2019 12:39
@yoyo837

Copy link
Copy Markdown
Member

Can this fix ant-design/ant-design/issues/18863?

@zombieJ

Copy link
Copy Markdown
MemberAuthor

ant-design/ant-design/issues/18863 is not a bug, it's usage issue. Should user handle check logic self.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants

@zombieJ@afc163@yoyo837