Skip to content

check mouseDownTimeout timer before calling clearTimeout - #278

Open
shc023 wants to merge 1 commit into
react-component:masterfrom
shc023:perf-clear-timeout
Open

check mouseDownTimeout timer before calling clearTimeout#278
shc023 wants to merge 1 commit into
react-component:masterfrom
shc023:perf-clear-timeout

Conversation

@shc023

Copy link
Copy Markdown

this PR boosts performance in our React App, when unmounting a large list containing 10k+ rc-tooltips

@codecov

codecovBot commented Aug 11, 2021

Copy link
Copy Markdown

Codecov Report

Merging #278 (bd89a0e) into master (55ed22f) will decrease coverage by 0.09%.
The diff coverage is 83.33%.

❗ Current head bd89a0e differs from pull request most recent head b2de5d2. Consider uploading reports for the commit b2de5d2 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@## master #278 +/- ##
==========================================
- Coverage 89.88% 89.79% -0.10% 
==========================================
Files 11 11 Lines 534 539 +5 Branches 136 137 +1 ==========================================
+ Hits 480 484 +4 - Misses 54 55 +1 
Impacted FilesCoverage Δ
src/index.tsx86.57% <83.33%> (-0.10%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55ed22f...b2de5d2. Read the comment docs.

@CHOYSEN

Copy link
Copy Markdown

有任何进度吗?看起来是个没有风险的改动 @afc163@zombieJ

@afc163

Copy link
Copy Markdown
Member

@CHOYSEN 冲突了。

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@shc023@CHOYSEN@afc163