Skip to content

fix: the repeated calling of multi-level Trigger triggerOpen method#564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QdabuliuQ wants to merge 5 commits into
base:master
Choose a base branch
from
Open

fix: the repeated calling of multi-level Trigger triggerOpen method #564

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a47d0d
fix: fix popup mouse leave event handler type and logic
QdabuliuQ Aug 7, 2025
2b7290c
fix: Fixed onPopupMouseLeave triggering error
QdabuliuQ Aug 8, 2025
5884b91
fix: Fixed onPopupMouseLeave triggering error
QdabuliuQ Aug 8, 2025
6f0f2b9
fix: refactor popup mouse event handling logic
QdabuliuQ Aug 14, 2025
d3468e3
fix: update type of onPopupMouseLeave handler
QdabuliuQ Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/index.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -576,6 +576,8 @@ export function generateTrigger(

if (hoverToShow) {
const onMouseEnterCallback = (event: React.MouseEvent) => {
// Clear any delayed close operations
clearDelay();

@zombieJzombieJAug 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearDelay 是对自身的触发进行清理，这个在鼠标事件 trigger open 的时候已经调用了，并不会影响多层的逻辑。应该是通过 parentContext 来告知 parent 需要复活才对。

setMousePosByEvent(event);
};

Expand All@@ -596,7 +598,11 @@ export function generateTrigger(
);

onPopupMouseEnter = (event) => {
// Only trigger re-open when popup is visible
// Always clear the delay to ensure the mouse returns to the menu to cancel the close
clearDelay();

// Only trigger re-open when popup is visible or in motion
// and ensure the mouse is entering the popup area
if (
(mergedOpen || inMotion) &&
popupEle?.contains(event.target as HTMLElement)
Expand Down
Loading