Skip to content

fix: scrollbar measure should consider scrollbar-color::webkit-scrollbar mixing - #507

Merged
zombieJ merged 4 commits into
masterfrom
fix-scrollbar
Mar 6, 2024
Merged

fix: scrollbar measure should consider scrollbar-color::webkit-scrollbar mixing#507
zombieJ merged 4 commits into
masterfrom
fix-scrollbar

Conversation

@zombieJ

@zombieJzombieJ commented Mar 6, 2024

Copy link
Copy Markdown
Member

css 设置 scrollbar-color 后会导致 ::webkit-scrollbar 伪类失效。测量仍然使用 ::webkit-scrollbar 的数值导致滚动条宽度的计算错误。修复成实际测量值。

@vercel

vercelBot commented Mar 6, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated (UTC)
util✅ Ready (Inspect)Visit PreviewMar 6, 2024 6:37am

@codecov

codecovBot commented Mar 6, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 69.04762% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 90.48%. Comparing base (871c2c1) to head (307c616).

FilesPatch %Lines
src/getScrollBarSize.tsx69.04%13 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #507 +/- ##
==========================================
- Coverage 91.58% 90.48% -1.11% 
==========================================
Files 38 38 Lines 927 935 +8 Branches 287 295 +8 ==========================================
- Hits 849 846 -3 - Misses 76 87 +11 
Partials 2 2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crazyair

Copy link
Copy Markdown
Contributor

69.04

Comment threadsrc/getScrollBarSize.tsx
@zombieJ

Copy link
Copy Markdown
MemberAuthor

69.04

测试盖不住,jsdom 没有真实的 DOM 环境。测试里写的也是假的。

@zombieJ
zombieJ merged commit e96b0c6 into masterMar 6, 2024
@delete-merged-branch
delete-merged-branchBot deleted the fix-scrollbar branch March 6, 2024 07:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@zombieJ@crazyair@yoyo837