Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 202
chore: update maintenance dependencies#790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ad970e6
chore: update maintenance dependencies
afc163 efb181a
fix: align TypeScript and ESLint compatibility
afc163 eb231a1
chore: use testing-library dom events
afc163 805f2ce
test: keep react testing event behavior
afc163 45b4e35
test: cover getNodeRef fallback
afc163 2228f95
chore: address review comments
afc163 418f841
fix: keep compatible eslint export rule
afc163 d62f27c
docs: use ut install for local setup
afc163 deefc9d
chore: restore vercel install command
afc163 e8c3c91
chore: align maintenance dependencies
afc163 f04cecf
fix: preserve React peer dependency range
afc163 3517cb0
docs: use npm install in README
afc163 6b36933
chore: remove redundant strict tsconfig flags
afc163 8e1379a
chore: remove manual global test declarations
afc163 67bdad9
chore: migrate to native eslint flat config
afc163 61f6409
chore: address review comments
afc163 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| import js from '@eslint/js'; | ||
| import { defineConfig } from 'eslint/config'; | ||
| import { dirname } from 'node:path'; | ||
| import { fileURLToPath } from 'node:url'; | ||
| import prettier from 'eslint-config-prettier'; | ||
| import jest from 'eslint-plugin-jest'; | ||
| import react from 'eslint-plugin-react'; | ||
| import reactHooks from 'eslint-plugin-react-hooks'; | ||
| import globals from 'globals'; | ||
| import tseslint from 'typescript-eslint'; | ||
| const tsconfigRootDir = dirname(fileURLToPath(import.meta.url)); | ||
| export default defineConfig([ | ||
| { | ||
| plugins: { | ||
| '@typescript-eslint': tseslint.plugin, | ||
| }, | ||
| }, | ||
| { | ||
| linterOptions: { | ||
| reportUnusedDisableDirectives: 'warn', | ||
| }, | ||
| }, | ||
| { | ||
| ignores: [ | ||
| 'node_modules/', | ||
| 'coverage/', | ||
| 'es/', | ||
| 'lib/', | ||
| 'dist/', | ||
| 'docs-dist/', | ||
| '.docs-dist/', | ||
| '.dumi/', | ||
| '.doc/', | ||
| '.vercel/', | ||
| ], | ||
| }, | ||
| { | ||
| files: ['**/*.{js,jsx,ts,tsx}'], | ||
| extends: [ | ||
| js.configs.recommended, | ||
| react.configs.flat.recommended, | ||
| react.configs.flat['jsx-runtime'], | ||
| prettier, | ||
| ], | ||
| plugins: { | ||
| 'react-hooks': reactHooks, | ||
| }, | ||
| languageOptions: { | ||
| globals: { | ||
| ...globals.browser, | ||
| ...globals.node, | ||
| }, | ||
| }, | ||
| settings: { | ||
| react: { | ||
| version: 'detect', | ||
| }, | ||
| }, | ||
| rules: { | ||
| 'no-async-promise-executor': 'off', | ||
| 'no-empty-pattern': 'off', | ||
| 'no-irregular-whitespace': 'off', | ||
| 'no-prototype-builtins': 'off', | ||
| 'no-useless-escape': 'off', | ||
| 'no-extra-boolean-cast': 'off', | ||
| 'no-undef': 'off', | ||
| 'no-unused-vars': 'off', | ||
| 'react/no-find-dom-node': 'off', | ||
| 'react/display-name': 'off', | ||
| 'react/no-unknown-property': 'off', | ||
| 'react/prop-types': 'off', | ||
| 'react-hooks/exhaustive-deps': 'warn', | ||
| 'react-hooks/rules-of-hooks': 'error', | ||
| }, | ||
| }, | ||
| { | ||
| files: ['**/*.{ts,tsx}'], | ||
| extends: [...tseslint.configs.recommended], | ||
| rules: { | ||
| '@typescript-eslint/ban-ts-comment': 'off', | ||
| '@typescript-eslint/no-empty-object-type': 'off', | ||
| '@typescript-eslint/no-explicit-any': 'off', | ||
| '@typescript-eslint/no-unsafe-function-type': 'off', | ||
| '@typescript-eslint/no-unnecessary-type-constraint': 'off', | ||
| '@typescript-eslint/no-unused-vars': 'off', | ||
| }, | ||
| }, | ||
| { | ||
| files: ['src/**/*.{ts,tsx}'], | ||
| languageOptions: { | ||
| parserOptions: { | ||
| projectService: true, | ||
| tsconfigRootDir, | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| files: ['tests/**/*.{js,jsx,ts,tsx}', '**/*.{test,spec}.{js,jsx,ts,tsx}'], | ||
| extends: [jest.configs['flat/recommended']], | ||
| rules: { | ||
| 'jest/no-disabled-tests': 'off', | ||
| 'jest/no-done-callback': 'off', | ||
| 'jest/no-identical-title': 'off', | ||
| 'jest/expect-expect': 'off', | ||
| 'jest/no-alias-methods': 'off', | ||
| 'jest/no-conditional-expect': 'off', | ||
| 'jest/no-export': 'off', | ||
| 'jest/no-standalone-expect': 'off', | ||
| 'jest/valid-expect': 'off', | ||
| 'jest/valid-title': 'off', | ||
| }, | ||
| }, | ||
| ]); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /// <reference types="jest" /> | ||
| /// <reference types="node" /> | ||
| /// <reference types="react" /> | ||
| /// <reference types="react-dom" /> | ||
| /// <reference types="@testing-library/jest-dom" /> | ||
| declare module '*.css'; | ||
| declare module '*.less'; | ||
| declare module 'jsonp'; | ||
| declare module 'moment/locale/zh-cn'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -11,6 +11,8 @@ import { | ||
| useComposeRef, | ||
| } from '../src/ref'; | ||
| const isReact19 = React.version.startsWith('19'); | ||
| describe('ref', () => { | ||
| const errSpy = jest.spyOn(console, 'error'); | ||
| @@ -117,7 +119,7 @@ describe('ref', () => { | ||
| </Holder>, | ||
| ); | ||
| expect(supportRef(FC)).toBeFalsy(); | ||
| expect(supportRef(holderRef.current.props.children)).toBeFalsy(); | ||
| expect(supportRef(holderRef.current.props.children)).toBe(isReact19); | ||
| }); | ||
| it('forwardRef function component', () => { | ||
| @@ -163,7 +165,7 @@ describe('ref', () => { | ||
| </Holder>, | ||
| ); | ||
| expect(supportRef(MemoFC)).toBeFalsy(); | ||
| expect(supportRef(holderRef.current.props.children)).toBeFalsy(); | ||
| expect(supportRef(holderRef.current.props.children)).toBe(isReact19); | ||
| }); | ||
| it('memo of forwardRef function component', () => { | ||
| @@ -196,7 +198,7 @@ describe('ref', () => { | ||
| it('FC', () => { | ||
| const FC = () => <div />; | ||
| const RefFC = React.forwardRef(FC); | ||
afc163 marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| expect(supportNodeRef(<FC />)).toBeFalsy(); | ||
| expect(supportNodeRef(<FC />)).toBe(isReact19); | ||
| expect(supportNodeRef(<RefFC />)).toBeTruthy(); | ||
| }); | ||
| @@ -218,6 +220,7 @@ describe('ref', () => { | ||
| const node = <div ref={ref} />; | ||
| expect(getNodeRef(node)).toBe(ref); | ||
| expect(getNodeRef(null)).toBeNull(); | ||
| expect(errSpy).not.toHaveBeenCalled(); | ||
| }); | ||
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.