Uh oh!
There was an error while loading. Please reload this page.
fix: default missing horizontal offset - #384
Conversation
@nrps9909 is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #384 +/- ##
=======================================
Coverage 97.60% 97.60% =======================================
Files 19 19 Lines 836 836 Branches 209 205 -4 =======================================
Hits 816 816 Misses 20 20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. Walkthrough
ChangesFiller 水平偏移处理
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk:⚪ Minimal · up to The change defaults an omitted horizontal offset to zero for both LTR and RTL rendering, preventing the reported invalid CSS value. No actionable merge-blocking risk remains after the stated validation. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
82a99ec to
8f3cb45CompareUh oh!
There was an error while loading. Please reload this page.
Summary
offsetXis omittedWhy
FillerProps.offsetXis optional, but the virtual positioning branch negated it directly. Rendering that supported state produced React'sNaN is an invalid value for the marginLeft css style propertywarning and omitted the intended zero margin.Closes#298.
Validation
NaNwarning and missing zero marginAI assistance disclosure: Codex was used to trace the offset path, construct the failing regression, implement the minimal fallback, run validation, and draft this PR. I reviewed the diff and all reported results before submission.
Summary by CodeRabbit
Bug 修复
0px外边距。测试