Skip to content

Running an app in debug should not fail due to other apps running packager #1209

Closed
Closed
Running an app in debug should not fail due to other apps running packager#1209
Assignees
szymonrybczak
Labels
feature requestno-stale-botThis issue cannot be marked as stale by stale bot

Description

@plrdev
plrdev
opened on Jun 29, 2020

Describe the Feature

Running new app should work no matter if there has been other apps running (with packager) - ideally they would not collide.

Currently if you have an app already running in debug, it has it's packager running (by default in port 8081). When you try to run a second app, it will not spawn a launcher due to finding 8081 part having a packager already running. This will try to run the second app in the first apps packager, which will fail with an error:

rn_metro

This is unnecessary friction and requires manually killing the terminal each time you are switching to dev another application (or define the port yourself).

Possible Implementations

I did a twitter poll to see the expectations, here are the results

image

This confirmed my own feeling: Best option would be not to mess with the already running app. Instead, we would find a new port to run it.

I did some experimentations and based on those here is my proposed solution:

  1. If --port is used and is not the default (8081) try to use the specified port. If it is in use, we don't launch packager - you are manually requesting the port and we don't want to change it
  2. If default port, we check for running processes listening in TCP range 8081-8089 (for example)
  3. We check if any of those is packager instance for the app we want to run (for example, slight modification for /status that stores also the project root). If yes, we don't launch a new packager, but use the existing one
  4. Find first free port in the range (again, 8081-8089 for example) and launch packager there

This would replace the current logic:

  1. If defined port (default 8081) is in use and it's status is running, don't do anything
  2. Otherwise try launching a new packager in the port - fail if not able to

POC

I have a POC for iOS locally very close to working, but I wanted to make sure this would be something that is wanted before going forward and finishing it. Android side of implementation is pending still as well.

Changes required so far:

  • Slight modification for cli-server-api statusMiddleWare (/status), so it returns JSON with running status and projectRoot (so we can later check if the running packager is for the current project or not)
  • Start packager bin/sh script changes to do steps 1-4 listed in the proposed solution

Any comments on the proposed solution? Some reasons why it wouldn't work or not wanted to have in the first place? Any changes requested / required? Good to go? If all is good, I'll keep working on this and make a PR out of it.

Metadata

Metadata

Assignees

Labels

feature requestno-stale-botThis issue cannot be marked as stale by stale bot

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    , 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
     blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Running an app in debug should not fail due to other apps running packager · Issue #1209 · react-native-community/cli · GitHub
    Skip to content
    Running an app in debug should not fail due to other apps running packager #1209
    Closed
    Closed
    Running an app in debug should not fail due to other apps running packager#1209
    Assignees
    szymonrybczak
    Labels
    feature requestno-stale-botThis issue cannot be marked as stale by stale bot
    Description
    @plrdev
    plrdev
    opened on Jun 29, 2020
    Describe the Feature
    Running new app should work no matter if there has been other apps running (with packager) - ideally they would not collide.
    Currently if you have an app already running in debug, it has it's packager running (by default in port 8081). When you try to run a second app, it will not spawn a launcher due to finding 8081 part having a packager already running. This will try to run the second app in the first apps packager, which will fail with an error:
    rn_metro
    This is unnecessary friction and requires manually killing the terminal each time you are switching to dev another application (or define the port yourself).
    Possible Implementations
    I did a twitter poll to see the expectations, here are the results
    image
    This confirmed my own feeling: Best option would be not to mess with the already running app. Instead, we would find a new port to run it.
    I did some experimentations and based on those here is my proposed solution:
    1. If --port is used and is not the default (8081) try to use the specified port. If it is in use, we don't launch packager - you are manually requesting the port and we don't want to change it
    2. If default port, we check for running processes listening in TCP range 8081-8089 (for example)
    3. We check if any of those is packager instance for the app we want to run (for example, slight modification for /status that stores also the project root). If yes, we don't launch a new packager, but use the existing one
    4. Find first free port in the range (again, 8081-8089 for example) and launch packager there
    This would replace the current logic:
    1. If defined port (default 8081) is in use and it's status is running, don't do anything
    2. Otherwise try launching a new packager in the port - fail if not able to
    POC
    I have a POC for iOS locally very close to working, but I wanted to make sure this would be something that is wanted before going forward and finishing it. Android side of implementation is pending still as well.
    Changes required so far:
    • Slight modification for cli-server-api statusMiddleWare (/status), so it returns JSON with running status and projectRoot (so we can later check if the running packager is for the current project or not)
    • Start packager bin/sh script changes to do steps 1-4 listed in the proposed solution
    Any comments on the proposed solution? Some reasons why it wouldn't work or not wanted to have in the first place? Any changes requested / required? Good to go? If all is good, I'll keep working on this and make a PR out of it.
    Metadata
    Metadata
    Assignees
    Labels
    feature requestno-stale-botThis issue cannot be marked as stale by stale bot
    Type
    No type
    Projects
    No projects
      Milestone
      No milestone
      Relationships
      None yet
      Development
      No branches or pull requests
      Issue actions
      
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Running an app in debug should not fail due to other apps running packager · Issue #1209 · react-native-community/cli · GitHub
      Skip to content
      Running an app in debug should not fail due to other apps running packager #1209
      Closed
      Closed
      Running an app in debug should not fail due to other apps running packager#1209
      Assignees
      szymonrybczak
      Labels
      feature requestno-stale-botThis issue cannot be marked as stale by stale bot
      Description
      @plrdev
      plrdev
      opened on Jun 29, 2020
      Describe the Feature
      Running new app should work no matter if there has been other apps running (with packager) - ideally they would not collide.
      Currently if you have an app already running in debug, it has it's packager running (by default in port 8081). When you try to run a second app, it will not spawn a launcher due to finding 8081 part having a packager already running. This will try to run the second app in the first apps packager, which will fail with an error:
      rn_metro
      This is unnecessary friction and requires manually killing the terminal each time you are switching to dev another application (or define the port yourself).
      Possible Implementations
      I did a twitter poll to see the expectations, here are the results
      image
      This confirmed my own feeling: Best option would be not to mess with the already running app. Instead, we would find a new port to run it.
      I did some experimentations and based on those here is my proposed solution:
      1. If --port is used and is not the default (8081) try to use the specified port. If it is in use, we don't launch packager - you are manually requesting the port and we don't want to change it
      2. If default port, we check for running processes listening in TCP range 8081-8089 (for example)
      3. We check if any of those is packager instance for the app we want to run (for example, slight modification for /status that stores also the project root). If yes, we don't launch a new packager, but use the existing one
      4. Find first free port in the range (again, 8081-8089 for example) and launch packager there
      This would replace the current logic:
      1. If defined port (default 8081) is in use and it's status is running, don't do anything
      2. Otherwise try launching a new packager in the port - fail if not able to
      POC
      I have a POC for iOS locally very close to working, but I wanted to make sure this would be something that is wanted before going forward and finishing it. Android side of implementation is pending still as well.
      Changes required so far:
      • Slight modification for cli-server-api statusMiddleWare (/status), so it returns JSON with running status and projectRoot (so we can later check if the running packager is for the current project or not)
      • Start packager bin/sh script changes to do steps 1-4 listed in the proposed solution
      Any comments on the proposed solution? Some reasons why it wouldn't work or not wanted to have in the first place? Any changes requested / required? Good to go? If all is good, I'll keep working on this and make a PR out of it.
      Metadata
      Metadata
      Assignees
      Labels
      feature requestno-stale-botThis issue cannot be marked as stale by stale bot
      Type
      No type
      Projects
      No projects
        Milestone
        No milestone
        Relationships
        None yet
        Development
        No branches or pull requests
        Issue actions
        
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Running an app in debug should not fail due to other apps running packager · Issue #1209 · react-native-community/cli · GitHub
        Skip to content
        Running an app in debug should not fail due to other apps running packager #1209
        Closed
        Closed
        Running an app in debug should not fail due to other apps running packager#1209
        Assignees
        szymonrybczak
        Labels
        feature requestno-stale-botThis issue cannot be marked as stale by stale bot
        Description
        @plrdev
        plrdev
        opened on Jun 29, 2020
        Describe the Feature
        Running new app should work no matter if there has been other apps running (with packager) - ideally they would not collide.
        Currently if you have an app already running in debug, it has it's packager running (by default in port 8081). When you try to run a second app, it will not spawn a launcher due to finding 8081 part having a packager already running. This will try to run the second app in the first apps packager, which will fail with an error:
        rn_metro
        This is unnecessary friction and requires manually killing the terminal each time you are switching to dev another application (or define the port yourself).
        Possible Implementations
        I did a twitter poll to see the expectations, here are the results
        image
        This confirmed my own feeling: Best option would be not to mess with the already running app. Instead, we would find a new port to run it.
        I did some experimentations and based on those here is my proposed solution:
        1. If --port is used and is not the default (8081) try to use the specified port. If it is in use, we don't launch packager - you are manually requesting the port and we don't want to change it
        2. If default port, we check for running processes listening in TCP range 8081-8089 (for example)
        3. We check if any of those is packager instance for the app we want to run (for example, slight modification for /status that stores also the project root). If yes, we don't launch a new packager, but use the existing one
        4. Find first free port in the range (again, 8081-8089 for example) and launch packager there
        This would replace the current logic:
        1. If defined port (default 8081) is in use and it's status is running, don't do anything
        2. Otherwise try launching a new packager in the port - fail if not able to
        POC
        I have a POC for iOS locally very close to working, but I wanted to make sure this would be something that is wanted before going forward and finishing it. Android side of implementation is pending still as well.
        Changes required so far:
        • Slight modification for cli-server-api statusMiddleWare (/status), so it returns JSON with running status and projectRoot (so we can later check if the running packager is for the current project or not)
        • Start packager bin/sh script changes to do steps 1-4 listed in the proposed solution
        Any comments on the proposed solution? Some reasons why it wouldn't work or not wanted to have in the first place? Any changes requested / required? Good to go? If all is good, I'll keep working on this and make a PR out of it.
        Metadata
        Metadata
        Assignees
        Labels
        feature requestno-stale-botThis issue cannot be marked as stale by stale bot
        Type
        No type
        Projects
        No projects
          Milestone
          No milestone
          Relationships
          None yet
          Development
          No branches or pull requests
          Issue actions
          
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Running an app in debug should not fail due to other apps running packager · Issue #1209 · react-native-community/cli · GitHub
          Skip to content
          Running an app in debug should not fail due to other apps running packager #1209
          Closed
          Closed
          Running an app in debug should not fail due to other apps running packager#1209
          Assignees
          szymonrybczak
          Labels
          feature requestno-stale-botThis issue cannot be marked as stale by stale bot
          Description
          @plrdev
          plrdev
          opened on Jun 29, 2020
          Describe the Feature
          Running new app should work no matter if there has been other apps running (with packager) - ideally they would not collide.
          Currently if you have an app already running in debug, it has it's packager running (by default in port 8081). When you try to run a second app, it will not spawn a launcher due to finding 8081 part having a packager already running. This will try to run the second app in the first apps packager, which will fail with an error:
          rn_metro
          This is unnecessary friction and requires manually killing the terminal each time you are switching to dev another application (or define the port yourself).
          Possible Implementations
          I did a twitter poll to see the expectations, here are the results
          image
          This confirmed my own feeling: Best option would be not to mess with the already running app. Instead, we would find a new port to run it.
          I did some experimentations and based on those here is my proposed solution:
          1. If --port is used and is not the default (8081) try to use the specified port. If it is in use, we don't launch packager - you are manually requesting the port and we don't want to change it
          2. If default port, we check for running processes listening in TCP range 8081-8089 (for example)
          3. We check if any of those is packager instance for the app we want to run (for example, slight modification for /status that stores also the project root). If yes, we don't launch a new packager, but use the existing one
          4. Find first free port in the range (again, 8081-8089 for example) and launch packager there
          This would replace the current logic:
          1. If defined port (default 8081) is in use and it's status is running, don't do anything
          2. Otherwise try launching a new packager in the port - fail if not able to
          POC
          I have a POC for iOS locally very close to working, but I wanted to make sure this would be something that is wanted before going forward and finishing it. Android side of implementation is pending still as well.
          Changes required so far:
          • Slight modification for cli-server-api statusMiddleWare (/status), so it returns JSON with running status and projectRoot (so we can later check if the running packager is for the current project or not)
          • Start packager bin/sh script changes to do steps 1-4 listed in the proposed solution
          Any comments on the proposed solution? Some reasons why it wouldn't work or not wanted to have in the first place? Any changes requested / required? Good to go? If all is good, I'll keep working on this and make a PR out of it.
          Metadata
          Metadata
          Assignees
          Labels
          feature requestno-stale-botThis issue cannot be marked as stale by stale bot
          Type
          No type
          Projects
          No projects
            Milestone
            No milestone
            Relationships
            None yet
            Development
            No branches or pull requests
            Issue actions
            
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Running an app in debug should not fail due to other apps running packager · Issue #1209 · react-native-community/cli · GitHub
            Skip to content
            Running an app in debug should not fail due to other apps running packager #1209
            Closed
            Closed
            Running an app in debug should not fail due to other apps running packager#1209
            Assignees
            szymonrybczak
            Labels
            feature requestno-stale-botThis issue cannot be marked as stale by stale bot
            Description
            @plrdev
            plrdev
            opened on Jun 29, 2020
            Describe the Feature
            Running new app should work no matter if there has been other apps running (with packager) - ideally they would not collide.
            Currently if you have an app already running in debug, it has it's packager running (by default in port 8081). When you try to run a second app, it will not spawn a launcher due to finding 8081 part having a packager already running. This will try to run the second app in the first apps packager, which will fail with an error:
            rn_metro
            This is unnecessary friction and requires manually killing the terminal each time you are switching to dev another application (or define the port yourself).
            Possible Implementations
            I did a twitter poll to see the expectations, here are the results
            image
            This confirmed my own feeling: Best option would be not to mess with the already running app. Instead, we would find a new port to run it.
            I did some experimentations and based on those here is my proposed solution:
            1. If --port is used and is not the default (8081) try to use the specified port. If it is in use, we don't launch packager - you are manually requesting the port and we don't want to change it
            2. If default port, we check for running processes listening in TCP range 8081-8089 (for example)
            3. We check if any of those is packager instance for the app we want to run (for example, slight modification for /status that stores also the project root). If yes, we don't launch a new packager, but use the existing one
            4. Find first free port in the range (again, 8081-8089 for example) and launch packager there
            This would replace the current logic:
            1. If defined port (default 8081) is in use and it's status is running, don't do anything
            2. Otherwise try launching a new packager in the port - fail if not able to
            POC
            I have a POC for iOS locally very close to working, but I wanted to make sure this would be something that is wanted before going forward and finishing it. Android side of implementation is pending still as well.
            Changes required so far:
            • Slight modification for cli-server-api statusMiddleWare (/status), so it returns JSON with running status and projectRoot (so we can later check if the running packager is for the current project or not)
            • Start packager bin/sh script changes to do steps 1-4 listed in the proposed solution
            Any comments on the proposed solution? Some reasons why it wouldn't work or not wanted to have in the first place? Any changes requested / required? Good to go? If all is good, I'll keep working on this and make a PR out of it.
            Metadata
            Metadata
            Assignees
            Labels
            feature requestno-stale-botThis issue cannot be marked as stale by stale bot
            Type
            No type
            Projects
            No projects
              Milestone
              No milestone
              Relationships
              None yet
              Development
              No branches or pull requests
              Issue actions
              
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Running an app in debug should not fail due to other apps running packager · Issue #1209 · react-native-community/cli · GitHub
              Skip to content
              Running an app in debug should not fail due to other apps running packager #1209
              Closed
              Closed
              Running an app in debug should not fail due to other apps running packager#1209
              Assignees
              szymonrybczak
              Labels
              feature requestno-stale-botThis issue cannot be marked as stale by stale bot
              Description
              @plrdev
              plrdev
              opened on Jun 29, 2020
              Describe the Feature
              Running new app should work no matter if there has been other apps running (with packager) - ideally they would not collide.
              Currently if you have an app already running in debug, it has it's packager running (by default in port 8081). When you try to run a second app, it will not spawn a launcher due to finding 8081 part having a packager already running. This will try to run the second app in the first apps packager, which will fail with an error:
              rn_metro
              This is unnecessary friction and requires manually killing the terminal each time you are switching to dev another application (or define the port yourself).
              Possible Implementations
              I did a twitter poll to see the expectations, here are the results
              image
              This confirmed my own feeling: Best option would be not to mess with the already running app. Instead, we would find a new port to run it.
              I did some experimentations and based on those here is my proposed solution:
              1. If --port is used and is not the default (8081) try to use the specified port. If it is in use, we don't launch packager - you are manually requesting the port and we don't want to change it
              2. If default port, we check for running processes listening in TCP range 8081-8089 (for example)
              3. We check if any of those is packager instance for the app we want to run (for example, slight modification for /status that stores also the project root). If yes, we don't launch a new packager, but use the existing one
              4. Find first free port in the range (again, 8081-8089 for example) and launch packager there
              This would replace the current logic:
              1. If defined port (default 8081) is in use and it's status is running, don't do anything
              2. Otherwise try launching a new packager in the port - fail if not able to
              POC
              I have a POC for iOS locally very close to working, but I wanted to make sure this would be something that is wanted before going forward and finishing it. Android side of implementation is pending still as well.
              Changes required so far:
              • Slight modification for cli-server-api statusMiddleWare (/status), so it returns JSON with running status and projectRoot (so we can later check if the running packager is for the current project or not)
              • Start packager bin/sh script changes to do steps 1-4 listed in the proposed solution
              Any comments on the proposed solution? Some reasons why it wouldn't work or not wanted to have in the first place? Any changes requested / required? Good to go? If all is good, I'll keep working on this and make a PR out of it.
              Metadata
              Metadata
              Assignees
              Labels
              feature requestno-stale-botThis issue cannot be marked as stale by stale bot
              Type
              No type
              Projects
              No projects
                Milestone
                No milestone
                Relationships
                None yet
                Development
                No branches or pull requests
                Issue actions
                
, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Running an app in debug should not fail due to other apps running packager · Issue #1209 · react-native-community/cli · GitHub
                Skip to content
                Running an app in debug should not fail due to other apps running packager #1209
                Closed
                Closed
                Running an app in debug should not fail due to other apps running packager#1209
                Assignees
                szymonrybczak
                Labels
                feature requestno-stale-botThis issue cannot be marked as stale by stale bot
                Description
                @plrdev
                plrdev
                opened on Jun 29, 2020
                Describe the Feature
                Running new app should work no matter if there has been other apps running (with packager) - ideally they would not collide.
                Currently if you have an app already running in debug, it has it's packager running (by default in port 8081). When you try to run a second app, it will not spawn a launcher due to finding 8081 part having a packager already running. This will try to run the second app in the first apps packager, which will fail with an error:
                rn_metro
                This is unnecessary friction and requires manually killing the terminal each time you are switching to dev another application (or define the port yourself).
                Possible Implementations
                I did a twitter poll to see the expectations, here are the results
                image
                This confirmed my own feeling: Best option would be not to mess with the already running app. Instead, we would find a new port to run it.
                I did some experimentations and based on those here is my proposed solution:
                1. If --port is used and is not the default (8081) try to use the specified port. If it is in use, we don't launch packager - you are manually requesting the port and we don't want to change it
                2. If default port, we check for running processes listening in TCP range 8081-8089 (for example)
                3. We check if any of those is packager instance for the app we want to run (for example, slight modification for /status that stores also the project root). If yes, we don't launch a new packager, but use the existing one
                4. Find first free port in the range (again, 8081-8089 for example) and launch packager there
                This would replace the current logic:
                1. If defined port (default 8081) is in use and it's status is running, don't do anything
                2. Otherwise try launching a new packager in the port - fail if not able to
                POC
                I have a POC for iOS locally very close to working, but I wanted to make sure this would be something that is wanted before going forward and finishing it. Android side of implementation is pending still as well.
                Changes required so far:
                • Slight modification for cli-server-api statusMiddleWare (/status), so it returns JSON with running status and projectRoot (so we can later check if the running packager is for the current project or not)
                • Start packager bin/sh script changes to do steps 1-4 listed in the proposed solution
                Any comments on the proposed solution? Some reasons why it wouldn't work or not wanted to have in the first place? Any changes requested / required? Good to go? If all is good, I'll keep working on this and make a PR out of it.
                Metadata
                Metadata
                Assignees
                Labels
                feature requestno-stale-botThis issue cannot be marked as stale by stale bot
                Type
                No type
                Projects
                No projects
                  Milestone
                  No milestone
                  Relationships
                  None yet
                  Development
                  No branches or pull requests
                  Issue actions