Uh oh!
There was an error while loading. Please reload this page.
refactor: use the cli-server-api package - #1140
Conversation
Uh oh!
There was an error while loading. Please reload this page.
| @@ -9,13 +9,13 @@ | |||
| import Metro from 'metro'; | |||
There was a problem hiding this comment.
Can we also rename the directory from server to start now that most of the implementation moved to other package? I think it's a good moment to make it happen and be consistent with other commands
There was a problem hiding this comment.
Sure, renamed the directory to commands/start.
thymikee
commented
May 8, 2020
Noticed an issue with "Reload app" button in Chrome (works fine with Flipper), opening another debugger tab unnecessarily. Same when pressing Reload from an app. Tested on Android |
| '/message', | ||
| ); | ||
| broadcast = messageSocket.broadcast; | ||
| isDebuggerConnected = debuggerProxy.isDebuggerConnected; |
There was a problem hiding this comment.
cc @fson the debugger connected state was not updated, likely an oversight when moving code around
Summary:
The development server middleware and WebSocket servers were extracted out to the
@react-native-community/cli-server-apipackage in #1118. This PR makes the CLI use that package and removes any remaining duplicates of these modules that have been moved.Test Plan:
Followed the Testing your changes instructions in
CONTRIBUTING.mdand started the server withnpx react-native start --watchFolders /Users/ville/Projects/react-native-cli/ --resetCache. Verified the following features work:r