feat(cli-patform-ios): allow setting a path to a Podfile

[grabbou]

Draft following explanation in #1435 (comment)

To be tested, CC @tido64 and @kelset, as I think I am not getting a successful project initialisation (.xcworkspace missing).

The react-native.config.js of my example has been customised as follows:

ios: {project: "node_modules/react-native-test-app/ios/ReactTestApp.xcodeproj",podfile: "ios/Podfile"},

[tido64]

Thanks, @grabbou. I applied the fixes directly to relevant files under node_modules and it works for me. I don't like that we have to specify where to find the Podfile but I guess this will be addressed in next?

[Kiesco08]

Thanks for the fix! There is another area where it also assumes project root directory is the podfile directory. Would it be possible to apply a change there too?

+ project_pod_file_dir = File.dirname(config["project"]["ios"]["podfile"])- relative_path = podspec_dir_path.relative_path_from project_root+ relative_path = podspec_dir_path.relative_path_from project_pod_file_dir

[tido64]

On closer inspection, this doesn't fully work. I ran pod install before applying the fix so it worked fine. But if I run pod installwith the fix, I get this error:

[!] No podspec found for `ReactTestApp-DevSupport` in `..`

In addition to @Kiesco08's proposal, I also had to make podfile an absolute path, i.e.

podfile: path.join(__dirname, "ios", "Podfile"),

It's been so long since I looked at it but this is why sourceDir had to be fixed in #1444.

Edit: ~~It looks like you would also have to let us override sourceDir to complete this fix. The config should then look like this:

ios: {sourceDir: path.join(__dirname,"ios"),project: "node_modules/react-native-test-app/ios/ReactTestApp.xcodeproj",podfile: "ios/Podfile"},

Where sourceDir needs to be absolute path otherwise something else would break.~~

Edit 2: Alternatively, we can just change this:

cli/packages/platform-ios/native_modules.rb

Line 40 in 44f5413

project_root=Pathname.new(config["project"]["ios"]["sourceDir"])

to

 project_root = Pathname.new(config["project"]["ios"]["podfile"]).realpath.parent

Which should be more correct given that we shouldn't be using sourceDir to begin with.

[grabbou]

Draft following explanation in #1435 (comment)

To be tested, CC @tido64 and @kelset, as I think I am not getting a successful project initialisation (.xcworkspace missing).

The react-native.config.js of my example has been customised as follows:

ios: {project: "node_modules/react-native-test-app/ios/ReactTestApp.xcodeproj",podfile: "ios/Podfile"},

[tido64]

Thanks, @grabbou. I applied the fixes directly to relevant files under node_modules and it works for me. I don't like that we have to specify where to find the Podfile but I guess this will be addressed in next?

[Kiesco08]

Thanks for the fix! There is another area where it also assumes project root directory is the podfile directory. Would it be possible to apply a change there too?

+ project_pod_file_dir = File.dirname(config["project"]["ios"]["podfile"])- relative_path = podspec_dir_path.relative_path_from project_root+ relative_path = podspec_dir_path.relative_path_from project_pod_file_dir

[tido64]

On closer inspection, this doesn't fully work. I ran pod install before applying the fix so it worked fine. But if I run pod installwith the fix, I get this error:

[!] No podspec found for `ReactTestApp-DevSupport` in `..`

In addition to @Kiesco08's proposal, I also had to make podfile an absolute path, i.e.

podfile: path.join(__dirname, "ios", "Podfile"),

It's been so long since I looked at it but this is why sourceDir had to be fixed in #1444.

Edit: ~~It looks like you would also have to let us override sourceDir to complete this fix. The config should then look like this:

ios: {sourceDir: path.join(__dirname,"ios"),project: "node_modules/react-native-test-app/ios/ReactTestApp.xcodeproj",podfile: "ios/Podfile"},

Where sourceDir needs to be absolute path otherwise something else would break.~~

Edit 2: Alternatively, we can just change this:

cli/packages/platform-ios/native_modules.rb

Line 40 in 44f5413

project_root=Pathname.new(config["project"]["ios"]["sourceDir"])

to

 project_root = Pathname.new(config["project"]["ios"]["podfile"]).realpath.parent

Which should be more correct given that we shouldn't be using sourceDir to begin with.

[grabbou]

Draft following explanation in #1435 (comment)

To be tested, CC @tido64 and @kelset, as I think I am not getting a successful project initialisation (.xcworkspace missing).

The react-native.config.js of my example has been customised as follows:

ios: {project: "node_modules/react-native-test-app/ios/ReactTestApp.xcodeproj",podfile: "ios/Podfile"},

[tido64]

Thanks, @grabbou. I applied the fixes directly to relevant files under node_modules and it works for me. I don't like that we have to specify where to find the Podfile but I guess this will be addressed in next?

[Kiesco08]

Thanks for the fix! There is another area where it also assumes project root directory is the podfile directory. Would it be possible to apply a change there too?

+ project_pod_file_dir = File.dirname(config["project"]["ios"]["podfile"])- relative_path = podspec_dir_path.relative_path_from project_root+ relative_path = podspec_dir_path.relative_path_from project_pod_file_dir

[tido64]

On closer inspection, this doesn't fully work. I ran pod install before applying the fix so it worked fine. But if I run pod installwith the fix, I get this error:

[!] No podspec found for `ReactTestApp-DevSupport` in `..`

In addition to @Kiesco08's proposal, I also had to make podfile an absolute path, i.e.

podfile: path.join(__dirname, "ios", "Podfile"),

It's been so long since I looked at it but this is why sourceDir had to be fixed in #1444.

Edit: ~~It looks like you would also have to let us override sourceDir to complete this fix. The config should then look like this:

ios: {sourceDir: path.join(__dirname,"ios"),project: "node_modules/react-native-test-app/ios/ReactTestApp.xcodeproj",podfile: "ios/Podfile"},

Where sourceDir needs to be absolute path otherwise something else would break.~~

Edit 2: Alternatively, we can just change this:

cli/packages/platform-ios/native_modules.rb

Line 40 in 44f5413

project_root=Pathname.new(config["project"]["ios"]["sourceDir"])

to

 project_root = Pathname.new(config["project"]["ios"]["podfile"]).realpath.parent

Which should be more correct given that we shouldn't be using sourceDir to begin with.

[grabbou]

Draft following explanation in #1435 (comment)

To be tested, CC @tido64 and @kelset, as I think I am not getting a successful project initialisation (.xcworkspace missing).

The react-native.config.js of my example has been customised as follows:

ios: {project: "node_modules/react-native-test-app/ios/ReactTestApp.xcodeproj",podfile: "ios/Podfile"},

[tido64]

Thanks, @grabbou. I applied the fixes directly to relevant files under node_modules and it works for me. I don't like that we have to specify where to find the Podfile but I guess this will be addressed in next?

[Kiesco08]

Thanks for the fix! There is another area where it also assumes project root directory is the podfile directory. Would it be possible to apply a change there too?

+ project_pod_file_dir = File.dirname(config["project"]["ios"]["podfile"])- relative_path = podspec_dir_path.relative_path_from project_root+ relative_path = podspec_dir_path.relative_path_from project_pod_file_dir

[tido64]

On closer inspection, this doesn't fully work. I ran pod install before applying the fix so it worked fine. But if I run pod installwith the fix, I get this error:

[!] No podspec found for `ReactTestApp-DevSupport` in `..`

In addition to @Kiesco08's proposal, I also had to make podfile an absolute path, i.e.

podfile: path.join(__dirname, "ios", "Podfile"),

It's been so long since I looked at it but this is why sourceDir had to be fixed in #1444.

Edit: ~~It looks like you would also have to let us override sourceDir to complete this fix. The config should then look like this:

ios: {sourceDir: path.join(__dirname,"ios"),project: "node_modules/react-native-test-app/ios/ReactTestApp.xcodeproj",podfile: "ios/Podfile"},

Where sourceDir needs to be absolute path otherwise something else would break.~~

Edit 2: Alternatively, we can just change this:

cli/packages/platform-ios/native_modules.rb

Line 40 in 44f5413

project_root=Pathname.new(config["project"]["ios"]["sourceDir"])

to

 project_root = Pathname.new(config["project"]["ios"]["podfile"]).realpath.parent

Which should be more correct given that we shouldn't be using sourceDir to begin with.

[grabbou]

Draft following explanation in #1435 (comment)

To be tested, CC @tido64 and @kelset, as I think I am not getting a successful project initialisation (.xcworkspace missing).

The react-native.config.js of my example has been customised as follows:

ios: {project: "node_modules/react-native-test-app/ios/ReactTestApp.xcodeproj",podfile: "ios/Podfile"},

[tido64]

Thanks, @grabbou. I applied the fixes directly to relevant files under node_modules and it works for me. I don't like that we have to specify where to find the Podfile but I guess this will be addressed in next?

[Kiesco08]

Thanks for the fix! There is another area where it also assumes project root directory is the podfile directory. Would it be possible to apply a change there too?

+ project_pod_file_dir = File.dirname(config["project"]["ios"]["podfile"])- relative_path = podspec_dir_path.relative_path_from project_root+ relative_path = podspec_dir_path.relative_path_from project_pod_file_dir

[tido64]

On closer inspection, this doesn't fully work. I ran pod install before applying the fix so it worked fine. But if I run pod installwith the fix, I get this error:

[!] No podspec found for `ReactTestApp-DevSupport` in `..`

In addition to @Kiesco08's proposal, I also had to make podfile an absolute path, i.e.

podfile: path.join(__dirname, "ios", "Podfile"),

It's been so long since I looked at it but this is why sourceDir had to be fixed in #1444.

Edit: ~~It looks like you would also have to let us override sourceDir to complete this fix. The config should then look like this:

ios: {sourceDir: path.join(__dirname,"ios"),project: "node_modules/react-native-test-app/ios/ReactTestApp.xcodeproj",podfile: "ios/Podfile"},

Where sourceDir needs to be absolute path otherwise something else would break.~~

Edit 2: Alternatively, we can just change this:

cli/packages/platform-ios/native_modules.rb

Line 40 in 44f5413

project_root=Pathname.new(config["project"]["ios"]["sourceDir"])

to

 project_root = Pathname.new(config["project"]["ios"]["podfile"]).realpath.parent

Which should be more correct given that we shouldn't be using sourceDir to begin with.

[grabbou]

Draft following explanation in #1435 (comment)

To be tested, CC @tido64 and @kelset, as I think I am not getting a successful project initialisation (.xcworkspace missing).

The react-native.config.js of my example has been customised as follows:

ios: {project: "node_modules/react-native-test-app/ios/ReactTestApp.xcodeproj",podfile: "ios/Podfile"},

[tido64]

Thanks, @grabbou. I applied the fixes directly to relevant files under node_modules and it works for me. I don't like that we have to specify where to find the Podfile but I guess this will be addressed in next?

[Kiesco08]

Thanks for the fix! There is another area where it also assumes project root directory is the podfile directory. Would it be possible to apply a change there too?

+ project_pod_file_dir = File.dirname(config["project"]["ios"]["podfile"])- relative_path = podspec_dir_path.relative_path_from project_root+ relative_path = podspec_dir_path.relative_path_from project_pod_file_dir

[tido64]

On closer inspection, this doesn't fully work. I ran pod install before applying the fix so it worked fine. But if I run pod installwith the fix, I get this error:

[!] No podspec found for `ReactTestApp-DevSupport` in `..`

In addition to @Kiesco08's proposal, I also had to make podfile an absolute path, i.e.

podfile: path.join(__dirname, "ios", "Podfile"),

It's been so long since I looked at it but this is why sourceDir had to be fixed in #1444.

Edit: ~~It looks like you would also have to let us override sourceDir to complete this fix. The config should then look like this:

ios: {sourceDir: path.join(__dirname,"ios"),project: "node_modules/react-native-test-app/ios/ReactTestApp.xcodeproj",podfile: "ios/Podfile"},

Where sourceDir needs to be absolute path otherwise something else would break.~~

Edit 2: Alternatively, we can just change this:

cli/packages/platform-ios/native_modules.rb

Line 40 in 44f5413

project_root=Pathname.new(config["project"]["ios"]["sourceDir"])

to

 project_root = Pathname.new(config["project"]["ios"]["podfile"]).realpath.parent

Which should be more correct given that we shouldn't be using sourceDir to begin with.

[grabbou]

Draft following explanation in #1435 (comment)

To be tested, CC @tido64 and @kelset, as I think I am not getting a successful project initialisation (.xcworkspace missing).

The react-native.config.js of my example has been customised as follows:

ios: {project: "node_modules/react-native-test-app/ios/ReactTestApp.xcodeproj",podfile: "ios/Podfile"},

[tido64]

Thanks, @grabbou. I applied the fixes directly to relevant files under node_modules and it works for me. I don't like that we have to specify where to find the Podfile but I guess this will be addressed in next?

[Kiesco08]

Thanks for the fix! There is another area where it also assumes project root directory is the podfile directory. Would it be possible to apply a change there too?

+ project_pod_file_dir = File.dirname(config["project"]["ios"]["podfile"])- relative_path = podspec_dir_path.relative_path_from project_root+ relative_path = podspec_dir_path.relative_path_from project_pod_file_dir

[tido64]

On closer inspection, this doesn't fully work. I ran pod install before applying the fix so it worked fine. But if I run pod installwith the fix, I get this error:

[!] No podspec found for `ReactTestApp-DevSupport` in `..`

In addition to @Kiesco08's proposal, I also had to make podfile an absolute path, i.e.

podfile: path.join(__dirname, "ios", "Podfile"),

It's been so long since I looked at it but this is why sourceDir had to be fixed in #1444.

Edit: ~~It looks like you would also have to let us override sourceDir to complete this fix. The config should then look like this:

ios: {sourceDir: path.join(__dirname,"ios"),project: "node_modules/react-native-test-app/ios/ReactTestApp.xcodeproj",podfile: "ios/Podfile"},

Where sourceDir needs to be absolute path otherwise something else would break.~~

Edit 2: Alternatively, we can just change this:

cli/packages/platform-ios/native_modules.rb

Line 40 in 44f5413

project_root=Pathname.new(config["project"]["ios"]["sourceDir"])

to

 project_root = Pathname.new(config["project"]["ios"]["podfile"]).realpath.parent

Which should be more correct given that we shouldn't be using sourceDir to begin with.

[grabbou]

Draft following explanation in #1435 (comment)

To be tested, CC @tido64 and @kelset, as I think I am not getting a successful project initialisation (.xcworkspace missing).

The react-native.config.js of my example has been customised as follows:

ios: {project: "node_modules/react-native-test-app/ios/ReactTestApp.xcodeproj",podfile: "ios/Podfile"},

[tido64]

Thanks, @grabbou. I applied the fixes directly to relevant files under node_modules and it works for me. I don't like that we have to specify where to find the Podfile but I guess this will be addressed in next?

[Kiesco08]

Thanks for the fix! There is another area where it also assumes project root directory is the podfile directory. Would it be possible to apply a change there too?

+ project_pod_file_dir = File.dirname(config["project"]["ios"]["podfile"])- relative_path = podspec_dir_path.relative_path_from project_root+ relative_path = podspec_dir_path.relative_path_from project_pod_file_dir

[tido64]

On closer inspection, this doesn't fully work. I ran pod install before applying the fix so it worked fine. But if I run pod installwith the fix, I get this error:

[!] No podspec found for `ReactTestApp-DevSupport` in `..`

In addition to @Kiesco08's proposal, I also had to make podfile an absolute path, i.e.

podfile: path.join(__dirname, "ios", "Podfile"),

It's been so long since I looked at it but this is why sourceDir had to be fixed in #1444.

Edit: ~~It looks like you would also have to let us override sourceDir to complete this fix. The config should then look like this:

ios: {sourceDir: path.join(__dirname,"ios"),project: "node_modules/react-native-test-app/ios/ReactTestApp.xcodeproj",podfile: "ios/Podfile"},

Where sourceDir needs to be absolute path otherwise something else would break.~~

Edit 2: Alternatively, we can just change this:

cli/packages/platform-ios/native_modules.rb

Line 40 in 44f5413

project_root=Pathname.new(config["project"]["ios"]["sourceDir"])

to

 project_root = Pathname.new(config["project"]["ios"]["podfile"]).realpath.parent

Which should be more correct given that we shouldn't be using sourceDir to begin with.