Skip to content

feat: interactive mode - #1829

Merged
thymikee merged 4 commits into
react-native-community:mainfrom
adamTrz:feat/interactive-mode
Feb 20, 2023
Merged

feat: interactive mode#1829
thymikee merged 4 commits into
react-native-community:mainfrom
adamTrz:feat/interactive-mode

Conversation

@adamTrz

Copy link
Copy Markdown
Collaborator

Summary:

  • interactive mode for iOS and Android -> user now can select valid scheme and configuration (iOS) or buildVariant (Android) and desired device to run the app on

run-ios-interactive

run-android-interactive

  • support for Android build flavours

run-android-interatcive-flavours

  • some minor fixes and bit of refactoring 🤓

Tested scenarios:

  • run-ios:
    • no devices connected -> works, picked up default scheme and configuration and run on first available device ✅
    • simulator booted -> works, picked up booted simulator ✅
    • --mode Release -> works ✅
    • --mode Bar -> works, app failed to build because there's no Bar configuration available ✅
    • --configuration Release -> works with warning that configuration is deprecated ✅
    • --list-devices works and user can select device from list ✅
    • --interactive works and lets user pick up valid scheme and configuration and device to run on ✅
  • run-android:
    • no device connected -> works, picked up first available AVD and launched the app ✅
    • emulator booted -> works correctly ✅
    • --mode Release -> works correctly ✅
    • --configuration Release -> works with a warning ✅
    • --list-devices -> works and lets user pick up available device/AVD ✅
    • --interactive -> works correctly ✅
    • with build flavours:
      • --mode UatRelease -> works and uses selected build variant both to build and install the app ✅
      • --interactive -> works and lets user pick up available buildVariant and device or AVD ✅
      • --mode Release -> works (app failed to build because there's no Release buildVariant available, it emits an error and lists all available buildVariants) ✅

image


To test it locally clone the repo, checkout to my branch and run run-ios --interactive / run-android --interactive commands.
To check build flavours support for Android add those lines into your android/app/build.gradle file:

 flavorDimensions.add("version")
productFlavors {
prod {
dimension "version"
}
uat {
dimension "version"
}
}

Comment threadpackages/cli-platform-android/src/commands/runAndroid/getTaskNames.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
@TMisiukiewicz

TMisiukiewicz commented Feb 14, 2023

Copy link
Copy Markdown
Collaborator
info Building (using "xcodebuild -workspace NewsApp.xcworkspace -configuration Debug copy -scheme NewsApp -destination id=2C862218-D036-441F-A053-C54C049487FA")
info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/docs/commands.md#doctor error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening NewsApp.xcworkspace.

image

noticed that configuration name in Xcode can contain more than one word, and if it's selected it ends up with an error. Putting this argument in the quote should do the trick, but we should check if there are any other arguments that can have more than one word (both platforms) and fix them too

Good job 👏

Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/listAndroidTasks.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
@adamTrz
adamTrzforce-pushed the feat/interactive-mode branch from 9adff64 to 9516c72CompareFebruary 17, 2023 09:49
@adamTrz

Copy link
Copy Markdown
CollaboratorAuthor
info Building (using "xcodebuild -workspace NewsApp.xcworkspace -configuration Debug copy -scheme NewsApp -destination id=2C862218-D036-441F-A053-C54C049487FA")
info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/docs/commands.md#doctor error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening NewsApp.xcworkspace.

image

noticed that configuration name in Xcode can contain more than one word, and if it's selected it ends up with an error. Putting this argument in the quote should do the trick, but we should check if there are any other arguments that can have more than one word (both platforms) and fix them too

Good job 👏

It works for me @TMisiukiewicz, have you installed pods after creating new configuration? 🙂

@TMisiukiewicz

Copy link
Copy Markdown
Collaborator

@adamTrz you are right, forgot the pods step! All good ✅

Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/buildAndroid/index.ts Outdated

@thymikeethymikee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@szymonrybczakszymonrybczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thymikee
thymikee merged commit 9d17728 into react-native-community:mainFeb 20, 2023
@adamTrz
adamTrz deleted the feat/interactive-mode branch February 20, 2023 20:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@adamTrz@TMisiukiewicz@pawelkata@thymikee@szymonrybczak
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat: interactive mode by adamTrz · Pull Request #1829 · react-native-community/cli · GitHub
Skip to content

feat: interactive mode - #1829

Merged
thymikee merged 4 commits into
react-native-community:mainfrom
adamTrz:feat/interactive-mode
Feb 20, 2023
Merged

feat: interactive mode#1829
thymikee merged 4 commits into
react-native-community:mainfrom
adamTrz:feat/interactive-mode

Conversation

@adamTrz

Copy link
Copy Markdown
Collaborator

Summary:

  • interactive mode for iOS and Android -> user now can select valid scheme and configuration (iOS) or buildVariant (Android) and desired device to run the app on

run-ios-interactive

run-android-interactive

  • support for Android build flavours

run-android-interatcive-flavours

  • some minor fixes and bit of refactoring 🤓

Tested scenarios:

  • run-ios:
    • no devices connected -> works, picked up default scheme and configuration and run on first available device ✅
    • simulator booted -> works, picked up booted simulator ✅
    • --mode Release -> works ✅
    • --mode Bar -> works, app failed to build because there's no Bar configuration available ✅
    • --configuration Release -> works with warning that configuration is deprecated ✅
    • --list-devices works and user can select device from list ✅
    • --interactive works and lets user pick up valid scheme and configuration and device to run on ✅
  • run-android:
    • no device connected -> works, picked up first available AVD and launched the app ✅
    • emulator booted -> works correctly ✅
    • --mode Release -> works correctly ✅
    • --configuration Release -> works with a warning ✅
    • --list-devices -> works and lets user pick up available device/AVD ✅
    • --interactive -> works correctly ✅
    • with build flavours:
      • --mode UatRelease -> works and uses selected build variant both to build and install the app ✅
      • --interactive -> works and lets user pick up available buildVariant and device or AVD ✅
      • --mode Release -> works (app failed to build because there's no Release buildVariant available, it emits an error and lists all available buildVariants) ✅

image


To test it locally clone the repo, checkout to my branch and run run-ios --interactive / run-android --interactive commands.
To check build flavours support for Android add those lines into your android/app/build.gradle file:

 flavorDimensions.add("version")
productFlavors {
prod {
dimension "version"
}
uat {
dimension "version"
}
}

Comment threadpackages/cli-platform-android/src/commands/runAndroid/getTaskNames.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
@TMisiukiewicz

TMisiukiewicz commented Feb 14, 2023

Copy link
Copy Markdown
Collaborator
info Building (using "xcodebuild -workspace NewsApp.xcworkspace -configuration Debug copy -scheme NewsApp -destination id=2C862218-D036-441F-A053-C54C049487FA")
info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/docs/commands.md#doctor error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening NewsApp.xcworkspace.

image

noticed that configuration name in Xcode can contain more than one word, and if it's selected it ends up with an error. Putting this argument in the quote should do the trick, but we should check if there are any other arguments that can have more than one word (both platforms) and fix them too

Good job 👏

Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/listAndroidTasks.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
@adamTrz
adamTrzforce-pushed the feat/interactive-mode branch from 9adff64 to 9516c72CompareFebruary 17, 2023 09:49
@adamTrz

Copy link
Copy Markdown
CollaboratorAuthor
info Building (using "xcodebuild -workspace NewsApp.xcworkspace -configuration Debug copy -scheme NewsApp -destination id=2C862218-D036-441F-A053-C54C049487FA")
info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/docs/commands.md#doctor error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening NewsApp.xcworkspace.

image

noticed that configuration name in Xcode can contain more than one word, and if it's selected it ends up with an error. Putting this argument in the quote should do the trick, but we should check if there are any other arguments that can have more than one word (both platforms) and fix them too

Good job 👏

It works for me @TMisiukiewicz, have you installed pods after creating new configuration? 🙂

@TMisiukiewicz

Copy link
Copy Markdown
Collaborator

@adamTrz you are right, forgot the pods step! All good ✅

Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/buildAndroid/index.ts Outdated

@thymikeethymikee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@szymonrybczakszymonrybczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thymikee
thymikee merged commit 9d17728 into react-native-community:mainFeb 20, 2023
@adamTrz
adamTrz deleted the feat/interactive-mode branch February 20, 2023 20:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@adamTrz@TMisiukiewicz@pawelkata@thymikee@szymonrybczak
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat: interactive mode by adamTrz · Pull Request #1829 · react-native-community/cli · GitHub
Skip to content

feat: interactive mode - #1829

Merged
thymikee merged 4 commits into
react-native-community:mainfrom
adamTrz:feat/interactive-mode
Feb 20, 2023
Merged

feat: interactive mode#1829
thymikee merged 4 commits into
react-native-community:mainfrom
adamTrz:feat/interactive-mode

Conversation

@adamTrz

Copy link
Copy Markdown
Collaborator

Summary:

  • interactive mode for iOS and Android -> user now can select valid scheme and configuration (iOS) or buildVariant (Android) and desired device to run the app on

run-ios-interactive

run-android-interactive

  • support for Android build flavours

run-android-interatcive-flavours

  • some minor fixes and bit of refactoring 🤓

Tested scenarios:

  • run-ios:
    • no devices connected -> works, picked up default scheme and configuration and run on first available device ✅
    • simulator booted -> works, picked up booted simulator ✅
    • --mode Release -> works ✅
    • --mode Bar -> works, app failed to build because there's no Bar configuration available ✅
    • --configuration Release -> works with warning that configuration is deprecated ✅
    • --list-devices works and user can select device from list ✅
    • --interactive works and lets user pick up valid scheme and configuration and device to run on ✅
  • run-android:
    • no device connected -> works, picked up first available AVD and launched the app ✅
    • emulator booted -> works correctly ✅
    • --mode Release -> works correctly ✅
    • --configuration Release -> works with a warning ✅
    • --list-devices -> works and lets user pick up available device/AVD ✅
    • --interactive -> works correctly ✅
    • with build flavours:
      • --mode UatRelease -> works and uses selected build variant both to build and install the app ✅
      • --interactive -> works and lets user pick up available buildVariant and device or AVD ✅
      • --mode Release -> works (app failed to build because there's no Release buildVariant available, it emits an error and lists all available buildVariants) ✅

image


To test it locally clone the repo, checkout to my branch and run run-ios --interactive / run-android --interactive commands.
To check build flavours support for Android add those lines into your android/app/build.gradle file:

 flavorDimensions.add("version")
productFlavors {
prod {
dimension "version"
}
uat {
dimension "version"
}
}

Comment threadpackages/cli-platform-android/src/commands/runAndroid/getTaskNames.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
@TMisiukiewicz

TMisiukiewicz commented Feb 14, 2023

Copy link
Copy Markdown
Collaborator
info Building (using "xcodebuild -workspace NewsApp.xcworkspace -configuration Debug copy -scheme NewsApp -destination id=2C862218-D036-441F-A053-C54C049487FA")
info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/docs/commands.md#doctor error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening NewsApp.xcworkspace.

image

noticed that configuration name in Xcode can contain more than one word, and if it's selected it ends up with an error. Putting this argument in the quote should do the trick, but we should check if there are any other arguments that can have more than one word (both platforms) and fix them too

Good job 👏

Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/listAndroidTasks.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
@adamTrz
adamTrzforce-pushed the feat/interactive-mode branch from 9adff64 to 9516c72CompareFebruary 17, 2023 09:49
@adamTrz

Copy link
Copy Markdown
CollaboratorAuthor
info Building (using "xcodebuild -workspace NewsApp.xcworkspace -configuration Debug copy -scheme NewsApp -destination id=2C862218-D036-441F-A053-C54C049487FA")
info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/docs/commands.md#doctor error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening NewsApp.xcworkspace.

image

noticed that configuration name in Xcode can contain more than one word, and if it's selected it ends up with an error. Putting this argument in the quote should do the trick, but we should check if there are any other arguments that can have more than one word (both platforms) and fix them too

Good job 👏

It works for me @TMisiukiewicz, have you installed pods after creating new configuration? 🙂

@TMisiukiewicz

Copy link
Copy Markdown
Collaborator

@adamTrz you are right, forgot the pods step! All good ✅

Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/buildAndroid/index.ts Outdated

@thymikeethymikee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@szymonrybczakszymonrybczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thymikee
thymikee merged commit 9d17728 into react-native-community:mainFeb 20, 2023
@adamTrz
adamTrz deleted the feat/interactive-mode branch February 20, 2023 20:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@adamTrz@TMisiukiewicz@pawelkata@thymikee@szymonrybczak
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat: interactive mode by adamTrz · Pull Request #1829 · react-native-community/cli · GitHub
Skip to content

feat: interactive mode - #1829

Merged
thymikee merged 4 commits into
react-native-community:mainfrom
adamTrz:feat/interactive-mode
Feb 20, 2023
Merged

feat: interactive mode#1829
thymikee merged 4 commits into
react-native-community:mainfrom
adamTrz:feat/interactive-mode

Conversation

@adamTrz

Copy link
Copy Markdown
Collaborator

Summary:

  • interactive mode for iOS and Android -> user now can select valid scheme and configuration (iOS) or buildVariant (Android) and desired device to run the app on

run-ios-interactive

run-android-interactive

  • support for Android build flavours

run-android-interatcive-flavours

  • some minor fixes and bit of refactoring 🤓

Tested scenarios:

  • run-ios:
    • no devices connected -> works, picked up default scheme and configuration and run on first available device ✅
    • simulator booted -> works, picked up booted simulator ✅
    • --mode Release -> works ✅
    • --mode Bar -> works, app failed to build because there's no Bar configuration available ✅
    • --configuration Release -> works with warning that configuration is deprecated ✅
    • --list-devices works and user can select device from list ✅
    • --interactive works and lets user pick up valid scheme and configuration and device to run on ✅
  • run-android:
    • no device connected -> works, picked up first available AVD and launched the app ✅
    • emulator booted -> works correctly ✅
    • --mode Release -> works correctly ✅
    • --configuration Release -> works with a warning ✅
    • --list-devices -> works and lets user pick up available device/AVD ✅
    • --interactive -> works correctly ✅
    • with build flavours:
      • --mode UatRelease -> works and uses selected build variant both to build and install the app ✅
      • --interactive -> works and lets user pick up available buildVariant and device or AVD ✅
      • --mode Release -> works (app failed to build because there's no Release buildVariant available, it emits an error and lists all available buildVariants) ✅

image


To test it locally clone the repo, checkout to my branch and run run-ios --interactive / run-android --interactive commands.
To check build flavours support for Android add those lines into your android/app/build.gradle file:

 flavorDimensions.add("version")
productFlavors {
prod {
dimension "version"
}
uat {
dimension "version"
}
}

Comment threadpackages/cli-platform-android/src/commands/runAndroid/getTaskNames.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
@TMisiukiewicz

TMisiukiewicz commented Feb 14, 2023

Copy link
Copy Markdown
Collaborator
info Building (using "xcodebuild -workspace NewsApp.xcworkspace -configuration Debug copy -scheme NewsApp -destination id=2C862218-D036-441F-A053-C54C049487FA")
info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/docs/commands.md#doctor error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening NewsApp.xcworkspace.

image

noticed that configuration name in Xcode can contain more than one word, and if it's selected it ends up with an error. Putting this argument in the quote should do the trick, but we should check if there are any other arguments that can have more than one word (both platforms) and fix them too

Good job 👏

Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/listAndroidTasks.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
@adamTrz
adamTrzforce-pushed the feat/interactive-mode branch from 9adff64 to 9516c72CompareFebruary 17, 2023 09:49
@adamTrz

Copy link
Copy Markdown
CollaboratorAuthor
info Building (using "xcodebuild -workspace NewsApp.xcworkspace -configuration Debug copy -scheme NewsApp -destination id=2C862218-D036-441F-A053-C54C049487FA")
info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/docs/commands.md#doctor error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening NewsApp.xcworkspace.

image

noticed that configuration name in Xcode can contain more than one word, and if it's selected it ends up with an error. Putting this argument in the quote should do the trick, but we should check if there are any other arguments that can have more than one word (both platforms) and fix them too

Good job 👏

It works for me @TMisiukiewicz, have you installed pods after creating new configuration? 🙂

@TMisiukiewicz

Copy link
Copy Markdown
Collaborator

@adamTrz you are right, forgot the pods step! All good ✅

Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/buildAndroid/index.ts Outdated

@thymikeethymikee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@szymonrybczakszymonrybczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thymikee
thymikee merged commit 9d17728 into react-native-community:mainFeb 20, 2023
@adamTrz
adamTrz deleted the feat/interactive-mode branch February 20, 2023 20:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@adamTrz@TMisiukiewicz@pawelkata@thymikee@szymonrybczak
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat: interactive mode by adamTrz · Pull Request #1829 · react-native-community/cli · GitHub
Skip to content

feat: interactive mode - #1829

Merged
thymikee merged 4 commits into
react-native-community:mainfrom
adamTrz:feat/interactive-mode
Feb 20, 2023
Merged

feat: interactive mode#1829
thymikee merged 4 commits into
react-native-community:mainfrom
adamTrz:feat/interactive-mode

Conversation

@adamTrz

Copy link
Copy Markdown
Collaborator

Summary:

  • interactive mode for iOS and Android -> user now can select valid scheme and configuration (iOS) or buildVariant (Android) and desired device to run the app on

run-ios-interactive

run-android-interactive

  • support for Android build flavours

run-android-interatcive-flavours

  • some minor fixes and bit of refactoring 🤓

Tested scenarios:

  • run-ios:
    • no devices connected -> works, picked up default scheme and configuration and run on first available device ✅
    • simulator booted -> works, picked up booted simulator ✅
    • --mode Release -> works ✅
    • --mode Bar -> works, app failed to build because there's no Bar configuration available ✅
    • --configuration Release -> works with warning that configuration is deprecated ✅
    • --list-devices works and user can select device from list ✅
    • --interactive works and lets user pick up valid scheme and configuration and device to run on ✅
  • run-android:
    • no device connected -> works, picked up first available AVD and launched the app ✅
    • emulator booted -> works correctly ✅
    • --mode Release -> works correctly ✅
    • --configuration Release -> works with a warning ✅
    • --list-devices -> works and lets user pick up available device/AVD ✅
    • --interactive -> works correctly ✅
    • with build flavours:
      • --mode UatRelease -> works and uses selected build variant both to build and install the app ✅
      • --interactive -> works and lets user pick up available buildVariant and device or AVD ✅
      • --mode Release -> works (app failed to build because there's no Release buildVariant available, it emits an error and lists all available buildVariants) ✅

image


To test it locally clone the repo, checkout to my branch and run run-ios --interactive / run-android --interactive commands.
To check build flavours support for Android add those lines into your android/app/build.gradle file:

 flavorDimensions.add("version")
productFlavors {
prod {
dimension "version"
}
uat {
dimension "version"
}
}

Comment threadpackages/cli-platform-android/src/commands/runAndroid/getTaskNames.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
@TMisiukiewicz

TMisiukiewicz commented Feb 14, 2023

Copy link
Copy Markdown
Collaborator
info Building (using "xcodebuild -workspace NewsApp.xcworkspace -configuration Debug copy -scheme NewsApp -destination id=2C862218-D036-441F-A053-C54C049487FA")
info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/docs/commands.md#doctor error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening NewsApp.xcworkspace.

image

noticed that configuration name in Xcode can contain more than one word, and if it's selected it ends up with an error. Putting this argument in the quote should do the trick, but we should check if there are any other arguments that can have more than one word (both platforms) and fix them too

Good job 👏

Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/listAndroidTasks.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
@adamTrz
adamTrzforce-pushed the feat/interactive-mode branch from 9adff64 to 9516c72CompareFebruary 17, 2023 09:49
@adamTrz

Copy link
Copy Markdown
CollaboratorAuthor
info Building (using "xcodebuild -workspace NewsApp.xcworkspace -configuration Debug copy -scheme NewsApp -destination id=2C862218-D036-441F-A053-C54C049487FA")
info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/docs/commands.md#doctor error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening NewsApp.xcworkspace.

image

noticed that configuration name in Xcode can contain more than one word, and if it's selected it ends up with an error. Putting this argument in the quote should do the trick, but we should check if there are any other arguments that can have more than one word (both platforms) and fix them too

Good job 👏

It works for me @TMisiukiewicz, have you installed pods after creating new configuration? 🙂

@TMisiukiewicz

Copy link
Copy Markdown
Collaborator

@adamTrz you are right, forgot the pods step! All good ✅

Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/buildAndroid/index.ts Outdated

@thymikeethymikee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@szymonrybczakszymonrybczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thymikee
thymikee merged commit 9d17728 into react-native-community:mainFeb 20, 2023
@adamTrz
adamTrz deleted the feat/interactive-mode branch February 20, 2023 20:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@adamTrz@TMisiukiewicz@pawelkata@thymikee@szymonrybczak
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat: interactive mode by adamTrz · Pull Request #1829 · react-native-community/cli · GitHub
Skip to content

feat: interactive mode - #1829

Merged
thymikee merged 4 commits into
react-native-community:mainfrom
adamTrz:feat/interactive-mode
Feb 20, 2023
Merged

feat: interactive mode#1829
thymikee merged 4 commits into
react-native-community:mainfrom
adamTrz:feat/interactive-mode

Conversation

@adamTrz

Copy link
Copy Markdown
Collaborator

Summary:

  • interactive mode for iOS and Android -> user now can select valid scheme and configuration (iOS) or buildVariant (Android) and desired device to run the app on

run-ios-interactive

run-android-interactive

  • support for Android build flavours

run-android-interatcive-flavours

  • some minor fixes and bit of refactoring 🤓

Tested scenarios:

  • run-ios:
    • no devices connected -> works, picked up default scheme and configuration and run on first available device ✅
    • simulator booted -> works, picked up booted simulator ✅
    • --mode Release -> works ✅
    • --mode Bar -> works, app failed to build because there's no Bar configuration available ✅
    • --configuration Release -> works with warning that configuration is deprecated ✅
    • --list-devices works and user can select device from list ✅
    • --interactive works and lets user pick up valid scheme and configuration and device to run on ✅
  • run-android:
    • no device connected -> works, picked up first available AVD and launched the app ✅
    • emulator booted -> works correctly ✅
    • --mode Release -> works correctly ✅
    • --configuration Release -> works with a warning ✅
    • --list-devices -> works and lets user pick up available device/AVD ✅
    • --interactive -> works correctly ✅
    • with build flavours:
      • --mode UatRelease -> works and uses selected build variant both to build and install the app ✅
      • --interactive -> works and lets user pick up available buildVariant and device or AVD ✅
      • --mode Release -> works (app failed to build because there's no Release buildVariant available, it emits an error and lists all available buildVariants) ✅

image


To test it locally clone the repo, checkout to my branch and run run-ios --interactive / run-android --interactive commands.
To check build flavours support for Android add those lines into your android/app/build.gradle file:

 flavorDimensions.add("version")
productFlavors {
prod {
dimension "version"
}
uat {
dimension "version"
}
}

Comment threadpackages/cli-platform-android/src/commands/runAndroid/getTaskNames.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
@TMisiukiewicz

TMisiukiewicz commented Feb 14, 2023

Copy link
Copy Markdown
Collaborator
info Building (using "xcodebuild -workspace NewsApp.xcworkspace -configuration Debug copy -scheme NewsApp -destination id=2C862218-D036-441F-A053-C54C049487FA")
info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/docs/commands.md#doctor error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening NewsApp.xcworkspace.

image

noticed that configuration name in Xcode can contain more than one word, and if it's selected it ends up with an error. Putting this argument in the quote should do the trick, but we should check if there are any other arguments that can have more than one word (both platforms) and fix them too

Good job 👏

Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/listAndroidTasks.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
@adamTrz
adamTrzforce-pushed the feat/interactive-mode branch from 9adff64 to 9516c72CompareFebruary 17, 2023 09:49
@adamTrz

Copy link
Copy Markdown
CollaboratorAuthor
info Building (using "xcodebuild -workspace NewsApp.xcworkspace -configuration Debug copy -scheme NewsApp -destination id=2C862218-D036-441F-A053-C54C049487FA")
info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/docs/commands.md#doctor error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening NewsApp.xcworkspace.

image

noticed that configuration name in Xcode can contain more than one word, and if it's selected it ends up with an error. Putting this argument in the quote should do the trick, but we should check if there are any other arguments that can have more than one word (both platforms) and fix them too

Good job 👏

It works for me @TMisiukiewicz, have you installed pods after creating new configuration? 🙂

@TMisiukiewicz

Copy link
Copy Markdown
Collaborator

@adamTrz you are right, forgot the pods step! All good ✅

Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/buildAndroid/index.ts Outdated

@thymikeethymikee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@szymonrybczakszymonrybczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thymikee
thymikee merged commit 9d17728 into react-native-community:mainFeb 20, 2023
@adamTrz
adamTrz deleted the feat/interactive-mode branch February 20, 2023 20:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@adamTrz@TMisiukiewicz@pawelkata@thymikee@szymonrybczak
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat: interactive mode by adamTrz · Pull Request #1829 · react-native-community/cli · GitHub
Skip to content

feat: interactive mode - #1829

Merged
thymikee merged 4 commits into
react-native-community:mainfrom
adamTrz:feat/interactive-mode
Feb 20, 2023
Merged

feat: interactive mode#1829
thymikee merged 4 commits into
react-native-community:mainfrom
adamTrz:feat/interactive-mode

Conversation

@adamTrz

Copy link
Copy Markdown
Collaborator

Summary:

  • interactive mode for iOS and Android -> user now can select valid scheme and configuration (iOS) or buildVariant (Android) and desired device to run the app on

run-ios-interactive

run-android-interactive

  • support for Android build flavours

run-android-interatcive-flavours

  • some minor fixes and bit of refactoring 🤓

Tested scenarios:

  • run-ios:
    • no devices connected -> works, picked up default scheme and configuration and run on first available device ✅
    • simulator booted -> works, picked up booted simulator ✅
    • --mode Release -> works ✅
    • --mode Bar -> works, app failed to build because there's no Bar configuration available ✅
    • --configuration Release -> works with warning that configuration is deprecated ✅
    • --list-devices works and user can select device from list ✅
    • --interactive works and lets user pick up valid scheme and configuration and device to run on ✅
  • run-android:
    • no device connected -> works, picked up first available AVD and launched the app ✅
    • emulator booted -> works correctly ✅
    • --mode Release -> works correctly ✅
    • --configuration Release -> works with a warning ✅
    • --list-devices -> works and lets user pick up available device/AVD ✅
    • --interactive -> works correctly ✅
    • with build flavours:
      • --mode UatRelease -> works and uses selected build variant both to build and install the app ✅
      • --interactive -> works and lets user pick up available buildVariant and device or AVD ✅
      • --mode Release -> works (app failed to build because there's no Release buildVariant available, it emits an error and lists all available buildVariants) ✅

image


To test it locally clone the repo, checkout to my branch and run run-ios --interactive / run-android --interactive commands.
To check build flavours support for Android add those lines into your android/app/build.gradle file:

 flavorDimensions.add("version")
productFlavors {
prod {
dimension "version"
}
uat {
dimension "version"
}
}

Comment threadpackages/cli-platform-android/src/commands/runAndroid/getTaskNames.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
@TMisiukiewicz

TMisiukiewicz commented Feb 14, 2023

Copy link
Copy Markdown
Collaborator
info Building (using "xcodebuild -workspace NewsApp.xcworkspace -configuration Debug copy -scheme NewsApp -destination id=2C862218-D036-441F-A053-C54C049487FA")
info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/docs/commands.md#doctor error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening NewsApp.xcworkspace.

image

noticed that configuration name in Xcode can contain more than one word, and if it's selected it ends up with an error. Putting this argument in the quote should do the trick, but we should check if there are any other arguments that can have more than one word (both platforms) and fix them too

Good job 👏

Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/listAndroidTasks.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
@adamTrz
adamTrzforce-pushed the feat/interactive-mode branch from 9adff64 to 9516c72CompareFebruary 17, 2023 09:49
@adamTrz

Copy link
Copy Markdown
CollaboratorAuthor
info Building (using "xcodebuild -workspace NewsApp.xcworkspace -configuration Debug copy -scheme NewsApp -destination id=2C862218-D036-441F-A053-C54C049487FA")
info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/docs/commands.md#doctor error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening NewsApp.xcworkspace.

image

noticed that configuration name in Xcode can contain more than one word, and if it's selected it ends up with an error. Putting this argument in the quote should do the trick, but we should check if there are any other arguments that can have more than one word (both platforms) and fix them too

Good job 👏

It works for me @TMisiukiewicz, have you installed pods after creating new configuration? 🙂

@TMisiukiewicz

Copy link
Copy Markdown
Collaborator

@adamTrz you are right, forgot the pods step! All good ✅

Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/buildAndroid/index.ts Outdated

@thymikeethymikee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@szymonrybczakszymonrybczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thymikee
thymikee merged commit 9d17728 into react-native-community:mainFeb 20, 2023
@adamTrz
adamTrz deleted the feat/interactive-mode branch February 20, 2023 20:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@adamTrz@TMisiukiewicz@pawelkata@thymikee@szymonrybczak
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat: interactive mode by adamTrz · Pull Request #1829 · react-native-community/cli · GitHub
Skip to content

feat: interactive mode - #1829

Merged
thymikee merged 4 commits into
react-native-community:mainfrom
adamTrz:feat/interactive-mode
Feb 20, 2023
Merged

feat: interactive mode#1829
thymikee merged 4 commits into
react-native-community:mainfrom
adamTrz:feat/interactive-mode

Conversation

@adamTrz

Copy link
Copy Markdown
Collaborator

Summary:

  • interactive mode for iOS and Android -> user now can select valid scheme and configuration (iOS) or buildVariant (Android) and desired device to run the app on

run-ios-interactive

run-android-interactive

  • support for Android build flavours

run-android-interatcive-flavours

  • some minor fixes and bit of refactoring 🤓

Tested scenarios:

  • run-ios:
    • no devices connected -> works, picked up default scheme and configuration and run on first available device ✅
    • simulator booted -> works, picked up booted simulator ✅
    • --mode Release -> works ✅
    • --mode Bar -> works, app failed to build because there's no Bar configuration available ✅
    • --configuration Release -> works with warning that configuration is deprecated ✅
    • --list-devices works and user can select device from list ✅
    • --interactive works and lets user pick up valid scheme and configuration and device to run on ✅
  • run-android:
    • no device connected -> works, picked up first available AVD and launched the app ✅
    • emulator booted -> works correctly ✅
    • --mode Release -> works correctly ✅
    • --configuration Release -> works with a warning ✅
    • --list-devices -> works and lets user pick up available device/AVD ✅
    • --interactive -> works correctly ✅
    • with build flavours:
      • --mode UatRelease -> works and uses selected build variant both to build and install the app ✅
      • --interactive -> works and lets user pick up available buildVariant and device or AVD ✅
      • --mode Release -> works (app failed to build because there's no Release buildVariant available, it emits an error and lists all available buildVariants) ✅

image


To test it locally clone the repo, checkout to my branch and run run-ios --interactive / run-android --interactive commands.
To check build flavours support for Android add those lines into your android/app/build.gradle file:

 flavorDimensions.add("version")
productFlavors {
prod {
dimension "version"
}
uat {
dimension "version"
}
}

Comment threadpackages/cli-platform-android/src/commands/runAndroid/getTaskNames.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
@TMisiukiewicz

TMisiukiewicz commented Feb 14, 2023

Copy link
Copy Markdown
Collaborator
info Building (using "xcodebuild -workspace NewsApp.xcworkspace -configuration Debug copy -scheme NewsApp -destination id=2C862218-D036-441F-A053-C54C049487FA")
info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/docs/commands.md#doctor error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening NewsApp.xcworkspace.

image

noticed that configuration name in Xcode can contain more than one word, and if it's selected it ends up with an error. Putting this argument in the quote should do the trick, but we should check if there are any other arguments that can have more than one word (both platforms) and fix them too

Good job 👏

Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/listAndroidTasks.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
@adamTrz
adamTrzforce-pushed the feat/interactive-mode branch from 9adff64 to 9516c72CompareFebruary 17, 2023 09:49
@adamTrz

Copy link
Copy Markdown
CollaboratorAuthor
info Building (using "xcodebuild -workspace NewsApp.xcworkspace -configuration Debug copy -scheme NewsApp -destination id=2C862218-D036-441F-A053-C54C049487FA")
info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/docs/commands.md#doctor error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening NewsApp.xcworkspace.

image

noticed that configuration name in Xcode can contain more than one word, and if it's selected it ends up with an error. Putting this argument in the quote should do the trick, but we should check if there are any other arguments that can have more than one word (both platforms) and fix them too

Good job 👏

It works for me @TMisiukiewicz, have you installed pods after creating new configuration? 🙂

@TMisiukiewicz

Copy link
Copy Markdown
Collaborator

@adamTrz you are right, forgot the pods step! All good ✅

Comment threadpackages/cli-platform-android/src/commands/runAndroid/index.ts Outdated
Comment threadpackages/cli-platform-android/src/commands/buildAndroid/index.ts Outdated

@thymikeethymikee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@szymonrybczakszymonrybczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thymikee
thymikee merged commit 9d17728 into react-native-community:mainFeb 20, 2023
@adamTrz
adamTrz deleted the feat/interactive-mode branch February 20, 2023 20:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@adamTrz@TMisiukiewicz@pawelkata@thymikee@szymonrybczak