breaking: node 16; typescript 4#1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 2 commits into from
Mar 9, 2023
Merged

breaking: node 16; typescript 4 #1844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e1ac87
breaking: node 16; typescript 4
thymikee Feb 20, 2023
a510b91
fixup deepmerge
thymikee Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14, 16, 18]
node-version: [16, 18]
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
2 changes: 1 addition & 1 deletion babel.config.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ module.exports = {
[
require.resolve('@babel/preset-env'),
{
targets: {node: '14'},
targets: {node: '16'},
useBuiltIns: 'entry',
corejs: '2.x',
},
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@
"@react-native-community/eslint-config": "^2.0.0",
"@types/glob": "^7.1.1",
"@types/jest": "^26.0.15",
"@types/node": "^14.0.0",
"@types/node": "^16.0.0",
"@types/node-fetch": "^2.3.7",
"@types/rimraf": "^3.0.2",
"@types/readable-stream": "^2.3.0",
Expand All@@ -55,10 +55,10 @@
"rimraf": "^3.0.2",
"slash": "^3.0.0",
"string-length": "^2.0.0",
"typescript": "^3.8.0"
"typescript": "^4.9.5"
},
"resolutions": {
"@types/node": "^14.0.0"
"@types/node": "^16.0.0"
},
"lint-staged": {
"./packages/**/*.{ts}": [
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-config/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
"@react-native-community/cli-tools": "^10.1.1",
"chalk": "^4.1.2",
"cosmiconfig": "^5.1.0",
"deepmerge": "^3.2.0",
"deepmerge": "^4.3.0",

@thymikeethymikeeFeb 20, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this turned out to be unnecessary, but checking the release notes the only breaking change is umd -> cjs, which is fine for us

"glob": "^7.1.3",
"joi": "^17.2.1"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-config/src/merge.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ import deepmerge from 'deepmerge';
* `deepmerge` concatenates arrays by default instead of overwriting them.
* We define custom merging function for arrays to change that behaviour
*/
export default function merge<X, Y>(x: X, y: Y) {
export default function merge<X, Y>(x: Partial<X>, y: Partial<Y>) {
return deepmerge(x, y, {
arrayMerge: (_destinationArray: any[], sourceArray: any[]): any[] =>
sourceArray,
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-doctor/src/tools/brewInstall.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ async function brewInstall({
logError({
healthcheck: label || pkg,
loader,
error,
error: error as any,
command: `brew install ${pkg}`,
});
}
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-doctor/src/tools/healthchecks/cocoaPods.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,7 +58,7 @@ export default {
logError({
healthcheck: label,
loader,
error,
error: error as any,
command: 'sudo gem install cocoapods',
});
}
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-doctor/src/tools/healthchecks/iosDeploy.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,7 +44,7 @@ const installLibrary = async ({
logError({
healthcheck: label,
loader,
error,
error: error as Error,
command: installationCommand,
});
}
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-doctor/src/tools/healthchecks/jdk.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,7 @@ export default {
'JDK installed successfully. Please restart your shell to see the changes',
);
} catch (e) {
loader.fail(e);
loader.fail(e as any);
}
},
runAutomaticFix: async ({logManualInstallation, loader}) => {
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-doctor/src/tools/healthchecks/xcodeEnv.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -65,7 +65,7 @@ export default {
});
loader.succeed('.xcode.env file have been created!');
} catch (e) {
loader.fail(e);
loader.fail(e as any);
}
},
} as HealthCheckInterface;
6 changes: 3 additions & 3 deletions packages/cli-doctor/src/tools/installPods.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,7 @@ async function runPodInstall(
await execa('bundle', ['exec', 'pod', 'install']);
} catch (error) {
// "pod" command outputs errors to stdout (at least some of them)
const stderr = error.stderr || error.stdout;
const stderr = (error as any).stderr || (error as any).stdout;

/**
* If CocoaPods failed due to repo being out of date, it will
Expand DownExpand Up@@ -61,7 +61,7 @@ async function runPodUpdate(loader: Loader) {
await execa('pod', ['repo', 'update']);
} catch (error) {
// "pod" command outputs errors to stdout (at least some of them)
logger.log(error.stderr || error.stdout);
logger.log((error as any).stderr || (error as any).stdout);
loader.fail();

throw new Error(
Expand DownExpand Up@@ -142,7 +142,7 @@ async function installCocoaPods(loader: Loader) {
return loader.succeed();
} catch (error) {
loader.fail();
logger.error(error.stderr);
logger.error((error as any).stderr);

throw new Error(
`An error occured while trying to install CocoaPods, which is required by this template.\nPlease try again manually: sudo gem install cocoapods.\nCocoaPods documentation: ${chalk.dim.underline(
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-doctor/src/tools/runBundleInstall.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ async function runBundleInstall(loader: Loader) {
await execa('bundle', ['install']);
} catch (error) {
loader.fail();
logger.error(error.stderr || error.stdout);
logger.error((error as any).stderr || (error as any).stdout);

throw new Error(
'Looks like your iOS environment is not properly set. Please go to https://reactnative.dev/docs/next/environment-setup and follow the React Native CLI QuickStart guide for macOS and iOS.',
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-doctor/src/tools/unzip.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ const unzip = async (source: string, destination: string) => {
return reject(err);
}

resolve();
resolve(undefined);
});
});
});
Expand Down
6 changes: 3 additions & 3 deletions packages/cli-doctor/src/tools/windows/androidWinHelpers.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ export const installComponent = (component: string, androidSdkRoot: string) => {

child.on('close', (exitStatus) => {
if (exitStatus === 0) {
done();
done(undefined);
} else {
error({stderr});
}
Expand DownExpand Up@@ -161,7 +161,7 @@ const getEmulatorAccelOutputInformation = async (androidSDKRoot: string) => {

return stdout;
} catch (e) {
const {stdout} = e;
const {stdout} = e as any;

return stdout;
}
Expand DownExpand Up@@ -205,7 +205,7 @@ export const createAVD = async (

return stdout;
} catch (e) {
const {stderr} = e;
const {stderr} = e as any;

return stderr;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-hermes/src/profileHermes/downloadProfile.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,7 @@ function getLatestFile(packageNameWithSuffix: string): string {
`);
return file.toString().trim();
} catch (e) {
throw new Error(e);
throw e;
}
}

Expand Down
4 changes: 2 additions & 2 deletions packages/cli-hermes/src/profileHermes/sourcemapUtils.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,14 +17,14 @@ function writeJsonSync(targetPath: string, data: any) {
} catch (e) {
throw new CLIError(
`Failed to serialize data to json before writing to ${targetPath}`,
e,
e as Error,
);
}

try {
fs.writeFileSync(targetPath, json, 'utf-8');
} catch (e) {
throw new CLIError(`Failed to write json to ${targetPath}`, e);
throw new CLIError(`Failed to write json to ${targetPath}`, e as Error);
}
}

Expand Down
10 changes: 6 additions & 4 deletions packages/cli-platform-android/src/commands/buildAndroid/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,9 +41,11 @@ export async function runPackager(args: BuildFlags, config: Config) {
try {
startServerInNewWindow(args.port, args.terminal, config.reactNativePath);
} catch (error) {
logger.warn(
`Failed to automatically start the packager server. Please run "react-native start" manually. Error details: ${error.message}`,
);
if (error instanceof Error) {
logger.warn(
`Failed to automatically start the packager server. Please run "react-native start" manually. Error details: ${error.message}`,
);
}
}
}
}
Expand DownExpand Up@@ -126,7 +128,7 @@ export function build(gradleArgs: string[], sourceDir: string) {
});
} catch (error) {
printRunDoctorTip();
throw new CLIError('Failed to build the app.', error);
throw new CLIError('Failed to build the app.', error as Error);
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/cli-platform-android/src/commands/runAndroid/runOnAllDevices.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -104,7 +104,7 @@ async function runOnAllDevices(
}
} catch (error) {
printRunDoctorTip();
throw createInstallError(error);
throw createInstallError(error as any);
}

(devices.length > 0 ? devices : [undefined]).forEach(
Expand Down
5 changes: 4 additions & 1 deletion packages/cli-platform-android/src/commands/runAndroid/tryInstallAppOnDevice.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,10 @@ function tryInstallAppOnDevice(
);
execa.sync(adbPath, adbArgs, {stdio: 'inherit'});
} catch (error) {
throw new CLIError('Failed to install the app on the device.', error);
throw new CLIError(
'Failed to install the app on the device.',
error as any,
);
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/cli-platform-android/src/commands/runAndroid/tryLaunchAppOnDevice.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ function tryLaunchAppOnDevice(
logger.debug(`Running command "${adbPath} ${adbArgs.join(' ')}"`);
execa.sync(adbPath, adbArgs, {stdio: 'inherit'});
} catch (error) {
throw new CLIError('Failed to start the app.', error);
throw new CLIError('Failed to start the app.', error as any);
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/cli-platform-android/src/commands/runAndroid/tryLaunchEmulator.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@ export default async function tryLaunchEmulator(
await launchEmulator(emulatorName ?? emulators[0], adbPath, port);
return {success: true};
} catch (error) {
return {success: false, error: error?.message};
return {success: false, error: (error as any)?.message};
}
}
return {
Expand Down
4 changes: 3 additions & 1 deletion packages/cli-platform-android/src/commands/runAndroid/tryRunAdbReverse.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,9 @@ function tryRunAdbReverse(
execFileSync(adbPath, adbArgs, {stdio: 'inherit'});
} catch (e) {
logger.warn(
`Failed to connect to development server using "adb reverse": ${e.message}`,
`Failed to connect to development server using "adb reverse": ${
(e as any).message
}`,
);
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-platform-ios/src/commands/runIOS/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,7 +209,7 @@ const getSimulators = () => {
} catch (error) {
throw new CLIError(
'Could not get the simulator list from Xcode. Please open Xcode and try running project directly from there to resolve the remaining issues.',
error,
error as Error,
);
}
return simulators;
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-platform-ios/src/tools/getDestinationSimulator.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ export function getDestinationSimulator(
} catch (error) {
throw new CLIError(
'Could not get the simulator list from Xcode. Please open Xcode and try running project directly from there to resolve the remaining issues.',
error,
error as Error,
);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/cli-platform-ios/src/tools/getProjectInfo.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,6 @@ export function getProjectInfo(): IosProjectInfo {

return project;
} catch (error) {
throw new CLIError(error);
throw new CLIError(error as any);
}
}
6 changes: 3 additions & 3 deletions packages/cli-server-api/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,16 +11,16 @@
"@react-native-community/cli-tools": "^10.1.1",
"compression": "^1.7.1",
"connect": "^3.6.5",
"errorhandler": "^1.5.0",
"errorhandler": "^1.5.1",
"nocache": "^3.0.1",
"pretty-format": "^26.6.2",
"serve-static": "^1.13.1",
"ws": "^7.5.1"
},
"devDependencies": {
"@types/compression": "^1.0.1",
"@types/compression": "^1.7.2",
"@types/connect": "^3.4.33",
"@types/errorhandler": "^0.0.32",
"@types/errorhandler": "^1.5.0",
"@types/ws": "^7.4.7"
},
"files": [
Expand Down
2 changes: 2 additions & 0 deletions packages/cli-server-api/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,11 +58,13 @@ export function createDevServerMiddleware(options: MiddlewareOptions) {
.use('/open-url', openURLMiddleware)
.use('/status', statusPageMiddleware)
.use('/symbolicate', rawBodyMiddleware)
// @ts-ignore mismatch
.use('/systrace', systraceProfileMiddleware)
.use('/reload', (_req: http.IncomingMessage, res: http.ServerResponse) => {
broadcast('reload');
res.end('OK');
})
// @ts-ignore mismatch
.use(errorhandler());

options.watchFolders.forEach((folder) => {
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-server-api/src/websocket/createDebuggerProxyEndpoint.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ export default function createDebuggerProxyEndpoint(): {
try {
dest.send(message);
} catch (e) {
logger.warn(e);
logger.warn(e as any);
// Sometimes this call throws 'not opened'
}
}
Expand Down
4 changes: 2 additions & 2 deletions packages/cli-server-api/src/websocket/createEventsSocketEndpoint.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ export default function createEventsSocketEndpoint(
ws.send(serialized);
} catch (e) {
logger.error(
`Failed to send broadcast to client due to:\n ${e.toString()}`,
`Failed to send broadcast to client due to:\n ${(e as any).toString()}`,
);
}
}
Expand DownExpand Up@@ -178,7 +178,7 @@ export default function createEventsSocketEndpoint(
*/
broadcast(message.command, message.params);
} catch (e) {
logger.error('Failed to forward message to clients: ', e);
logger.error('Failed to forward message to clients: ', e as any);
}
} else {
logger.error('Unknown message type: ', message.type);
Expand Down
6 changes: 3 additions & 3 deletions packages/cli-server-api/src/websocket/createMessageSocketEndpoint.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -109,7 +109,7 @@ export default function createMessageSocketEndpoint(): {
} catch (e) {
logger.error(
`Failed to send broadcast to client: '${otherId}' ` +
`due to:\n ${e.toString()}`,
`due to:\n ${(e as any).toString()}`,
);
}
}
Expand DownExpand Up@@ -147,7 +147,7 @@ export default function createMessageSocketEndpoint(): {
logger.error(
`Failed to reply to ${clientId} with error:\n${error}` +
`\nmessage:\n${JSON.stringify(errorMessage)}` +
`\ndue to error: ${e.toString()}`,
`\ndue to error: ${(e as any).toString()}`,
);
}
}
Expand DownExpand Up@@ -237,7 +237,7 @@ export default function createMessageSocketEndpoint(): {
throw new Error('Invalid message, did not match the protocol');
}
} catch (e) {
handleCaughtError(message, e.toString());
handleCaughtError(message, (e as any).toString());
}
};
});
Expand Down
2 changes: 1 addition & 1 deletion packages/cli-tools/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@
"@react-native-community/cli-types": "^10.0.0",
"@types/lodash": "^4.14.149",
"@types/mime": "^2.0.1",
"@types/node": "^14.0.0",
"@types/node": "^16.0.0",
"@types/node-fetch": "^2.5.5",
"@types/shell-quote": "^1.7.1"
},
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
breaking: node 16; typescript 4#1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

thymikee
merged 2 commits into

from

Mar 9, 2023
 Merged


breaking: node 16; typescript 4
#1844
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
0e1ac87

breaking: node 16; typescript 4


thymikee Feb 20, 2023
a510b91

fixup deepmerge


thymikee Feb 20, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.github/workflows/test.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ jobs:
 runs-on: ubuntu-latest
 strategy:
 matrix:
 node-version: [14, 16, 18]
 node-version: [16, 18]
 steps:
 - uses: actions/checkout@v2
 - name: Use Node.js ${{ matrix.node-version }}
Expand Down

2 changes: 1 addition & 1 deletion
babel.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ module.exports = {
 [
 require.resolve('@babel/preset-env'),
 {
 targets: {node: '14'},
 targets: {node: '16'},
 useBuiltIns: 'entry',
 corejs: '2.x',
 },
Expand Down

6 changes: 3 additions & 3 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@
 "@react-native-community/eslint-config": "^2.0.0",
 "@types/glob": "^7.1.1",
 "@types/jest": "^26.0.15",
 "@types/node": "^14.0.0",
 "@types/node": "^16.0.0",
 "@types/node-fetch": "^2.3.7",
 "@types/rimraf": "^3.0.2",
 "@types/readable-stream": "^2.3.0",
Expand All@@ -55,10 +55,10 @@
 "rimraf": "^3.0.2",
 "slash": "^3.0.0",
 "string-length": "^2.0.0",
 "typescript": "^3.8.0"
 "typescript": "^4.9.5"
 },
 "resolutions": {
 "@types/node": "^14.0.0"
 "@types/node": "^16.0.0"
 },
 "lint-staged": {
 "./packages/**/*.{ts}": [
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-config/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "@react-native-community/cli-tools": "^10.1.1",
 "chalk": "^4.1.2",
 "cosmiconfig": "^5.1.0",
 "deepmerge": "^3.2.0",
 "deepmerge": "^4.3.0",
@thymikeethymikeeFeb 20, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this turned out to be unnecessary, but checking the release notes the only breaking change is umd -> cjs, which is fine for us
 "glob": "^7.1.3",
 "joi": "^17.2.1"
 },
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-config/src/merge.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ import deepmerge from 'deepmerge';
 * `deepmerge` concatenates arrays by default instead of overwriting them.
 * We define custom merging function for arrays to change that behaviour
 */
export default function merge<X, Y>(x: X, y: Y) {
export default function merge<X, Y>(x: Partial<X>, y: Partial<Y>) {
 return deepmerge(x, y, {
 arrayMerge: (_destinationArray: any[], sourceArray: any[]): any[] =>
 sourceArray,
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/brewInstall.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ async function brewInstall({
 logError({
 healthcheck: label || pkg,
 loader,
 error,
 error: error as any,
 command: `brew install ${pkg}`,
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/cocoaPods.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,7 +58,7 @@ export default {
 logError({
 healthcheck: label,
 loader,
 error,
 error: error as any,
 command: 'sudo gem install cocoapods',
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/iosDeploy.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,7 +44,7 @@ const installLibrary = async ({
 logError({
 healthcheck: label,
 loader,
 error,
 error: error as Error,
 command: installationCommand,
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/jdk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,7 @@ export default {
 'JDK installed successfully. Please restart your shell to see the changes',
 );
 } catch (e) {
 loader.fail(e);
 loader.fail(e as any);
 }
 },
 runAutomaticFix: async ({logManualInstallation, loader}) => {
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/xcodeEnv.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -65,7 +65,7 @@ export default {
 });
 loader.succeed('.xcode.env file have been created!');
 } catch (e) {
 loader.fail(e);
 loader.fail(e as any);
 }
 },
} as HealthCheckInterface;

6 changes: 3 additions & 3 deletions
packages/cli-doctor/src/tools/installPods.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,7 @@ async function runPodInstall(
 await execa('bundle', ['exec', 'pod', 'install']);
 } catch (error) {
 // "pod" command outputs errors to stdout (at least some of them)
 const stderr = error.stderr || error.stdout;
 const stderr = (error as any).stderr || (error as any).stdout;

 /**
 * If CocoaPods failed due to repo being out of date, it will
Expand DownExpand Up@@ -61,7 +61,7 @@ async function runPodUpdate(loader: Loader) {
 await execa('pod', ['repo', 'update']);
 } catch (error) {
 // "pod" command outputs errors to stdout (at least some of them)
 logger.log(error.stderr || error.stdout);
 logger.log((error as any).stderr || (error as any).stdout);
 loader.fail();

 throw new Error(
Expand DownExpand Up@@ -142,7 +142,7 @@ async function installCocoaPods(loader: Loader) {
 return loader.succeed();
 } catch (error) {
 loader.fail();
 logger.error(error.stderr);
 logger.error((error as any).stderr);

 throw new Error(
 `An error occured while trying to install CocoaPods, which is required by this template.\nPlease try again manually: sudo gem install cocoapods.\nCocoaPods documentation: ${chalk.dim.underline(
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/runBundleInstall.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ async function runBundleInstall(loader: Loader) {
 await execa('bundle', ['install']);
 } catch (error) {
 loader.fail();
 logger.error(error.stderr || error.stdout);
 logger.error((error as any).stderr || (error as any).stdout);

 throw new Error(
 'Looks like your iOS environment is not properly set. Please go to https://reactnative.dev/docs/next/environment-setup and follow the React Native CLI QuickStart guide for macOS and iOS.',
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/unzip.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ const unzip = async (source: string, destination: string) => {
 return reject(err);
 }

 resolve();
 resolve(undefined);
 });
 });
 });
Expand Down

6 changes: 3 additions & 3 deletions
packages/cli-doctor/src/tools/windows/androidWinHelpers.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ export const installComponent = (component: string, androidSdkRoot: string) => {

 child.on('close', (exitStatus) => {
 if (exitStatus === 0) {
 done();
 done(undefined);
 } else {
 error({stderr});
 }
Expand DownExpand Up@@ -161,7 +161,7 @@ const getEmulatorAccelOutputInformation = async (androidSDKRoot: string) => {

 return stdout;
 } catch (e) {
 const {stdout} = e;
 const {stdout} = e as any;

 return stdout;
 }
Expand DownExpand Up@@ -205,7 +205,7 @@ export const createAVD = async (

 return stdout;
 } catch (e) {
 const {stderr} = e;
 const {stderr} = e as any;

 return stderr;
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-hermes/src/profileHermes/downloadProfile.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,7 @@ function getLatestFile(packageNameWithSuffix: string): string {
 `);
 return file.toString().trim();
 } catch (e) {
 throw new Error(e);
 throw e;
 }
}

Expand Down

4 changes: 2 additions & 2 deletions
packages/cli-hermes/src/profileHermes/sourcemapUtils.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,14 +17,14 @@ function writeJsonSync(targetPath: string, data: any) {
 } catch (e) {
 throw new CLIError(
 `Failed to serialize data to json before writing to ${targetPath}`,
 e,
 e as Error,
 );
 }

 try {
 fs.writeFileSync(targetPath, json, 'utf-8');
 } catch (e) {
 throw new CLIError(`Failed to write json to ${targetPath}`, e);
 throw new CLIError(`Failed to write json to ${targetPath}`, e as Error);
 }
}

Expand Down

10 changes: 6 additions & 4 deletions
packages/cli-platform-android/src/commands/buildAndroid/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,9 +41,11 @@ export async function runPackager(args: BuildFlags, config: Config) {
 try {
 startServerInNewWindow(args.port, args.terminal, config.reactNativePath);
 } catch (error) {
 logger.warn(
 `Failed to automatically start the packager server. Please run "react-native start" manually. Error details: ${error.message}`,
 );
 if (error instanceof Error) {
 logger.warn(
 `Failed to automatically start the packager server. Please run "react-native start" manually. Error details: ${error.message}`,
 );
 }
 }
 }
}
Expand DownExpand Up@@ -126,7 +128,7 @@ export function build(gradleArgs: string[], sourceDir: string) {
 });
 } catch (error) {
 printRunDoctorTip();
 throw new CLIError('Failed to build the app.', error);
 throw new CLIError('Failed to build the app.', error as Error);
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/runOnAllDevices.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -104,7 +104,7 @@ async function runOnAllDevices(
 }
 } catch (error) {
 printRunDoctorTip();
 throw createInstallError(error);
 throw createInstallError(error as any);
 }

 (devices.length > 0 ? devices : [undefined]).forEach(
Expand Down

5 changes: 4 additions & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryInstallAppOnDevice.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,10 @@ function tryInstallAppOnDevice(
 );
 execa.sync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (error) {
 throw new CLIError('Failed to install the app on the device.', error);
 throw new CLIError(
 'Failed to install the app on the device.',
 error as any,
 );
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryLaunchAppOnDevice.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ function tryLaunchAppOnDevice(
 logger.debug(`Running command "${adbPath} ${adbArgs.join(' ')}"`);
 execa.sync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (error) {
 throw new CLIError('Failed to start the app.', error);
 throw new CLIError('Failed to start the app.', error as any);
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryLaunchEmulator.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@ export default async function tryLaunchEmulator(
 await launchEmulator(emulatorName ?? emulators[0], adbPath, port);
 return {success: true};
 } catch (error) {
 return {success: false, error: error?.message};
 return {success: false, error: (error as any)?.message};
 }
 }
 return {
Expand Down

4 changes: 3 additions & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryRunAdbReverse.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,9 @@ function tryRunAdbReverse(
 execFileSync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (e) {
 logger.warn(
 `Failed to connect to development server using "adb reverse": ${e.message}`,
 `Failed to connect to development server using "adb reverse": ${
 (e as any).message
 }`,
 );
 }
}
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/commands/runIOS/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -209,7 +209,7 @@ const getSimulators = () => {
 } catch (error) {
 throw new CLIError(
 'Could not get the simulator list from Xcode. Please open Xcode and try running project directly from there to resolve the remaining issues.',
 error,
 error as Error,
 );
 }
 return simulators;
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/tools/getDestinationSimulator.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ export function getDestinationSimulator(
 } catch (error) {
 throw new CLIError(
 'Could not get the simulator list from Xcode. Please open Xcode and try running project directly from there to resolve the remaining issues.',
 error,
 error as Error,
 );
 }

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/tools/getProjectInfo.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,6 @@ export function getProjectInfo(): IosProjectInfo {

 return project;
 } catch (error) {
 throw new CLIError(error);
 throw new CLIError(error as any);
 }
}

6 changes: 3 additions & 3 deletions
packages/cli-server-api/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,16 +11,16 @@
 "@react-native-community/cli-tools": "^10.1.1",
 "compression": "^1.7.1",
 "connect": "^3.6.5",
 "errorhandler": "^1.5.0",
 "errorhandler": "^1.5.1",
 "nocache": "^3.0.1",
 "pretty-format": "^26.6.2",
 "serve-static": "^1.13.1",
 "ws": "^7.5.1"
 },
 "devDependencies": {
 "@types/compression": "^1.0.1",
 "@types/compression": "^1.7.2",
 "@types/connect": "^3.4.33",
 "@types/errorhandler": "^0.0.32",
 "@types/errorhandler": "^1.5.0",
 "@types/ws": "^7.4.7"
 },
 "files": [
Expand Down

2 changes: 2 additions & 0 deletions
packages/cli-server-api/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,11 +58,13 @@ export function createDevServerMiddleware(options: MiddlewareOptions) {
 .use('/open-url', openURLMiddleware)
 .use('/status', statusPageMiddleware)
 .use('/symbolicate', rawBodyMiddleware)
 // @ts-ignore mismatch
 .use('/systrace', systraceProfileMiddleware)
 .use('/reload', (_req: http.IncomingMessage, res: http.ServerResponse) => {
 broadcast('reload');
 res.end('OK');
 })
 // @ts-ignore mismatch
 .use(errorhandler());

 options.watchFolders.forEach((folder) => {
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-server-api/src/websocket/createDebuggerProxyEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ export default function createDebuggerProxyEndpoint(): {
 try {
 dest.send(message);
 } catch (e) {
 logger.warn(e);
 logger.warn(e as any);
 // Sometimes this call throws 'not opened'
 }
 }
Expand Down

4 changes: 2 additions & 2 deletions
packages/cli-server-api/src/websocket/createEventsSocketEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ export default function createEventsSocketEndpoint(
 ws.send(serialized);
 } catch (e) {
 logger.error(
 `Failed to send broadcast to client due to:\n ${e.toString()}`,
 `Failed to send broadcast to client due to:\n ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -178,7 +178,7 @@ export default function createEventsSocketEndpoint(
 */
 broadcast(message.command, message.params);
 } catch (e) {
 logger.error('Failed to forward message to clients: ', e);
 logger.error('Failed to forward message to clients: ', e as any);
 }
 } else {
 logger.error('Unknown message type: ', message.type);
Expand Down

6 changes: 3 additions & 3 deletions
packages/cli-server-api/src/websocket/createMessageSocketEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -109,7 +109,7 @@ export default function createMessageSocketEndpoint(): {
 } catch (e) {
 logger.error(
 `Failed to send broadcast to client: '${otherId}' ` +
 `due to:\n ${e.toString()}`,
 `due to:\n ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -147,7 +147,7 @@ export default function createMessageSocketEndpoint(): {
 logger.error(
 `Failed to reply to ${clientId} with error:\n${error}` +
 `\nmessage:\n${JSON.stringify(errorMessage)}` +
 `\ndue to error: ${e.toString()}`,
 `\ndue to error: ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -237,7 +237,7 @@ export default function createMessageSocketEndpoint(): {
 throw new Error('Invalid message, did not match the protocol');
 }
 } catch (e) {
 handleCaughtError(message, e.toString());
 handleCaughtError(message, (e as any).toString());
 }
 };
 });
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-tools/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@
 "@react-native-community/cli-types": "^10.0.0",
 "@types/lodash": "^4.14.149",
 "@types/mime": "^2.0.1",
 "@types/node": "^14.0.0",
 "@types/node": "^16.0.0",
 "@types/node-fetch": "^2.5.5",
 "@types/shell-quote": "^1.7.1"
 },
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
breaking: node 16; typescript 4#1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

thymikee
merged 2 commits into

from

Mar 9, 2023
 Merged


breaking: node 16; typescript 4
#1844
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
0e1ac87

breaking: node 16; typescript 4


thymikee Feb 20, 2023
a510b91

fixup deepmerge


thymikee Feb 20, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.github/workflows/test.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ jobs:
 runs-on: ubuntu-latest
 strategy:
 matrix:
 node-version: [14, 16, 18]
 node-version: [16, 18]
 steps:
 - uses: actions/checkout@v2
 - name: Use Node.js ${{ matrix.node-version }}
Expand Down

2 changes: 1 addition & 1 deletion
babel.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ module.exports = {
 [
 require.resolve('@babel/preset-env'),
 {
 targets: {node: '14'},
 targets: {node: '16'},
 useBuiltIns: 'entry',
 corejs: '2.x',
 },
Expand Down

6 changes: 3 additions & 3 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@
 "@react-native-community/eslint-config": "^2.0.0",
 "@types/glob": "^7.1.1",
 "@types/jest": "^26.0.15",
 "@types/node": "^14.0.0",
 "@types/node": "^16.0.0",
 "@types/node-fetch": "^2.3.7",
 "@types/rimraf": "^3.0.2",
 "@types/readable-stream": "^2.3.0",
Expand All@@ -55,10 +55,10 @@
 "rimraf": "^3.0.2",
 "slash": "^3.0.0",
 "string-length": "^2.0.0",
 "typescript": "^3.8.0"
 "typescript": "^4.9.5"
 },
 "resolutions": {
 "@types/node": "^14.0.0"
 "@types/node": "^16.0.0"
 },
 "lint-staged": {
 "./packages/**/*.{ts}": [
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-config/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "@react-native-community/cli-tools": "^10.1.1",
 "chalk": "^4.1.2",
 "cosmiconfig": "^5.1.0",
 "deepmerge": "^3.2.0",
 "deepmerge": "^4.3.0",
@thymikeethymikeeFeb 20, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this turned out to be unnecessary, but checking the release notes the only breaking change is umd -> cjs, which is fine for us
 "glob": "^7.1.3",
 "joi": "^17.2.1"
 },
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-config/src/merge.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ import deepmerge from 'deepmerge';
 * `deepmerge` concatenates arrays by default instead of overwriting them.
 * We define custom merging function for arrays to change that behaviour
 */
export default function merge<X, Y>(x: X, y: Y) {
export default function merge<X, Y>(x: Partial<X>, y: Partial<Y>) {
 return deepmerge(x, y, {
 arrayMerge: (_destinationArray: any[], sourceArray: any[]): any[] =>
 sourceArray,
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/brewInstall.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ async function brewInstall({
 logError({
 healthcheck: label || pkg,
 loader,
 error,
 error: error as any,
 command: `brew install ${pkg}`,
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/cocoaPods.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,7 +58,7 @@ export default {
 logError({
 healthcheck: label,
 loader,
 error,
 error: error as any,
 command: 'sudo gem install cocoapods',
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/iosDeploy.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,7 +44,7 @@ const installLibrary = async ({
 logError({
 healthcheck: label,
 loader,
 error,
 error: error as Error,
 command: installationCommand,
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/jdk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,7 @@ export default {
 'JDK installed successfully. Please restart your shell to see the changes',
 );
 } catch (e) {
 loader.fail(e);
 loader.fail(e as any);
 }
 },
 runAutomaticFix: async ({logManualInstallation, loader}) => {
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/xcodeEnv.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -65,7 +65,7 @@ export default {
 });
 loader.succeed('.xcode.env file have been created!');
 } catch (e) {
 loader.fail(e);
 loader.fail(e as any);
 }
 },
} as HealthCheckInterface;

6 changes: 3 additions & 3 deletions
packages/cli-doctor/src/tools/installPods.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,7 @@ async function runPodInstall(
 await execa('bundle', ['exec', 'pod', 'install']);
 } catch (error) {
 // "pod" command outputs errors to stdout (at least some of them)
 const stderr = error.stderr || error.stdout;
 const stderr = (error as any).stderr || (error as any).stdout;

 /**
 * If CocoaPods failed due to repo being out of date, it will
Expand DownExpand Up@@ -61,7 +61,7 @@ async function runPodUpdate(loader: Loader) {
 await execa('pod', ['repo', 'update']);
 } catch (error) {
 // "pod" command outputs errors to stdout (at least some of them)
 logger.log(error.stderr || error.stdout);
 logger.log((error as any).stderr || (error as any).stdout);
 loader.fail();

 throw new Error(
Expand DownExpand Up@@ -142,7 +142,7 @@ async function installCocoaPods(loader: Loader) {
 return loader.succeed();
 } catch (error) {
 loader.fail();
 logger.error(error.stderr);
 logger.error((error as any).stderr);

 throw new Error(
 `An error occured while trying to install CocoaPods, which is required by this template.\nPlease try again manually: sudo gem install cocoapods.\nCocoaPods documentation: ${chalk.dim.underline(
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/runBundleInstall.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ async function runBundleInstall(loader: Loader) {
 await execa('bundle', ['install']);
 } catch (error) {
 loader.fail();
 logger.error(error.stderr || error.stdout);
 logger.error((error as any).stderr || (error as any).stdout);

 throw new Error(
 'Looks like your iOS environment is not properly set. Please go to https://reactnative.dev/docs/next/environment-setup and follow the React Native CLI QuickStart guide for macOS and iOS.',
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/unzip.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ const unzip = async (source: string, destination: string) => {
 return reject(err);
 }

 resolve();
 resolve(undefined);
 });
 });
 });
Expand Down

6 changes: 3 additions & 3 deletions
packages/cli-doctor/src/tools/windows/androidWinHelpers.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ export const installComponent = (component: string, androidSdkRoot: string) => {

 child.on('close', (exitStatus) => {
 if (exitStatus === 0) {
 done();
 done(undefined);
 } else {
 error({stderr});
 }
Expand DownExpand Up@@ -161,7 +161,7 @@ const getEmulatorAccelOutputInformation = async (androidSDKRoot: string) => {

 return stdout;
 } catch (e) {
 const {stdout} = e;
 const {stdout} = e as any;

 return stdout;
 }
Expand DownExpand Up@@ -205,7 +205,7 @@ export const createAVD = async (

 return stdout;
 } catch (e) {
 const {stderr} = e;
 const {stderr} = e as any;

 return stderr;
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-hermes/src/profileHermes/downloadProfile.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,7 @@ function getLatestFile(packageNameWithSuffix: string): string {
 `);
 return file.toString().trim();
 } catch (e) {
 throw new Error(e);
 throw e;
 }
}

Expand Down

4 changes: 2 additions & 2 deletions
packages/cli-hermes/src/profileHermes/sourcemapUtils.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,14 +17,14 @@ function writeJsonSync(targetPath: string, data: any) {
 } catch (e) {
 throw new CLIError(
 `Failed to serialize data to json before writing to ${targetPath}`,
 e,
 e as Error,
 );
 }

 try {
 fs.writeFileSync(targetPath, json, 'utf-8');
 } catch (e) {
 throw new CLIError(`Failed to write json to ${targetPath}`, e);
 throw new CLIError(`Failed to write json to ${targetPath}`, e as Error);
 }
}

Expand Down

10 changes: 6 additions & 4 deletions
packages/cli-platform-android/src/commands/buildAndroid/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,9 +41,11 @@ export async function runPackager(args: BuildFlags, config: Config) {
 try {
 startServerInNewWindow(args.port, args.terminal, config.reactNativePath);
 } catch (error) {
 logger.warn(
 `Failed to automatically start the packager server. Please run "react-native start" manually. Error details: ${error.message}`,
 );
 if (error instanceof Error) {
 logger.warn(
 `Failed to automatically start the packager server. Please run "react-native start" manually. Error details: ${error.message}`,
 );
 }
 }
 }
}
Expand DownExpand Up@@ -126,7 +128,7 @@ export function build(gradleArgs: string[], sourceDir: string) {
 });
 } catch (error) {
 printRunDoctorTip();
 throw new CLIError('Failed to build the app.', error);
 throw new CLIError('Failed to build the app.', error as Error);
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/runOnAllDevices.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -104,7 +104,7 @@ async function runOnAllDevices(
 }
 } catch (error) {
 printRunDoctorTip();
 throw createInstallError(error);
 throw createInstallError(error as any);
 }

 (devices.length > 0 ? devices : [undefined]).forEach(
Expand Down

5 changes: 4 additions & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryInstallAppOnDevice.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,10 @@ function tryInstallAppOnDevice(
 );
 execa.sync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (error) {
 throw new CLIError('Failed to install the app on the device.', error);
 throw new CLIError(
 'Failed to install the app on the device.',
 error as any,
 );
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryLaunchAppOnDevice.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ function tryLaunchAppOnDevice(
 logger.debug(`Running command "${adbPath} ${adbArgs.join(' ')}"`);
 execa.sync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (error) {
 throw new CLIError('Failed to start the app.', error);
 throw new CLIError('Failed to start the app.', error as any);
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryLaunchEmulator.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@ export default async function tryLaunchEmulator(
 await launchEmulator(emulatorName ?? emulators[0], adbPath, port);
 return {success: true};
 } catch (error) {
 return {success: false, error: error?.message};
 return {success: false, error: (error as any)?.message};
 }
 }
 return {
Expand Down

4 changes: 3 additions & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryRunAdbReverse.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,9 @@ function tryRunAdbReverse(
 execFileSync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (e) {
 logger.warn(
 `Failed to connect to development server using "adb reverse": ${e.message}`,
 `Failed to connect to development server using "adb reverse": ${
 (e as any).message
 }`,
 );
 }
}
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/commands/runIOS/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -209,7 +209,7 @@ const getSimulators = () => {
 } catch (error) {
 throw new CLIError(
 'Could not get the simulator list from Xcode. Please open Xcode and try running project directly from there to resolve the remaining issues.',
 error,
 error as Error,
 );
 }
 return simulators;
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/tools/getDestinationSimulator.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ export function getDestinationSimulator(
 } catch (error) {
 throw new CLIError(
 'Could not get the simulator list from Xcode. Please open Xcode and try running project directly from there to resolve the remaining issues.',
 error,
 error as Error,
 );
 }

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/tools/getProjectInfo.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,6 @@ export function getProjectInfo(): IosProjectInfo {

 return project;
 } catch (error) {
 throw new CLIError(error);
 throw new CLIError(error as any);
 }
}

6 changes: 3 additions & 3 deletions
packages/cli-server-api/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,16 +11,16 @@
 "@react-native-community/cli-tools": "^10.1.1",
 "compression": "^1.7.1",
 "connect": "^3.6.5",
 "errorhandler": "^1.5.0",
 "errorhandler": "^1.5.1",
 "nocache": "^3.0.1",
 "pretty-format": "^26.6.2",
 "serve-static": "^1.13.1",
 "ws": "^7.5.1"
 },
 "devDependencies": {
 "@types/compression": "^1.0.1",
 "@types/compression": "^1.7.2",
 "@types/connect": "^3.4.33",
 "@types/errorhandler": "^0.0.32",
 "@types/errorhandler": "^1.5.0",
 "@types/ws": "^7.4.7"
 },
 "files": [
Expand Down

2 changes: 2 additions & 0 deletions
packages/cli-server-api/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,11 +58,13 @@ export function createDevServerMiddleware(options: MiddlewareOptions) {
 .use('/open-url', openURLMiddleware)
 .use('/status', statusPageMiddleware)
 .use('/symbolicate', rawBodyMiddleware)
 // @ts-ignore mismatch
 .use('/systrace', systraceProfileMiddleware)
 .use('/reload', (_req: http.IncomingMessage, res: http.ServerResponse) => {
 broadcast('reload');
 res.end('OK');
 })
 // @ts-ignore mismatch
 .use(errorhandler());

 options.watchFolders.forEach((folder) => {
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-server-api/src/websocket/createDebuggerProxyEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ export default function createDebuggerProxyEndpoint(): {
 try {
 dest.send(message);
 } catch (e) {
 logger.warn(e);
 logger.warn(e as any);
 // Sometimes this call throws 'not opened'
 }
 }
Expand Down

4 changes: 2 additions & 2 deletions
packages/cli-server-api/src/websocket/createEventsSocketEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ export default function createEventsSocketEndpoint(
 ws.send(serialized);
 } catch (e) {
 logger.error(
 `Failed to send broadcast to client due to:\n ${e.toString()}`,
 `Failed to send broadcast to client due to:\n ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -178,7 +178,7 @@ export default function createEventsSocketEndpoint(
 */
 broadcast(message.command, message.params);
 } catch (e) {
 logger.error('Failed to forward message to clients: ', e);
 logger.error('Failed to forward message to clients: ', e as any);
 }
 } else {
 logger.error('Unknown message type: ', message.type);
Expand Down

6 changes: 3 additions & 3 deletions
packages/cli-server-api/src/websocket/createMessageSocketEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -109,7 +109,7 @@ export default function createMessageSocketEndpoint(): {
 } catch (e) {
 logger.error(
 `Failed to send broadcast to client: '${otherId}' ` +
 `due to:\n ${e.toString()}`,
 `due to:\n ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -147,7 +147,7 @@ export default function createMessageSocketEndpoint(): {
 logger.error(
 `Failed to reply to ${clientId} with error:\n${error}` +
 `\nmessage:\n${JSON.stringify(errorMessage)}` +
 `\ndue to error: ${e.toString()}`,
 `\ndue to error: ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -237,7 +237,7 @@ export default function createMessageSocketEndpoint(): {
 throw new Error('Invalid message, did not match the protocol');
 }
 } catch (e) {
 handleCaughtError(message, e.toString());
 handleCaughtError(message, (e as any).toString());
 }
 };
 });
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-tools/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@
 "@react-native-community/cli-types": "^10.0.0",
 "@types/lodash": "^4.14.149",
 "@types/mime": "^2.0.1",
 "@types/node": "^14.0.0",
 "@types/node": "^16.0.0",
 "@types/node-fetch": "^2.5.5",
 "@types/shell-quote": "^1.7.1"
 },
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
breaking: node 16; typescript 4#1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

thymikee
merged 2 commits into

from

Mar 9, 2023
 Merged


breaking: node 16; typescript 4
#1844
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
0e1ac87

breaking: node 16; typescript 4


thymikee Feb 20, 2023
a510b91

fixup deepmerge


thymikee Feb 20, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.github/workflows/test.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ jobs:
 runs-on: ubuntu-latest
 strategy:
 matrix:
 node-version: [14, 16, 18]
 node-version: [16, 18]
 steps:
 - uses: actions/checkout@v2
 - name: Use Node.js ${{ matrix.node-version }}
Expand Down

2 changes: 1 addition & 1 deletion
babel.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ module.exports = {
 [
 require.resolve('@babel/preset-env'),
 {
 targets: {node: '14'},
 targets: {node: '16'},
 useBuiltIns: 'entry',
 corejs: '2.x',
 },
Expand Down

6 changes: 3 additions & 3 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@
 "@react-native-community/eslint-config": "^2.0.0",
 "@types/glob": "^7.1.1",
 "@types/jest": "^26.0.15",
 "@types/node": "^14.0.0",
 "@types/node": "^16.0.0",
 "@types/node-fetch": "^2.3.7",
 "@types/rimraf": "^3.0.2",
 "@types/readable-stream": "^2.3.0",
Expand All@@ -55,10 +55,10 @@
 "rimraf": "^3.0.2",
 "slash": "^3.0.0",
 "string-length": "^2.0.0",
 "typescript": "^3.8.0"
 "typescript": "^4.9.5"
 },
 "resolutions": {
 "@types/node": "^14.0.0"
 "@types/node": "^16.0.0"
 },
 "lint-staged": {
 "./packages/**/*.{ts}": [
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-config/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "@react-native-community/cli-tools": "^10.1.1",
 "chalk": "^4.1.2",
 "cosmiconfig": "^5.1.0",
 "deepmerge": "^3.2.0",
 "deepmerge": "^4.3.0",
@thymikeethymikeeFeb 20, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this turned out to be unnecessary, but checking the release notes the only breaking change is umd -> cjs, which is fine for us
 "glob": "^7.1.3",
 "joi": "^17.2.1"
 },
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-config/src/merge.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ import deepmerge from 'deepmerge';
 * `deepmerge` concatenates arrays by default instead of overwriting them.
 * We define custom merging function for arrays to change that behaviour
 */
export default function merge<X, Y>(x: X, y: Y) {
export default function merge<X, Y>(x: Partial<X>, y: Partial<Y>) {
 return deepmerge(x, y, {
 arrayMerge: (_destinationArray: any[], sourceArray: any[]): any[] =>
 sourceArray,
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/brewInstall.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ async function brewInstall({
 logError({
 healthcheck: label || pkg,
 loader,
 error,
 error: error as any,
 command: `brew install ${pkg}`,
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/cocoaPods.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,7 +58,7 @@ export default {
 logError({
 healthcheck: label,
 loader,
 error,
 error: error as any,
 command: 'sudo gem install cocoapods',
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/iosDeploy.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,7 +44,7 @@ const installLibrary = async ({
 logError({
 healthcheck: label,
 loader,
 error,
 error: error as Error,
 command: installationCommand,
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/jdk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,7 @@ export default {
 'JDK installed successfully. Please restart your shell to see the changes',
 );
 } catch (e) {
 loader.fail(e);
 loader.fail(e as any);
 }
 },
 runAutomaticFix: async ({logManualInstallation, loader}) => {
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/xcodeEnv.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -65,7 +65,7 @@ export default {
 });
 loader.succeed('.xcode.env file have been created!');
 } catch (e) {
 loader.fail(e);
 loader.fail(e as any);
 }
 },
} as HealthCheckInterface;

6 changes: 3 additions & 3 deletions
packages/cli-doctor/src/tools/installPods.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,7 @@ async function runPodInstall(
 await execa('bundle', ['exec', 'pod', 'install']);
 } catch (error) {
 // "pod" command outputs errors to stdout (at least some of them)
 const stderr = error.stderr || error.stdout;
 const stderr = (error as any).stderr || (error as any).stdout;

 /**
 * If CocoaPods failed due to repo being out of date, it will
Expand DownExpand Up@@ -61,7 +61,7 @@ async function runPodUpdate(loader: Loader) {
 await execa('pod', ['repo', 'update']);
 } catch (error) {
 // "pod" command outputs errors to stdout (at least some of them)
 logger.log(error.stderr || error.stdout);
 logger.log((error as any).stderr || (error as any).stdout);
 loader.fail();

 throw new Error(
Expand DownExpand Up@@ -142,7 +142,7 @@ async function installCocoaPods(loader: Loader) {
 return loader.succeed();
 } catch (error) {
 loader.fail();
 logger.error(error.stderr);
 logger.error((error as any).stderr);

 throw new Error(
 `An error occured while trying to install CocoaPods, which is required by this template.\nPlease try again manually: sudo gem install cocoapods.\nCocoaPods documentation: ${chalk.dim.underline(
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/runBundleInstall.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ async function runBundleInstall(loader: Loader) {
 await execa('bundle', ['install']);
 } catch (error) {
 loader.fail();
 logger.error(error.stderr || error.stdout);
 logger.error((error as any).stderr || (error as any).stdout);

 throw new Error(
 'Looks like your iOS environment is not properly set. Please go to https://reactnative.dev/docs/next/environment-setup and follow the React Native CLI QuickStart guide for macOS and iOS.',
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/unzip.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ const unzip = async (source: string, destination: string) => {
 return reject(err);
 }

 resolve();
 resolve(undefined);
 });
 });
 });
Expand Down

6 changes: 3 additions & 3 deletions
packages/cli-doctor/src/tools/windows/androidWinHelpers.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ export const installComponent = (component: string, androidSdkRoot: string) => {

 child.on('close', (exitStatus) => {
 if (exitStatus === 0) {
 done();
 done(undefined);
 } else {
 error({stderr});
 }
Expand DownExpand Up@@ -161,7 +161,7 @@ const getEmulatorAccelOutputInformation = async (androidSDKRoot: string) => {

 return stdout;
 } catch (e) {
 const {stdout} = e;
 const {stdout} = e as any;

 return stdout;
 }
Expand DownExpand Up@@ -205,7 +205,7 @@ export const createAVD = async (

 return stdout;
 } catch (e) {
 const {stderr} = e;
 const {stderr} = e as any;

 return stderr;
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-hermes/src/profileHermes/downloadProfile.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,7 @@ function getLatestFile(packageNameWithSuffix: string): string {
 `);
 return file.toString().trim();
 } catch (e) {
 throw new Error(e);
 throw e;
 }
}

Expand Down

4 changes: 2 additions & 2 deletions
packages/cli-hermes/src/profileHermes/sourcemapUtils.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,14 +17,14 @@ function writeJsonSync(targetPath: string, data: any) {
 } catch (e) {
 throw new CLIError(
 `Failed to serialize data to json before writing to ${targetPath}`,
 e,
 e as Error,
 );
 }

 try {
 fs.writeFileSync(targetPath, json, 'utf-8');
 } catch (e) {
 throw new CLIError(`Failed to write json to ${targetPath}`, e);
 throw new CLIError(`Failed to write json to ${targetPath}`, e as Error);
 }
}

Expand Down

10 changes: 6 additions & 4 deletions
packages/cli-platform-android/src/commands/buildAndroid/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,9 +41,11 @@ export async function runPackager(args: BuildFlags, config: Config) {
 try {
 startServerInNewWindow(args.port, args.terminal, config.reactNativePath);
 } catch (error) {
 logger.warn(
 `Failed to automatically start the packager server. Please run "react-native start" manually. Error details: ${error.message}`,
 );
 if (error instanceof Error) {
 logger.warn(
 `Failed to automatically start the packager server. Please run "react-native start" manually. Error details: ${error.message}`,
 );
 }
 }
 }
}
Expand DownExpand Up@@ -126,7 +128,7 @@ export function build(gradleArgs: string[], sourceDir: string) {
 });
 } catch (error) {
 printRunDoctorTip();
 throw new CLIError('Failed to build the app.', error);
 throw new CLIError('Failed to build the app.', error as Error);
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/runOnAllDevices.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -104,7 +104,7 @@ async function runOnAllDevices(
 }
 } catch (error) {
 printRunDoctorTip();
 throw createInstallError(error);
 throw createInstallError(error as any);
 }

 (devices.length > 0 ? devices : [undefined]).forEach(
Expand Down

5 changes: 4 additions & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryInstallAppOnDevice.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,10 @@ function tryInstallAppOnDevice(
 );
 execa.sync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (error) {
 throw new CLIError('Failed to install the app on the device.', error);
 throw new CLIError(
 'Failed to install the app on the device.',
 error as any,
 );
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryLaunchAppOnDevice.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ function tryLaunchAppOnDevice(
 logger.debug(`Running command "${adbPath} ${adbArgs.join(' ')}"`);
 execa.sync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (error) {
 throw new CLIError('Failed to start the app.', error);
 throw new CLIError('Failed to start the app.', error as any);
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryLaunchEmulator.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@ export default async function tryLaunchEmulator(
 await launchEmulator(emulatorName ?? emulators[0], adbPath, port);
 return {success: true};
 } catch (error) {
 return {success: false, error: error?.message};
 return {success: false, error: (error as any)?.message};
 }
 }
 return {
Expand Down

4 changes: 3 additions & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryRunAdbReverse.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,9 @@ function tryRunAdbReverse(
 execFileSync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (e) {
 logger.warn(
 `Failed to connect to development server using "adb reverse": ${e.message}`,
 `Failed to connect to development server using "adb reverse": ${
 (e as any).message
 }`,
 );
 }
}
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/commands/runIOS/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -209,7 +209,7 @@ const getSimulators = () => {
 } catch (error) {
 throw new CLIError(
 'Could not get the simulator list from Xcode. Please open Xcode and try running project directly from there to resolve the remaining issues.',
 error,
 error as Error,
 );
 }
 return simulators;
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/tools/getDestinationSimulator.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ export function getDestinationSimulator(
 } catch (error) {
 throw new CLIError(
 'Could not get the simulator list from Xcode. Please open Xcode and try running project directly from there to resolve the remaining issues.',
 error,
 error as Error,
 );
 }

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/tools/getProjectInfo.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,6 @@ export function getProjectInfo(): IosProjectInfo {

 return project;
 } catch (error) {
 throw new CLIError(error);
 throw new CLIError(error as any);
 }
}

6 changes: 3 additions & 3 deletions
packages/cli-server-api/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,16 +11,16 @@
 "@react-native-community/cli-tools": "^10.1.1",
 "compression": "^1.7.1",
 "connect": "^3.6.5",
 "errorhandler": "^1.5.0",
 "errorhandler": "^1.5.1",
 "nocache": "^3.0.1",
 "pretty-format": "^26.6.2",
 "serve-static": "^1.13.1",
 "ws": "^7.5.1"
 },
 "devDependencies": {
 "@types/compression": "^1.0.1",
 "@types/compression": "^1.7.2",
 "@types/connect": "^3.4.33",
 "@types/errorhandler": "^0.0.32",
 "@types/errorhandler": "^1.5.0",
 "@types/ws": "^7.4.7"
 },
 "files": [
Expand Down

2 changes: 2 additions & 0 deletions
packages/cli-server-api/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,11 +58,13 @@ export function createDevServerMiddleware(options: MiddlewareOptions) {
 .use('/open-url', openURLMiddleware)
 .use('/status', statusPageMiddleware)
 .use('/symbolicate', rawBodyMiddleware)
 // @ts-ignore mismatch
 .use('/systrace', systraceProfileMiddleware)
 .use('/reload', (_req: http.IncomingMessage, res: http.ServerResponse) => {
 broadcast('reload');
 res.end('OK');
 })
 // @ts-ignore mismatch
 .use(errorhandler());

 options.watchFolders.forEach((folder) => {
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-server-api/src/websocket/createDebuggerProxyEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ export default function createDebuggerProxyEndpoint(): {
 try {
 dest.send(message);
 } catch (e) {
 logger.warn(e);
 logger.warn(e as any);
 // Sometimes this call throws 'not opened'
 }
 }
Expand Down

4 changes: 2 additions & 2 deletions
packages/cli-server-api/src/websocket/createEventsSocketEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ export default function createEventsSocketEndpoint(
 ws.send(serialized);
 } catch (e) {
 logger.error(
 `Failed to send broadcast to client due to:\n ${e.toString()}`,
 `Failed to send broadcast to client due to:\n ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -178,7 +178,7 @@ export default function createEventsSocketEndpoint(
 */
 broadcast(message.command, message.params);
 } catch (e) {
 logger.error('Failed to forward message to clients: ', e);
 logger.error('Failed to forward message to clients: ', e as any);
 }
 } else {
 logger.error('Unknown message type: ', message.type);
Expand Down

6 changes: 3 additions & 3 deletions
packages/cli-server-api/src/websocket/createMessageSocketEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -109,7 +109,7 @@ export default function createMessageSocketEndpoint(): {
 } catch (e) {
 logger.error(
 `Failed to send broadcast to client: '${otherId}' ` +
 `due to:\n ${e.toString()}`,
 `due to:\n ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -147,7 +147,7 @@ export default function createMessageSocketEndpoint(): {
 logger.error(
 `Failed to reply to ${clientId} with error:\n${error}` +
 `\nmessage:\n${JSON.stringify(errorMessage)}` +
 `\ndue to error: ${e.toString()}`,
 `\ndue to error: ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -237,7 +237,7 @@ export default function createMessageSocketEndpoint(): {
 throw new Error('Invalid message, did not match the protocol');
 }
 } catch (e) {
 handleCaughtError(message, e.toString());
 handleCaughtError(message, (e as any).toString());
 }
 };
 });
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-tools/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@
 "@react-native-community/cli-types": "^10.0.0",
 "@types/lodash": "^4.14.149",
 "@types/mime": "^2.0.1",
 "@types/node": "^14.0.0",
 "@types/node": "^16.0.0",
 "@types/node-fetch": "^2.5.5",
 "@types/shell-quote": "^1.7.1"
 },
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
breaking: node 16; typescript 4#1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

thymikee
merged 2 commits into

from

Mar 9, 2023
 Merged


breaking: node 16; typescript 4
#1844
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
0e1ac87

breaking: node 16; typescript 4


thymikee Feb 20, 2023
a510b91

fixup deepmerge


thymikee Feb 20, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.github/workflows/test.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ jobs:
 runs-on: ubuntu-latest
 strategy:
 matrix:
 node-version: [14, 16, 18]
 node-version: [16, 18]
 steps:
 - uses: actions/checkout@v2
 - name: Use Node.js ${{ matrix.node-version }}
Expand Down

2 changes: 1 addition & 1 deletion
babel.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ module.exports = {
 [
 require.resolve('@babel/preset-env'),
 {
 targets: {node: '14'},
 targets: {node: '16'},
 useBuiltIns: 'entry',
 corejs: '2.x',
 },
Expand Down

6 changes: 3 additions & 3 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@
 "@react-native-community/eslint-config": "^2.0.0",
 "@types/glob": "^7.1.1",
 "@types/jest": "^26.0.15",
 "@types/node": "^14.0.0",
 "@types/node": "^16.0.0",
 "@types/node-fetch": "^2.3.7",
 "@types/rimraf": "^3.0.2",
 "@types/readable-stream": "^2.3.0",
Expand All@@ -55,10 +55,10 @@
 "rimraf": "^3.0.2",
 "slash": "^3.0.0",
 "string-length": "^2.0.0",
 "typescript": "^3.8.0"
 "typescript": "^4.9.5"
 },
 "resolutions": {
 "@types/node": "^14.0.0"
 "@types/node": "^16.0.0"
 },
 "lint-staged": {
 "./packages/**/*.{ts}": [
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-config/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "@react-native-community/cli-tools": "^10.1.1",
 "chalk": "^4.1.2",
 "cosmiconfig": "^5.1.0",
 "deepmerge": "^3.2.0",
 "deepmerge": "^4.3.0",
@thymikeethymikeeFeb 20, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this turned out to be unnecessary, but checking the release notes the only breaking change is umd -> cjs, which is fine for us
 "glob": "^7.1.3",
 "joi": "^17.2.1"
 },
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-config/src/merge.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ import deepmerge from 'deepmerge';
 * `deepmerge` concatenates arrays by default instead of overwriting them.
 * We define custom merging function for arrays to change that behaviour
 */
export default function merge<X, Y>(x: X, y: Y) {
export default function merge<X, Y>(x: Partial<X>, y: Partial<Y>) {
 return deepmerge(x, y, {
 arrayMerge: (_destinationArray: any[], sourceArray: any[]): any[] =>
 sourceArray,
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/brewInstall.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ async function brewInstall({
 logError({
 healthcheck: label || pkg,
 loader,
 error,
 error: error as any,
 command: `brew install ${pkg}`,
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/cocoaPods.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,7 +58,7 @@ export default {
 logError({
 healthcheck: label,
 loader,
 error,
 error: error as any,
 command: 'sudo gem install cocoapods',
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/iosDeploy.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,7 +44,7 @@ const installLibrary = async ({
 logError({
 healthcheck: label,
 loader,
 error,
 error: error as Error,
 command: installationCommand,
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/jdk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,7 @@ export default {
 'JDK installed successfully. Please restart your shell to see the changes',
 );
 } catch (e) {
 loader.fail(e);
 loader.fail(e as any);
 }
 },
 runAutomaticFix: async ({logManualInstallation, loader}) => {
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/xcodeEnv.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -65,7 +65,7 @@ export default {
 });
 loader.succeed('.xcode.env file have been created!');
 } catch (e) {
 loader.fail(e);
 loader.fail(e as any);
 }
 },
} as HealthCheckInterface;

6 changes: 3 additions & 3 deletions
packages/cli-doctor/src/tools/installPods.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,7 @@ async function runPodInstall(
 await execa('bundle', ['exec', 'pod', 'install']);
 } catch (error) {
 // "pod" command outputs errors to stdout (at least some of them)
 const stderr = error.stderr || error.stdout;
 const stderr = (error as any).stderr || (error as any).stdout;

 /**
 * If CocoaPods failed due to repo being out of date, it will
Expand DownExpand Up@@ -61,7 +61,7 @@ async function runPodUpdate(loader: Loader) {
 await execa('pod', ['repo', 'update']);
 } catch (error) {
 // "pod" command outputs errors to stdout (at least some of them)
 logger.log(error.stderr || error.stdout);
 logger.log((error as any).stderr || (error as any).stdout);
 loader.fail();

 throw new Error(
Expand DownExpand Up@@ -142,7 +142,7 @@ async function installCocoaPods(loader: Loader) {
 return loader.succeed();
 } catch (error) {
 loader.fail();
 logger.error(error.stderr);
 logger.error((error as any).stderr);

 throw new Error(
 `An error occured while trying to install CocoaPods, which is required by this template.\nPlease try again manually: sudo gem install cocoapods.\nCocoaPods documentation: ${chalk.dim.underline(
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/runBundleInstall.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ async function runBundleInstall(loader: Loader) {
 await execa('bundle', ['install']);
 } catch (error) {
 loader.fail();
 logger.error(error.stderr || error.stdout);
 logger.error((error as any).stderr || (error as any).stdout);

 throw new Error(
 'Looks like your iOS environment is not properly set. Please go to https://reactnative.dev/docs/next/environment-setup and follow the React Native CLI QuickStart guide for macOS and iOS.',
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/unzip.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ const unzip = async (source: string, destination: string) => {
 return reject(err);
 }

 resolve();
 resolve(undefined);
 });
 });
 });
Expand Down

6 changes: 3 additions & 3 deletions
packages/cli-doctor/src/tools/windows/androidWinHelpers.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ export const installComponent = (component: string, androidSdkRoot: string) => {

 child.on('close', (exitStatus) => {
 if (exitStatus === 0) {
 done();
 done(undefined);
 } else {
 error({stderr});
 }
Expand DownExpand Up@@ -161,7 +161,7 @@ const getEmulatorAccelOutputInformation = async (androidSDKRoot: string) => {

 return stdout;
 } catch (e) {
 const {stdout} = e;
 const {stdout} = e as any;

 return stdout;
 }
Expand DownExpand Up@@ -205,7 +205,7 @@ export const createAVD = async (

 return stdout;
 } catch (e) {
 const {stderr} = e;
 const {stderr} = e as any;

 return stderr;
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-hermes/src/profileHermes/downloadProfile.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,7 @@ function getLatestFile(packageNameWithSuffix: string): string {
 `);
 return file.toString().trim();
 } catch (e) {
 throw new Error(e);
 throw e;
 }
}

Expand Down

4 changes: 2 additions & 2 deletions
packages/cli-hermes/src/profileHermes/sourcemapUtils.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,14 +17,14 @@ function writeJsonSync(targetPath: string, data: any) {
 } catch (e) {
 throw new CLIError(
 `Failed to serialize data to json before writing to ${targetPath}`,
 e,
 e as Error,
 );
 }

 try {
 fs.writeFileSync(targetPath, json, 'utf-8');
 } catch (e) {
 throw new CLIError(`Failed to write json to ${targetPath}`, e);
 throw new CLIError(`Failed to write json to ${targetPath}`, e as Error);
 }
}

Expand Down

10 changes: 6 additions & 4 deletions
packages/cli-platform-android/src/commands/buildAndroid/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,9 +41,11 @@ export async function runPackager(args: BuildFlags, config: Config) {
 try {
 startServerInNewWindow(args.port, args.terminal, config.reactNativePath);
 } catch (error) {
 logger.warn(
 `Failed to automatically start the packager server. Please run "react-native start" manually. Error details: ${error.message}`,
 );
 if (error instanceof Error) {
 logger.warn(
 `Failed to automatically start the packager server. Please run "react-native start" manually. Error details: ${error.message}`,
 );
 }
 }
 }
}
Expand DownExpand Up@@ -126,7 +128,7 @@ export function build(gradleArgs: string[], sourceDir: string) {
 });
 } catch (error) {
 printRunDoctorTip();
 throw new CLIError('Failed to build the app.', error);
 throw new CLIError('Failed to build the app.', error as Error);
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/runOnAllDevices.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -104,7 +104,7 @@ async function runOnAllDevices(
 }
 } catch (error) {
 printRunDoctorTip();
 throw createInstallError(error);
 throw createInstallError(error as any);
 }

 (devices.length > 0 ? devices : [undefined]).forEach(
Expand Down

5 changes: 4 additions & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryInstallAppOnDevice.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,10 @@ function tryInstallAppOnDevice(
 );
 execa.sync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (error) {
 throw new CLIError('Failed to install the app on the device.', error);
 throw new CLIError(
 'Failed to install the app on the device.',
 error as any,
 );
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryLaunchAppOnDevice.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ function tryLaunchAppOnDevice(
 logger.debug(`Running command "${adbPath} ${adbArgs.join(' ')}"`);
 execa.sync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (error) {
 throw new CLIError('Failed to start the app.', error);
 throw new CLIError('Failed to start the app.', error as any);
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryLaunchEmulator.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@ export default async function tryLaunchEmulator(
 await launchEmulator(emulatorName ?? emulators[0], adbPath, port);
 return {success: true};
 } catch (error) {
 return {success: false, error: error?.message};
 return {success: false, error: (error as any)?.message};
 }
 }
 return {
Expand Down

4 changes: 3 additions & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryRunAdbReverse.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,9 @@ function tryRunAdbReverse(
 execFileSync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (e) {
 logger.warn(
 `Failed to connect to development server using "adb reverse": ${e.message}`,
 `Failed to connect to development server using "adb reverse": ${
 (e as any).message
 }`,
 );
 }
}
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/commands/runIOS/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -209,7 +209,7 @@ const getSimulators = () => {
 } catch (error) {
 throw new CLIError(
 'Could not get the simulator list from Xcode. Please open Xcode and try running project directly from there to resolve the remaining issues.',
 error,
 error as Error,
 );
 }
 return simulators;
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/tools/getDestinationSimulator.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ export function getDestinationSimulator(
 } catch (error) {
 throw new CLIError(
 'Could not get the simulator list from Xcode. Please open Xcode and try running project directly from there to resolve the remaining issues.',
 error,
 error as Error,
 );
 }

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/tools/getProjectInfo.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,6 @@ export function getProjectInfo(): IosProjectInfo {

 return project;
 } catch (error) {
 throw new CLIError(error);
 throw new CLIError(error as any);
 }
}

6 changes: 3 additions & 3 deletions
packages/cli-server-api/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,16 +11,16 @@
 "@react-native-community/cli-tools": "^10.1.1",
 "compression": "^1.7.1",
 "connect": "^3.6.5",
 "errorhandler": "^1.5.0",
 "errorhandler": "^1.5.1",
 "nocache": "^3.0.1",
 "pretty-format": "^26.6.2",
 "serve-static": "^1.13.1",
 "ws": "^7.5.1"
 },
 "devDependencies": {
 "@types/compression": "^1.0.1",
 "@types/compression": "^1.7.2",
 "@types/connect": "^3.4.33",
 "@types/errorhandler": "^0.0.32",
 "@types/errorhandler": "^1.5.0",
 "@types/ws": "^7.4.7"
 },
 "files": [
Expand Down

2 changes: 2 additions & 0 deletions
packages/cli-server-api/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,11 +58,13 @@ export function createDevServerMiddleware(options: MiddlewareOptions) {
 .use('/open-url', openURLMiddleware)
 .use('/status', statusPageMiddleware)
 .use('/symbolicate', rawBodyMiddleware)
 // @ts-ignore mismatch
 .use('/systrace', systraceProfileMiddleware)
 .use('/reload', (_req: http.IncomingMessage, res: http.ServerResponse) => {
 broadcast('reload');
 res.end('OK');
 })
 // @ts-ignore mismatch
 .use(errorhandler());

 options.watchFolders.forEach((folder) => {
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-server-api/src/websocket/createDebuggerProxyEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ export default function createDebuggerProxyEndpoint(): {
 try {
 dest.send(message);
 } catch (e) {
 logger.warn(e);
 logger.warn(e as any);
 // Sometimes this call throws 'not opened'
 }
 }
Expand Down

4 changes: 2 additions & 2 deletions
packages/cli-server-api/src/websocket/createEventsSocketEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ export default function createEventsSocketEndpoint(
 ws.send(serialized);
 } catch (e) {
 logger.error(
 `Failed to send broadcast to client due to:\n ${e.toString()}`,
 `Failed to send broadcast to client due to:\n ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -178,7 +178,7 @@ export default function createEventsSocketEndpoint(
 */
 broadcast(message.command, message.params);
 } catch (e) {
 logger.error('Failed to forward message to clients: ', e);
 logger.error('Failed to forward message to clients: ', e as any);
 }
 } else {
 logger.error('Unknown message type: ', message.type);
Expand Down

6 changes: 3 additions & 3 deletions
packages/cli-server-api/src/websocket/createMessageSocketEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -109,7 +109,7 @@ export default function createMessageSocketEndpoint(): {
 } catch (e) {
 logger.error(
 `Failed to send broadcast to client: '${otherId}' ` +
 `due to:\n ${e.toString()}`,
 `due to:\n ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -147,7 +147,7 @@ export default function createMessageSocketEndpoint(): {
 logger.error(
 `Failed to reply to ${clientId} with error:\n${error}` +
 `\nmessage:\n${JSON.stringify(errorMessage)}` +
 `\ndue to error: ${e.toString()}`,
 `\ndue to error: ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -237,7 +237,7 @@ export default function createMessageSocketEndpoint(): {
 throw new Error('Invalid message, did not match the protocol');
 }
 } catch (e) {
 handleCaughtError(message, e.toString());
 handleCaughtError(message, (e as any).toString());
 }
 };
 });
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-tools/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@
 "@react-native-community/cli-types": "^10.0.0",
 "@types/lodash": "^4.14.149",
 "@types/mime": "^2.0.1",
 "@types/node": "^14.0.0",
 "@types/node": "^16.0.0",
 "@types/node-fetch": "^2.5.5",
 "@types/shell-quote": "^1.7.1"
 },
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
breaking: node 16; typescript 4#1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

thymikee
merged 2 commits into

from

Mar 9, 2023
 Merged


breaking: node 16; typescript 4
#1844
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
0e1ac87

breaking: node 16; typescript 4


thymikee Feb 20, 2023
a510b91

fixup deepmerge


thymikee Feb 20, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.github/workflows/test.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ jobs:
 runs-on: ubuntu-latest
 strategy:
 matrix:
 node-version: [14, 16, 18]
 node-version: [16, 18]
 steps:
 - uses: actions/checkout@v2
 - name: Use Node.js ${{ matrix.node-version }}
Expand Down

2 changes: 1 addition & 1 deletion
babel.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ module.exports = {
 [
 require.resolve('@babel/preset-env'),
 {
 targets: {node: '14'},
 targets: {node: '16'},
 useBuiltIns: 'entry',
 corejs: '2.x',
 },
Expand Down

6 changes: 3 additions & 3 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@
 "@react-native-community/eslint-config": "^2.0.0",
 "@types/glob": "^7.1.1",
 "@types/jest": "^26.0.15",
 "@types/node": "^14.0.0",
 "@types/node": "^16.0.0",
 "@types/node-fetch": "^2.3.7",
 "@types/rimraf": "^3.0.2",
 "@types/readable-stream": "^2.3.0",
Expand All@@ -55,10 +55,10 @@
 "rimraf": "^3.0.2",
 "slash": "^3.0.0",
 "string-length": "^2.0.0",
 "typescript": "^3.8.0"
 "typescript": "^4.9.5"
 },
 "resolutions": {
 "@types/node": "^14.0.0"
 "@types/node": "^16.0.0"
 },
 "lint-staged": {
 "./packages/**/*.{ts}": [
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-config/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "@react-native-community/cli-tools": "^10.1.1",
 "chalk": "^4.1.2",
 "cosmiconfig": "^5.1.0",
 "deepmerge": "^3.2.0",
 "deepmerge": "^4.3.0",
@thymikeethymikeeFeb 20, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this turned out to be unnecessary, but checking the release notes the only breaking change is umd -> cjs, which is fine for us
 "glob": "^7.1.3",
 "joi": "^17.2.1"
 },
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-config/src/merge.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ import deepmerge from 'deepmerge';
 * `deepmerge` concatenates arrays by default instead of overwriting them.
 * We define custom merging function for arrays to change that behaviour
 */
export default function merge<X, Y>(x: X, y: Y) {
export default function merge<X, Y>(x: Partial<X>, y: Partial<Y>) {
 return deepmerge(x, y, {
 arrayMerge: (_destinationArray: any[], sourceArray: any[]): any[] =>
 sourceArray,
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/brewInstall.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ async function brewInstall({
 logError({
 healthcheck: label || pkg,
 loader,
 error,
 error: error as any,
 command: `brew install ${pkg}`,
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/cocoaPods.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,7 +58,7 @@ export default {
 logError({
 healthcheck: label,
 loader,
 error,
 error: error as any,
 command: 'sudo gem install cocoapods',
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/iosDeploy.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,7 +44,7 @@ const installLibrary = async ({
 logError({
 healthcheck: label,
 loader,
 error,
 error: error as Error,
 command: installationCommand,
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/jdk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,7 @@ export default {
 'JDK installed successfully. Please restart your shell to see the changes',
 );
 } catch (e) {
 loader.fail(e);
 loader.fail(e as any);
 }
 },
 runAutomaticFix: async ({logManualInstallation, loader}) => {
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/xcodeEnv.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -65,7 +65,7 @@ export default {
 });
 loader.succeed('.xcode.env file have been created!');
 } catch (e) {
 loader.fail(e);
 loader.fail(e as any);
 }
 },
} as HealthCheckInterface;

6 changes: 3 additions & 3 deletions
packages/cli-doctor/src/tools/installPods.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,7 @@ async function runPodInstall(
 await execa('bundle', ['exec', 'pod', 'install']);
 } catch (error) {
 // "pod" command outputs errors to stdout (at least some of them)
 const stderr = error.stderr || error.stdout;
 const stderr = (error as any).stderr || (error as any).stdout;

 /**
 * If CocoaPods failed due to repo being out of date, it will
Expand DownExpand Up@@ -61,7 +61,7 @@ async function runPodUpdate(loader: Loader) {
 await execa('pod', ['repo', 'update']);
 } catch (error) {
 // "pod" command outputs errors to stdout (at least some of them)
 logger.log(error.stderr || error.stdout);
 logger.log((error as any).stderr || (error as any).stdout);
 loader.fail();

 throw new Error(
Expand DownExpand Up@@ -142,7 +142,7 @@ async function installCocoaPods(loader: Loader) {
 return loader.succeed();
 } catch (error) {
 loader.fail();
 logger.error(error.stderr);
 logger.error((error as any).stderr);

 throw new Error(
 `An error occured while trying to install CocoaPods, which is required by this template.\nPlease try again manually: sudo gem install cocoapods.\nCocoaPods documentation: ${chalk.dim.underline(
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/runBundleInstall.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ async function runBundleInstall(loader: Loader) {
 await execa('bundle', ['install']);
 } catch (error) {
 loader.fail();
 logger.error(error.stderr || error.stdout);
 logger.error((error as any).stderr || (error as any).stdout);

 throw new Error(
 'Looks like your iOS environment is not properly set. Please go to https://reactnative.dev/docs/next/environment-setup and follow the React Native CLI QuickStart guide for macOS and iOS.',
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/unzip.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ const unzip = async (source: string, destination: string) => {
 return reject(err);
 }

 resolve();
 resolve(undefined);
 });
 });
 });
Expand Down

6 changes: 3 additions & 3 deletions
packages/cli-doctor/src/tools/windows/androidWinHelpers.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ export const installComponent = (component: string, androidSdkRoot: string) => {

 child.on('close', (exitStatus) => {
 if (exitStatus === 0) {
 done();
 done(undefined);
 } else {
 error({stderr});
 }
Expand DownExpand Up@@ -161,7 +161,7 @@ const getEmulatorAccelOutputInformation = async (androidSDKRoot: string) => {

 return stdout;
 } catch (e) {
 const {stdout} = e;
 const {stdout} = e as any;

 return stdout;
 }
Expand DownExpand Up@@ -205,7 +205,7 @@ export const createAVD = async (

 return stdout;
 } catch (e) {
 const {stderr} = e;
 const {stderr} = e as any;

 return stderr;
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-hermes/src/profileHermes/downloadProfile.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,7 @@ function getLatestFile(packageNameWithSuffix: string): string {
 `);
 return file.toString().trim();
 } catch (e) {
 throw new Error(e);
 throw e;
 }
}

Expand Down

4 changes: 2 additions & 2 deletions
packages/cli-hermes/src/profileHermes/sourcemapUtils.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,14 +17,14 @@ function writeJsonSync(targetPath: string, data: any) {
 } catch (e) {
 throw new CLIError(
 `Failed to serialize data to json before writing to ${targetPath}`,
 e,
 e as Error,
 );
 }

 try {
 fs.writeFileSync(targetPath, json, 'utf-8');
 } catch (e) {
 throw new CLIError(`Failed to write json to ${targetPath}`, e);
 throw new CLIError(`Failed to write json to ${targetPath}`, e as Error);
 }
}

Expand Down

10 changes: 6 additions & 4 deletions
packages/cli-platform-android/src/commands/buildAndroid/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,9 +41,11 @@ export async function runPackager(args: BuildFlags, config: Config) {
 try {
 startServerInNewWindow(args.port, args.terminal, config.reactNativePath);
 } catch (error) {
 logger.warn(
 `Failed to automatically start the packager server. Please run "react-native start" manually. Error details: ${error.message}`,
 );
 if (error instanceof Error) {
 logger.warn(
 `Failed to automatically start the packager server. Please run "react-native start" manually. Error details: ${error.message}`,
 );
 }
 }
 }
}
Expand DownExpand Up@@ -126,7 +128,7 @@ export function build(gradleArgs: string[], sourceDir: string) {
 });
 } catch (error) {
 printRunDoctorTip();
 throw new CLIError('Failed to build the app.', error);
 throw new CLIError('Failed to build the app.', error as Error);
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/runOnAllDevices.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -104,7 +104,7 @@ async function runOnAllDevices(
 }
 } catch (error) {
 printRunDoctorTip();
 throw createInstallError(error);
 throw createInstallError(error as any);
 }

 (devices.length > 0 ? devices : [undefined]).forEach(
Expand Down

5 changes: 4 additions & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryInstallAppOnDevice.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,10 @@ function tryInstallAppOnDevice(
 );
 execa.sync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (error) {
 throw new CLIError('Failed to install the app on the device.', error);
 throw new CLIError(
 'Failed to install the app on the device.',
 error as any,
 );
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryLaunchAppOnDevice.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ function tryLaunchAppOnDevice(
 logger.debug(`Running command "${adbPath} ${adbArgs.join(' ')}"`);
 execa.sync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (error) {
 throw new CLIError('Failed to start the app.', error);
 throw new CLIError('Failed to start the app.', error as any);
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryLaunchEmulator.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@ export default async function tryLaunchEmulator(
 await launchEmulator(emulatorName ?? emulators[0], adbPath, port);
 return {success: true};
 } catch (error) {
 return {success: false, error: error?.message};
 return {success: false, error: (error as any)?.message};
 }
 }
 return {
Expand Down

4 changes: 3 additions & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryRunAdbReverse.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,9 @@ function tryRunAdbReverse(
 execFileSync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (e) {
 logger.warn(
 `Failed to connect to development server using "adb reverse": ${e.message}`,
 `Failed to connect to development server using "adb reverse": ${
 (e as any).message
 }`,
 );
 }
}
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/commands/runIOS/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -209,7 +209,7 @@ const getSimulators = () => {
 } catch (error) {
 throw new CLIError(
 'Could not get the simulator list from Xcode. Please open Xcode and try running project directly from there to resolve the remaining issues.',
 error,
 error as Error,
 );
 }
 return simulators;
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/tools/getDestinationSimulator.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ export function getDestinationSimulator(
 } catch (error) {
 throw new CLIError(
 'Could not get the simulator list from Xcode. Please open Xcode and try running project directly from there to resolve the remaining issues.',
 error,
 error as Error,
 );
 }

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/tools/getProjectInfo.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,6 @@ export function getProjectInfo(): IosProjectInfo {

 return project;
 } catch (error) {
 throw new CLIError(error);
 throw new CLIError(error as any);
 }
}

6 changes: 3 additions & 3 deletions
packages/cli-server-api/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,16 +11,16 @@
 "@react-native-community/cli-tools": "^10.1.1",
 "compression": "^1.7.1",
 "connect": "^3.6.5",
 "errorhandler": "^1.5.0",
 "errorhandler": "^1.5.1",
 "nocache": "^3.0.1",
 "pretty-format": "^26.6.2",
 "serve-static": "^1.13.1",
 "ws": "^7.5.1"
 },
 "devDependencies": {
 "@types/compression": "^1.0.1",
 "@types/compression": "^1.7.2",
 "@types/connect": "^3.4.33",
 "@types/errorhandler": "^0.0.32",
 "@types/errorhandler": "^1.5.0",
 "@types/ws": "^7.4.7"
 },
 "files": [
Expand Down

2 changes: 2 additions & 0 deletions
packages/cli-server-api/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,11 +58,13 @@ export function createDevServerMiddleware(options: MiddlewareOptions) {
 .use('/open-url', openURLMiddleware)
 .use('/status', statusPageMiddleware)
 .use('/symbolicate', rawBodyMiddleware)
 // @ts-ignore mismatch
 .use('/systrace', systraceProfileMiddleware)
 .use('/reload', (_req: http.IncomingMessage, res: http.ServerResponse) => {
 broadcast('reload');
 res.end('OK');
 })
 // @ts-ignore mismatch
 .use(errorhandler());

 options.watchFolders.forEach((folder) => {
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-server-api/src/websocket/createDebuggerProxyEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ export default function createDebuggerProxyEndpoint(): {
 try {
 dest.send(message);
 } catch (e) {
 logger.warn(e);
 logger.warn(e as any);
 // Sometimes this call throws 'not opened'
 }
 }
Expand Down

4 changes: 2 additions & 2 deletions
packages/cli-server-api/src/websocket/createEventsSocketEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ export default function createEventsSocketEndpoint(
 ws.send(serialized);
 } catch (e) {
 logger.error(
 `Failed to send broadcast to client due to:\n ${e.toString()}`,
 `Failed to send broadcast to client due to:\n ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -178,7 +178,7 @@ export default function createEventsSocketEndpoint(
 */
 broadcast(message.command, message.params);
 } catch (e) {
 logger.error('Failed to forward message to clients: ', e);
 logger.error('Failed to forward message to clients: ', e as any);
 }
 } else {
 logger.error('Unknown message type: ', message.type);
Expand Down

6 changes: 3 additions & 3 deletions
packages/cli-server-api/src/websocket/createMessageSocketEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -109,7 +109,7 @@ export default function createMessageSocketEndpoint(): {
 } catch (e) {
 logger.error(
 `Failed to send broadcast to client: '${otherId}' ` +
 `due to:\n ${e.toString()}`,
 `due to:\n ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -147,7 +147,7 @@ export default function createMessageSocketEndpoint(): {
 logger.error(
 `Failed to reply to ${clientId} with error:\n${error}` +
 `\nmessage:\n${JSON.stringify(errorMessage)}` +
 `\ndue to error: ${e.toString()}`,
 `\ndue to error: ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -237,7 +237,7 @@ export default function createMessageSocketEndpoint(): {
 throw new Error('Invalid message, did not match the protocol');
 }
 } catch (e) {
 handleCaughtError(message, e.toString());
 handleCaughtError(message, (e as any).toString());
 }
 };
 });
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-tools/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@
 "@react-native-community/cli-types": "^10.0.0",
 "@types/lodash": "^4.14.149",
 "@types/mime": "^2.0.1",
 "@types/node": "^14.0.0",
 "@types/node": "^16.0.0",
 "@types/node-fetch": "^2.5.5",
 "@types/shell-quote": "^1.7.1"
 },
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
breaking: node 16; typescript 4#1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

thymikee
merged 2 commits into

from

Mar 9, 2023
 Merged


breaking: node 16; typescript 4
#1844
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
0e1ac87

breaking: node 16; typescript 4


thymikee Feb 20, 2023
a510b91

fixup deepmerge


thymikee Feb 20, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.github/workflows/test.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ jobs:
 runs-on: ubuntu-latest
 strategy:
 matrix:
 node-version: [14, 16, 18]
 node-version: [16, 18]
 steps:
 - uses: actions/checkout@v2
 - name: Use Node.js ${{ matrix.node-version }}
Expand Down

2 changes: 1 addition & 1 deletion
babel.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ module.exports = {
 [
 require.resolve('@babel/preset-env'),
 {
 targets: {node: '14'},
 targets: {node: '16'},
 useBuiltIns: 'entry',
 corejs: '2.x',
 },
Expand Down

6 changes: 3 additions & 3 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@
 "@react-native-community/eslint-config": "^2.0.0",
 "@types/glob": "^7.1.1",
 "@types/jest": "^26.0.15",
 "@types/node": "^14.0.0",
 "@types/node": "^16.0.0",
 "@types/node-fetch": "^2.3.7",
 "@types/rimraf": "^3.0.2",
 "@types/readable-stream": "^2.3.0",
Expand All@@ -55,10 +55,10 @@
 "rimraf": "^3.0.2",
 "slash": "^3.0.0",
 "string-length": "^2.0.0",
 "typescript": "^3.8.0"
 "typescript": "^4.9.5"
 },
 "resolutions": {
 "@types/node": "^14.0.0"
 "@types/node": "^16.0.0"
 },
 "lint-staged": {
 "./packages/**/*.{ts}": [
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-config/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "@react-native-community/cli-tools": "^10.1.1",
 "chalk": "^4.1.2",
 "cosmiconfig": "^5.1.0",
 "deepmerge": "^3.2.0",
 "deepmerge": "^4.3.0",
@thymikeethymikeeFeb 20, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this turned out to be unnecessary, but checking the release notes the only breaking change is umd -> cjs, which is fine for us
 "glob": "^7.1.3",
 "joi": "^17.2.1"
 },
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-config/src/merge.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ import deepmerge from 'deepmerge';
 * `deepmerge` concatenates arrays by default instead of overwriting them.
 * We define custom merging function for arrays to change that behaviour
 */
export default function merge<X, Y>(x: X, y: Y) {
export default function merge<X, Y>(x: Partial<X>, y: Partial<Y>) {
 return deepmerge(x, y, {
 arrayMerge: (_destinationArray: any[], sourceArray: any[]): any[] =>
 sourceArray,
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/brewInstall.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ async function brewInstall({
 logError({
 healthcheck: label || pkg,
 loader,
 error,
 error: error as any,
 command: `brew install ${pkg}`,
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/cocoaPods.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,7 +58,7 @@ export default {
 logError({
 healthcheck: label,
 loader,
 error,
 error: error as any,
 command: 'sudo gem install cocoapods',
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/iosDeploy.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,7 +44,7 @@ const installLibrary = async ({
 logError({
 healthcheck: label,
 loader,
 error,
 error: error as Error,
 command: installationCommand,
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/jdk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,7 @@ export default {
 'JDK installed successfully. Please restart your shell to see the changes',
 );
 } catch (e) {
 loader.fail(e);
 loader.fail(e as any);
 }
 },
 runAutomaticFix: async ({logManualInstallation, loader}) => {
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/xcodeEnv.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -65,7 +65,7 @@ export default {
 });
 loader.succeed('.xcode.env file have been created!');
 } catch (e) {
 loader.fail(e);
 loader.fail(e as any);
 }
 },
} as HealthCheckInterface;

6 changes: 3 additions & 3 deletions
packages/cli-doctor/src/tools/installPods.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,7 @@ async function runPodInstall(
 await execa('bundle', ['exec', 'pod', 'install']);
 } catch (error) {
 // "pod" command outputs errors to stdout (at least some of them)
 const stderr = error.stderr || error.stdout;
 const stderr = (error as any).stderr || (error as any).stdout;

 /**
 * If CocoaPods failed due to repo being out of date, it will
Expand DownExpand Up@@ -61,7 +61,7 @@ async function runPodUpdate(loader: Loader) {
 await execa('pod', ['repo', 'update']);
 } catch (error) {
 // "pod" command outputs errors to stdout (at least some of them)
 logger.log(error.stderr || error.stdout);
 logger.log((error as any).stderr || (error as any).stdout);
 loader.fail();

 throw new Error(
Expand DownExpand Up@@ -142,7 +142,7 @@ async function installCocoaPods(loader: Loader) {
 return loader.succeed();
 } catch (error) {
 loader.fail();
 logger.error(error.stderr);
 logger.error((error as any).stderr);

 throw new Error(
 `An error occured while trying to install CocoaPods, which is required by this template.\nPlease try again manually: sudo gem install cocoapods.\nCocoaPods documentation: ${chalk.dim.underline(
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/runBundleInstall.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ async function runBundleInstall(loader: Loader) {
 await execa('bundle', ['install']);
 } catch (error) {
 loader.fail();
 logger.error(error.stderr || error.stdout);
 logger.error((error as any).stderr || (error as any).stdout);

 throw new Error(
 'Looks like your iOS environment is not properly set. Please go to https://reactnative.dev/docs/next/environment-setup and follow the React Native CLI QuickStart guide for macOS and iOS.',
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/unzip.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ const unzip = async (source: string, destination: string) => {
 return reject(err);
 }

 resolve();
 resolve(undefined);
 });
 });
 });
Expand Down

6 changes: 3 additions & 3 deletions
packages/cli-doctor/src/tools/windows/androidWinHelpers.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ export const installComponent = (component: string, androidSdkRoot: string) => {

 child.on('close', (exitStatus) => {
 if (exitStatus === 0) {
 done();
 done(undefined);
 } else {
 error({stderr});
 }
Expand DownExpand Up@@ -161,7 +161,7 @@ const getEmulatorAccelOutputInformation = async (androidSDKRoot: string) => {

 return stdout;
 } catch (e) {
 const {stdout} = e;
 const {stdout} = e as any;

 return stdout;
 }
Expand DownExpand Up@@ -205,7 +205,7 @@ export const createAVD = async (

 return stdout;
 } catch (e) {
 const {stderr} = e;
 const {stderr} = e as any;

 return stderr;
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-hermes/src/profileHermes/downloadProfile.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,7 @@ function getLatestFile(packageNameWithSuffix: string): string {
 `);
 return file.toString().trim();
 } catch (e) {
 throw new Error(e);
 throw e;
 }
}

Expand Down

4 changes: 2 additions & 2 deletions
packages/cli-hermes/src/profileHermes/sourcemapUtils.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,14 +17,14 @@ function writeJsonSync(targetPath: string, data: any) {
 } catch (e) {
 throw new CLIError(
 `Failed to serialize data to json before writing to ${targetPath}`,
 e,
 e as Error,
 );
 }

 try {
 fs.writeFileSync(targetPath, json, 'utf-8');
 } catch (e) {
 throw new CLIError(`Failed to write json to ${targetPath}`, e);
 throw new CLIError(`Failed to write json to ${targetPath}`, e as Error);
 }
}

Expand Down

10 changes: 6 additions & 4 deletions
packages/cli-platform-android/src/commands/buildAndroid/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,9 +41,11 @@ export async function runPackager(args: BuildFlags, config: Config) {
 try {
 startServerInNewWindow(args.port, args.terminal, config.reactNativePath);
 } catch (error) {
 logger.warn(
 `Failed to automatically start the packager server. Please run "react-native start" manually. Error details: ${error.message}`,
 );
 if (error instanceof Error) {
 logger.warn(
 `Failed to automatically start the packager server. Please run "react-native start" manually. Error details: ${error.message}`,
 );
 }
 }
 }
}
Expand DownExpand Up@@ -126,7 +128,7 @@ export function build(gradleArgs: string[], sourceDir: string) {
 });
 } catch (error) {
 printRunDoctorTip();
 throw new CLIError('Failed to build the app.', error);
 throw new CLIError('Failed to build the app.', error as Error);
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/runOnAllDevices.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -104,7 +104,7 @@ async function runOnAllDevices(
 }
 } catch (error) {
 printRunDoctorTip();
 throw createInstallError(error);
 throw createInstallError(error as any);
 }

 (devices.length > 0 ? devices : [undefined]).forEach(
Expand Down

5 changes: 4 additions & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryInstallAppOnDevice.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,10 @@ function tryInstallAppOnDevice(
 );
 execa.sync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (error) {
 throw new CLIError('Failed to install the app on the device.', error);
 throw new CLIError(
 'Failed to install the app on the device.',
 error as any,
 );
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryLaunchAppOnDevice.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ function tryLaunchAppOnDevice(
 logger.debug(`Running command "${adbPath} ${adbArgs.join(' ')}"`);
 execa.sync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (error) {
 throw new CLIError('Failed to start the app.', error);
 throw new CLIError('Failed to start the app.', error as any);
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryLaunchEmulator.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@ export default async function tryLaunchEmulator(
 await launchEmulator(emulatorName ?? emulators[0], adbPath, port);
 return {success: true};
 } catch (error) {
 return {success: false, error: error?.message};
 return {success: false, error: (error as any)?.message};
 }
 }
 return {
Expand Down

4 changes: 3 additions & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryRunAdbReverse.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,9 @@ function tryRunAdbReverse(
 execFileSync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (e) {
 logger.warn(
 `Failed to connect to development server using "adb reverse": ${e.message}`,
 `Failed to connect to development server using "adb reverse": ${
 (e as any).message
 }`,
 );
 }
}
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/commands/runIOS/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -209,7 +209,7 @@ const getSimulators = () => {
 } catch (error) {
 throw new CLIError(
 'Could not get the simulator list from Xcode. Please open Xcode and try running project directly from there to resolve the remaining issues.',
 error,
 error as Error,
 );
 }
 return simulators;
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/tools/getDestinationSimulator.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ export function getDestinationSimulator(
 } catch (error) {
 throw new CLIError(
 'Could not get the simulator list from Xcode. Please open Xcode and try running project directly from there to resolve the remaining issues.',
 error,
 error as Error,
 );
 }

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/tools/getProjectInfo.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,6 @@ export function getProjectInfo(): IosProjectInfo {

 return project;
 } catch (error) {
 throw new CLIError(error);
 throw new CLIError(error as any);
 }
}

6 changes: 3 additions & 3 deletions
packages/cli-server-api/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,16 +11,16 @@
 "@react-native-community/cli-tools": "^10.1.1",
 "compression": "^1.7.1",
 "connect": "^3.6.5",
 "errorhandler": "^1.5.0",
 "errorhandler": "^1.5.1",
 "nocache": "^3.0.1",
 "pretty-format": "^26.6.2",
 "serve-static": "^1.13.1",
 "ws": "^7.5.1"
 },
 "devDependencies": {
 "@types/compression": "^1.0.1",
 "@types/compression": "^1.7.2",
 "@types/connect": "^3.4.33",
 "@types/errorhandler": "^0.0.32",
 "@types/errorhandler": "^1.5.0",
 "@types/ws": "^7.4.7"
 },
 "files": [
Expand Down

2 changes: 2 additions & 0 deletions
packages/cli-server-api/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,11 +58,13 @@ export function createDevServerMiddleware(options: MiddlewareOptions) {
 .use('/open-url', openURLMiddleware)
 .use('/status', statusPageMiddleware)
 .use('/symbolicate', rawBodyMiddleware)
 // @ts-ignore mismatch
 .use('/systrace', systraceProfileMiddleware)
 .use('/reload', (_req: http.IncomingMessage, res: http.ServerResponse) => {
 broadcast('reload');
 res.end('OK');
 })
 // @ts-ignore mismatch
 .use(errorhandler());

 options.watchFolders.forEach((folder) => {
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-server-api/src/websocket/createDebuggerProxyEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ export default function createDebuggerProxyEndpoint(): {
 try {
 dest.send(message);
 } catch (e) {
 logger.warn(e);
 logger.warn(e as any);
 // Sometimes this call throws 'not opened'
 }
 }
Expand Down

4 changes: 2 additions & 2 deletions
packages/cli-server-api/src/websocket/createEventsSocketEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ export default function createEventsSocketEndpoint(
 ws.send(serialized);
 } catch (e) {
 logger.error(
 `Failed to send broadcast to client due to:\n ${e.toString()}`,
 `Failed to send broadcast to client due to:\n ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -178,7 +178,7 @@ export default function createEventsSocketEndpoint(
 */
 broadcast(message.command, message.params);
 } catch (e) {
 logger.error('Failed to forward message to clients: ', e);
 logger.error('Failed to forward message to clients: ', e as any);
 }
 } else {
 logger.error('Unknown message type: ', message.type);
Expand Down

6 changes: 3 additions & 3 deletions
packages/cli-server-api/src/websocket/createMessageSocketEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -109,7 +109,7 @@ export default function createMessageSocketEndpoint(): {
 } catch (e) {
 logger.error(
 `Failed to send broadcast to client: '${otherId}' ` +
 `due to:\n ${e.toString()}`,
 `due to:\n ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -147,7 +147,7 @@ export default function createMessageSocketEndpoint(): {
 logger.error(
 `Failed to reply to ${clientId} with error:\n${error}` +
 `\nmessage:\n${JSON.stringify(errorMessage)}` +
 `\ndue to error: ${e.toString()}`,
 `\ndue to error: ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -237,7 +237,7 @@ export default function createMessageSocketEndpoint(): {
 throw new Error('Invalid message, did not match the protocol');
 }
 } catch (e) {
 handleCaughtError(message, e.toString());
 handleCaughtError(message, (e as any).toString());
 }
 };
 });
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-tools/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@
 "@react-native-community/cli-types": "^10.0.0",
 "@types/lodash": "^4.14.149",
 "@types/mime": "^2.0.1",
 "@types/node": "^14.0.0",
 "@types/node": "^16.0.0",
 "@types/node-fetch": "^2.5.5",
 "@types/shell-quote": "^1.7.1"
 },
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
breaking: node 16; typescript 4#1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

thymikee
merged 2 commits into

from

Mar 9, 2023
 Merged


breaking: node 16; typescript 4
#1844
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
0e1ac87

breaking: node 16; typescript 4


thymikee Feb 20, 2023
a510b91

fixup deepmerge


thymikee Feb 20, 2023

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.github/workflows/test.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ jobs:
 runs-on: ubuntu-latest
 strategy:
 matrix:
 node-version: [14, 16, 18]
 node-version: [16, 18]
 steps:
 - uses: actions/checkout@v2
 - name: Use Node.js ${{ matrix.node-version }}
Expand Down

2 changes: 1 addition & 1 deletion
babel.config.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ module.exports = {
 [
 require.resolve('@babel/preset-env'),
 {
 targets: {node: '14'},
 targets: {node: '16'},
 useBuiltIns: 'entry',
 corejs: '2.x',
 },
Expand Down

6 changes: 3 additions & 3 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@
 "@react-native-community/eslint-config": "^2.0.0",
 "@types/glob": "^7.1.1",
 "@types/jest": "^26.0.15",
 "@types/node": "^14.0.0",
 "@types/node": "^16.0.0",
 "@types/node-fetch": "^2.3.7",
 "@types/rimraf": "^3.0.2",
 "@types/readable-stream": "^2.3.0",
Expand All@@ -55,10 +55,10 @@
 "rimraf": "^3.0.2",
 "slash": "^3.0.0",
 "string-length": "^2.0.0",
 "typescript": "^3.8.0"
 "typescript": "^4.9.5"
 },
 "resolutions": {
 "@types/node": "^14.0.0"
 "@types/node": "^16.0.0"
 },
 "lint-staged": {
 "./packages/**/*.{ts}": [
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-config/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "@react-native-community/cli-tools": "^10.1.1",
 "chalk": "^4.1.2",
 "cosmiconfig": "^5.1.0",
 "deepmerge": "^3.2.0",
 "deepmerge": "^4.3.0",
@thymikeethymikeeFeb 20, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this turned out to be unnecessary, but checking the release notes the only breaking change is umd -> cjs, which is fine for us
 "glob": "^7.1.3",
 "joi": "^17.2.1"
 },
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-config/src/merge.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ import deepmerge from 'deepmerge';
 * `deepmerge` concatenates arrays by default instead of overwriting them.
 * We define custom merging function for arrays to change that behaviour
 */
export default function merge<X, Y>(x: X, y: Y) {
export default function merge<X, Y>(x: Partial<X>, y: Partial<Y>) {
 return deepmerge(x, y, {
 arrayMerge: (_destinationArray: any[], sourceArray: any[]): any[] =>
 sourceArray,
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/brewInstall.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ async function brewInstall({
 logError({
 healthcheck: label || pkg,
 loader,
 error,
 error: error as any,
 command: `brew install ${pkg}`,
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/cocoaPods.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,7 +58,7 @@ export default {
 logError({
 healthcheck: label,
 loader,
 error,
 error: error as any,
 command: 'sudo gem install cocoapods',
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/iosDeploy.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,7 +44,7 @@ const installLibrary = async ({
 logError({
 healthcheck: label,
 loader,
 error,
 error: error as Error,
 command: installationCommand,
 });
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/jdk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,7 +51,7 @@ export default {
 'JDK installed successfully. Please restart your shell to see the changes',
 );
 } catch (e) {
 loader.fail(e);
 loader.fail(e as any);
 }
 },
 runAutomaticFix: async ({logManualInstallation, loader}) => {
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/healthchecks/xcodeEnv.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -65,7 +65,7 @@ export default {
 });
 loader.succeed('.xcode.env file have been created!');
 } catch (e) {
 loader.fail(e);
 loader.fail(e as any);
 }
 },
} as HealthCheckInterface;

6 changes: 3 additions & 3 deletions
packages/cli-doctor/src/tools/installPods.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,7 @@ async function runPodInstall(
 await execa('bundle', ['exec', 'pod', 'install']);
 } catch (error) {
 // "pod" command outputs errors to stdout (at least some of them)
 const stderr = error.stderr || error.stdout;
 const stderr = (error as any).stderr || (error as any).stdout;

 /**
 * If CocoaPods failed due to repo being out of date, it will
Expand DownExpand Up@@ -61,7 +61,7 @@ async function runPodUpdate(loader: Loader) {
 await execa('pod', ['repo', 'update']);
 } catch (error) {
 // "pod" command outputs errors to stdout (at least some of them)
 logger.log(error.stderr || error.stdout);
 logger.log((error as any).stderr || (error as any).stdout);
 loader.fail();

 throw new Error(
Expand DownExpand Up@@ -142,7 +142,7 @@ async function installCocoaPods(loader: Loader) {
 return loader.succeed();
 } catch (error) {
 loader.fail();
 logger.error(error.stderr);
 logger.error((error as any).stderr);

 throw new Error(
 `An error occured while trying to install CocoaPods, which is required by this template.\nPlease try again manually: sudo gem install cocoapods.\nCocoaPods documentation: ${chalk.dim.underline(
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/runBundleInstall.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ async function runBundleInstall(loader: Loader) {
 await execa('bundle', ['install']);
 } catch (error) {
 loader.fail();
 logger.error(error.stderr || error.stdout);
 logger.error((error as any).stderr || (error as any).stdout);

 throw new Error(
 'Looks like your iOS environment is not properly set. Please go to https://reactnative.dev/docs/next/environment-setup and follow the React Native CLI QuickStart guide for macOS and iOS.',
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-doctor/src/tools/unzip.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ const unzip = async (source: string, destination: string) => {
 return reject(err);
 }

 resolve();
 resolve(undefined);
 });
 });
 });
Expand Down

6 changes: 3 additions & 3 deletions
packages/cli-doctor/src/tools/windows/androidWinHelpers.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ export const installComponent = (component: string, androidSdkRoot: string) => {

 child.on('close', (exitStatus) => {
 if (exitStatus === 0) {
 done();
 done(undefined);
 } else {
 error({stderr});
 }
Expand DownExpand Up@@ -161,7 +161,7 @@ const getEmulatorAccelOutputInformation = async (androidSDKRoot: string) => {

 return stdout;
 } catch (e) {
 const {stdout} = e;
 const {stdout} = e as any;

 return stdout;
 }
Expand DownExpand Up@@ -205,7 +205,7 @@ export const createAVD = async (

 return stdout;
 } catch (e) {
 const {stderr} = e;
 const {stderr} = e as any;

 return stderr;
 }
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-hermes/src/profileHermes/downloadProfile.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,7 @@ function getLatestFile(packageNameWithSuffix: string): string {
 `);
 return file.toString().trim();
 } catch (e) {
 throw new Error(e);
 throw e;
 }
}

Expand Down

4 changes: 2 additions & 2 deletions
packages/cli-hermes/src/profileHermes/sourcemapUtils.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,14 +17,14 @@ function writeJsonSync(targetPath: string, data: any) {
 } catch (e) {
 throw new CLIError(
 `Failed to serialize data to json before writing to ${targetPath}`,
 e,
 e as Error,
 );
 }

 try {
 fs.writeFileSync(targetPath, json, 'utf-8');
 } catch (e) {
 throw new CLIError(`Failed to write json to ${targetPath}`, e);
 throw new CLIError(`Failed to write json to ${targetPath}`, e as Error);
 }
}

Expand Down

10 changes: 6 additions & 4 deletions
packages/cli-platform-android/src/commands/buildAndroid/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -41,9 +41,11 @@ export async function runPackager(args: BuildFlags, config: Config) {
 try {
 startServerInNewWindow(args.port, args.terminal, config.reactNativePath);
 } catch (error) {
 logger.warn(
 `Failed to automatically start the packager server. Please run "react-native start" manually. Error details: ${error.message}`,
 );
 if (error instanceof Error) {
 logger.warn(
 `Failed to automatically start the packager server. Please run "react-native start" manually. Error details: ${error.message}`,
 );
 }
 }
 }
}
Expand DownExpand Up@@ -126,7 +128,7 @@ export function build(gradleArgs: string[], sourceDir: string) {
 });
 } catch (error) {
 printRunDoctorTip();
 throw new CLIError('Failed to build the app.', error);
 throw new CLIError('Failed to build the app.', error as Error);
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/runOnAllDevices.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -104,7 +104,7 @@ async function runOnAllDevices(
 }
 } catch (error) {
 printRunDoctorTip();
 throw createInstallError(error);
 throw createInstallError(error as any);
 }

 (devices.length > 0 ? devices : [undefined]).forEach(
Expand Down

5 changes: 4 additions & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryInstallAppOnDevice.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,10 @@ function tryInstallAppOnDevice(
 );
 execa.sync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (error) {
 throw new CLIError('Failed to install the app on the device.', error);
 throw new CLIError(
 'Failed to install the app on the device.',
 error as any,
 );
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryLaunchAppOnDevice.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@ function tryLaunchAppOnDevice(
 logger.debug(`Running command "${adbPath} ${adbArgs.join(' ')}"`);
 execa.sync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (error) {
 throw new CLIError('Failed to start the app.', error);
 throw new CLIError('Failed to start the app.', error as any);
 }
}

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryLaunchEmulator.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@ export default async function tryLaunchEmulator(
 await launchEmulator(emulatorName ?? emulators[0], adbPath, port);
 return {success: true};
 } catch (error) {
 return {success: false, error: error?.message};
 return {success: false, error: (error as any)?.message};
 }
 }
 return {
Expand Down

4 changes: 3 additions & 1 deletion
packages/cli-platform-android/src/commands/runAndroid/tryRunAdbReverse.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,9 @@ function tryRunAdbReverse(
 execFileSync(adbPath, adbArgs, {stdio: 'inherit'});
 } catch (e) {
 logger.warn(
 `Failed to connect to development server using "adb reverse": ${e.message}`,
 `Failed to connect to development server using "adb reverse": ${
 (e as any).message
 }`,
 );
 }
}
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/commands/runIOS/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -209,7 +209,7 @@ const getSimulators = () => {
 } catch (error) {
 throw new CLIError(
 'Could not get the simulator list from Xcode. Please open Xcode and try running project directly from there to resolve the remaining issues.',
 error,
 error as Error,
 );
 }
 return simulators;
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/tools/getDestinationSimulator.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ export function getDestinationSimulator(
 } catch (error) {
 throw new CLIError(
 'Could not get the simulator list from Xcode. Please open Xcode and try running project directly from there to resolve the remaining issues.',
 error,
 error as Error,
 );
 }

Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-platform-ios/src/tools/getProjectInfo.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,6 @@ export function getProjectInfo(): IosProjectInfo {

 return project;
 } catch (error) {
 throw new CLIError(error);
 throw new CLIError(error as any);
 }
}

6 changes: 3 additions & 3 deletions
packages/cli-server-api/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,16 +11,16 @@
 "@react-native-community/cli-tools": "^10.1.1",
 "compression": "^1.7.1",
 "connect": "^3.6.5",
 "errorhandler": "^1.5.0",
 "errorhandler": "^1.5.1",
 "nocache": "^3.0.1",
 "pretty-format": "^26.6.2",
 "serve-static": "^1.13.1",
 "ws": "^7.5.1"
 },
 "devDependencies": {
 "@types/compression": "^1.0.1",
 "@types/compression": "^1.7.2",
 "@types/connect": "^3.4.33",
 "@types/errorhandler": "^0.0.32",
 "@types/errorhandler": "^1.5.0",
 "@types/ws": "^7.4.7"
 },
 "files": [
Expand Down

2 changes: 2 additions & 0 deletions
packages/cli-server-api/src/index.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,11 +58,13 @@ export function createDevServerMiddleware(options: MiddlewareOptions) {
 .use('/open-url', openURLMiddleware)
 .use('/status', statusPageMiddleware)
 .use('/symbolicate', rawBodyMiddleware)
 // @ts-ignore mismatch
 .use('/systrace', systraceProfileMiddleware)
 .use('/reload', (_req: http.IncomingMessage, res: http.ServerResponse) => {
 broadcast('reload');
 res.end('OK');
 })
 // @ts-ignore mismatch
 .use(errorhandler());

 options.watchFolders.forEach((folder) => {
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-server-api/src/websocket/createDebuggerProxyEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,7 @@ export default function createDebuggerProxyEndpoint(): {
 try {
 dest.send(message);
 } catch (e) {
 logger.warn(e);
 logger.warn(e as any);
 // Sometimes this call throws 'not opened'
 }
 }
Expand Down

4 changes: 2 additions & 2 deletions
packages/cli-server-api/src/websocket/createEventsSocketEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ export default function createEventsSocketEndpoint(
 ws.send(serialized);
 } catch (e) {
 logger.error(
 `Failed to send broadcast to client due to:\n ${e.toString()}`,
 `Failed to send broadcast to client due to:\n ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -178,7 +178,7 @@ export default function createEventsSocketEndpoint(
 */
 broadcast(message.command, message.params);
 } catch (e) {
 logger.error('Failed to forward message to clients: ', e);
 logger.error('Failed to forward message to clients: ', e as any);
 }
 } else {
 logger.error('Unknown message type: ', message.type);
Expand Down

6 changes: 3 additions & 3 deletions
packages/cli-server-api/src/websocket/createMessageSocketEndpoint.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -109,7 +109,7 @@ export default function createMessageSocketEndpoint(): {
 } catch (e) {
 logger.error(
 `Failed to send broadcast to client: '${otherId}' ` +
 `due to:\n ${e.toString()}`,
 `due to:\n ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -147,7 +147,7 @@ export default function createMessageSocketEndpoint(): {
 logger.error(
 `Failed to reply to ${clientId} with error:\n${error}` +
 `\nmessage:\n${JSON.stringify(errorMessage)}` +
 `\ndue to error: ${e.toString()}`,
 `\ndue to error: ${(e as any).toString()}`,
 );
 }
 }
Expand DownExpand Up@@ -237,7 +237,7 @@ export default function createMessageSocketEndpoint(): {
 throw new Error('Invalid message, did not match the protocol');
 }
 } catch (e) {
 handleCaughtError(message, e.toString());
 handleCaughtError(message, (e as any).toString());
 }
 };
 });
Expand Down

2 changes: 1 addition & 1 deletion
packages/cli-tools/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@
 "@react-native-community/cli-types": "^10.0.0",
 "@types/lodash": "^4.14.149",
 "@types/mime": "^2.0.1",
 "@types/node": "^14.0.0",
 "@types/node": "^16.0.0",
 "@types/node-fetch": "^2.5.5",
 "@types/shell-quote": "^1.7.1"
 },
Expand Down
Loading