Skip to content

breaking: Fix ability to override commands via config - #1999

Merged
thymikee merged 1 commit into
react-native-community:mainfrom
huntie:fix-plugin-system
Jul 18, 2023
Merged

breaking: Fix ability to override commands via config#1999
thymikee merged 1 commit into
react-native-community:mainfrom
huntie:fix-plugin-system

Conversation

@huntie

@huntiehuntie commented Jul 5, 2023

Copy link
Copy Markdown
Collaborator

Summary

I noticed a non-obvious bug when attempting to use react-native.config.js to override commands (i.e. the plugin system) over the CLI's built-in defaults.

While the below printout shows the project-configured commands being successfully read after the internal commands, these are never applied — due to a bug in all versions of the commander library where commands are stored as an array structure where the first registered command with a given name is used (and silently failing upon re-registering a command later 😐).

image

Changelog:
[Breaking] Custom commands in react-native.config.js files in libraries or projects will now override built-in CLI commands if defined with the same command name

Test Plan

  • Set up more console.logs
  • Build
  • yarn link to local React Native project with extended config ⬇️
module.exports={commands: [
...ios.commands,
...android.commands,bundleCommand,ramBundleCommand,startCommand,],
image

✅ Command implementation for react-native start can be successfully overridden

cc @tido64 for any potential downstream impact on rnx-kit

tido64
tido64 reviewed Jul 5, 2023
View reviewed changes
Comment threadpackages/cli/src/index.ts Outdated
@huntie
huntieforce-pushed the fix-plugin-system branch from 889f00f to 6047aeeCompareJuly 5, 2023 10:43
@huntiehuntie mentioned this pull request Jul 6, 2023
Closed
shadowspawn
shadowspawn reviewed Jul 6, 2023
View reviewed changes
Comment threadpackages/cli/src/index.ts Outdated
@huntie
huntieforce-pushed the fix-plugin-system branch from 6047aee to f7d1176CompareJuly 7, 2023 15:22
@huntie

huntie commented Jul 17, 2023

Copy link
Copy Markdown
CollaboratorAuthor

@tido64@thymikee Bump :)

tido64
tido64 approved these changes Jul 17, 2023
View reviewed changes

@tido64tido64 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have my symbolic vote. 😄

szymonrybczak
szymonrybczak approved these changes Jul 18, 2023
View reviewed changes

@szymonrybczakszymonrybczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@thymikee
thymikee merged commit ba362e6 into react-native-community:mainJul 18, 2023
@huntie
huntie deleted the fix-plugin-system branch July 18, 2023 16:49
@huntiehuntie mentioned this pull request Aug 7, 2023
Closed
facebook-github-bot pushed a commit to react/react-native that referenced this pull request Aug 10, 2023
@huntie@facebook-github-bot
Migrate cli-plugin-metro into repo (#38795)
e199880
Summary:
Pull Request resolved: #38795
## Context
RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641
## Changes
Inits new package `react-native/community-cli-plugin`. This migrates [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) into the React Native repo, to enable faster iteration by the React Native core team. Specifically:
- This package contains several `metro` dependencies, which when removed from CLI will no longer require us to ship new CLI releases to get Metro patches and features to users.
- This package contains the `start`, `bundle`, and `ram-bundle` commands (central to the React Native development experience), for which we have incoming debugging-related changes.
- This package now **only** exports commands to be attached via a RN CLI plugin. With this move, we're aiming to **internalise** the default implementations of these dev commands within React Native — other RN CLI plugins can continue to override these, but must do so wholesale. (See also the recent fix for this: react-native-community/cli#1999.)
In V15:
- (Microsoft feedback) Re-export `unstable_buildBundleWithConfig`, marking as unstable. This gives us a time buffer to consider how we repackage this functionality in future.
The package source has been converted from TypeScript to Flow, with a number of new `flow-typed/` defs added to meet type coverage requirements.
## To dos
- For now, we aren't removing the existing [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) source — until later PRs consolidate this move by changing dependencies in the `react-native` package.
- **Exported API is reduced!**: I'm working with szymonrybczak to decouple references from RN CLI packages react-native-community/cli#2021.
Changelog: [Internal]
Reviewed By: motiz88
Differential Revision: D46801501
fbshipit-source-id: 7f6b72941a69f487fb437768cdba125a9aa3418d
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szymonrybczakszymonrybczakszymonrybczak approved these changes
@adamTrzadamTrzAwaiting requested review from adamTrz
@thymikeethymikeeAwaiting requested review from thymikeethymikee is a code owner
+2 more reviewers
@shadowspawnshadowspawnshadowspawn left review comments
@tido64tido64tido64 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@huntie@tido64@shadowspawn@szymonrybczak@thymikee
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
breaking: Fix ability to override commands via config by huntie · Pull Request #1999 · react-native-community/cli · GitHub
Skip to content
breaking: Fix ability to override commands via config - #1999
Merged
thymikee merged 1 commit into
react-native-community:mainfrom 
huntie:fix-plugin-system
Jul 18, 2023
Merged
breaking: Fix ability to override commands via config#1999
thymikee merged 1 commit into
react-native-community:mainfrom 
huntie:fix-plugin-system
Conversation
@huntie
@huntiehuntie
commented
Jul 5, 2023

Copy link


Copy Markdown

Collaborator
Summary
I noticed a non-obvious bug when attempting to use react-native.config.js to override commands (i.e. the plugin system) over the CLI's built-in defaults.
While the below printout shows the project-configured commands being successfully read after the internal commands, these are never applied — due to a bug in all versions of the commander library where commands are stored as an array structure where the first registered command with a given name is used (and silently failing upon re-registering a command later 😐).
image
Changelog:

[Breaking] Custom commands in react-native.config.js files in libraries or projects will now override built-in CLI commands if defined with the same command name
Test Plan
  • Set up more console.logs
  • Build
  • yarn link to local React Native project with extended config ⬇️
module.exports={commands: [
...ios.commands,
...android.commands,bundleCommand,ramBundleCommand,startCommand,],
image
✅ Command implementation for react-native start can be successfully overridden
cc @tido64 for any potential downstream impact on rnx-kit
tido64
tido64
reviewed
Jul 5, 2023
View reviewed changes
Comment threadpackages/cli/src/index.ts
Outdated

@huntie
huntieforce-pushed
the
fix-plugin-system
branch
from
889f00f to
6047aeeCompareJuly 5, 2023 10:43
@huntiehuntie
mentioned this pull request
Jul 6, 2023

Closed

shadowspawn
shadowspawn
reviewed
Jul 6, 2023
View reviewed changes
Comment threadpackages/cli/src/index.ts
Outdated

@huntie
huntieforce-pushed
the
fix-plugin-system
branch
from
6047aee to
f7d1176CompareJuly 7, 2023 15:22
@huntie
huntie
commented
Jul 17, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@tido64@thymikee Bump :)
tido64
tido64
approved these changes
Jul 17, 2023
View reviewed changes
@tido64tido64
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have my symbolic vote. 😄
szymonrybczak
szymonrybczak
approved these changes
Jul 18, 2023
View reviewed changes
@szymonrybczakszymonrybczak
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌
@thymikee
thymikee
merged commit ba362e6
into
react-native-community:mainJul 18, 2023
@huntie
huntie
deleted the

fix-plugin-system

branch
July 18, 2023 16:49
@huntiehuntie
mentioned this pull request
Aug 7, 2023
 Closed

facebook-github-bot pushed a commit
to react/react-native
that referenced
this pull request
Aug 10, 2023
@huntie@facebook-github-bot
Migrate cli-plugin-metro into repo (#38795)
e199880
Summary:
Pull Request resolved: #38795
## Context
RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641
## Changes
Inits new package `react-native/community-cli-plugin`. This migrates [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) into the React Native repo, to enable faster iteration by the React Native core team. Specifically:
- This package contains several `metro` dependencies, which when removed from CLI will no longer require us to ship new CLI releases to get Metro patches and features to users.
- This package contains the `start`, `bundle`, and `ram-bundle` commands (central to the React Native development experience), for which we have incoming debugging-related changes.
- This package now **only** exports commands to be attached via a RN CLI plugin. With this move, we're aiming to **internalise** the default implementations of these dev commands within React Native — other RN CLI plugins can continue to override these, but must do so wholesale. (See also the recent fix for this: react-native-community/cli#1999.)
In V15:
- (Microsoft feedback) Re-export `unstable_buildBundleWithConfig`, marking as unstable. This gives us a time buffer to consider how we repackage this functionality in future.
The package source has been converted from TypeScript to Flow, with a number of new `flow-typed/` defs added to meet type coverage requirements.
## To dos
- For now, we aren't removing the existing [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) source — until later PRs consolidate this move by changing dependencies in the `react-native` package.
- **Exported API is reduced!**: I'm working with szymonrybczak to decouple references from RN CLI packages react-native-community/cli#2021.
Changelog: [Internal]
Reviewed By: motiz88
Differential Revision: D46801501
fbshipit-source-id: 7f6b72941a69f487fb437768cdba125a9aa3418d
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@szymonrybczakszymonrybczakszymonrybczak approved these changes
@adamTrzadamTrzAwaiting requested review from adamTrz
@thymikeethymikeeAwaiting requested review from thymikeethymikee is a code owner

+2 more reviewers

@shadowspawnshadowspawnshadowspawn left review comments
@tido64tido64tido64 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

bugfix

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@huntie@tido64@shadowspawn@szymonrybczak@thymikee

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
breaking: Fix ability to override commands via config by huntie · Pull Request #1999 · react-native-community/cli · GitHub
Skip to content
breaking: Fix ability to override commands via config - #1999
Merged
thymikee merged 1 commit into
react-native-community:mainfrom 
huntie:fix-plugin-system
Jul 18, 2023
Merged
breaking: Fix ability to override commands via config#1999
thymikee merged 1 commit into
react-native-community:mainfrom 
huntie:fix-plugin-system
Conversation
@huntie
@huntiehuntie
commented
Jul 5, 2023

Copy link


Copy Markdown

Collaborator
Summary
I noticed a non-obvious bug when attempting to use react-native.config.js to override commands (i.e. the plugin system) over the CLI's built-in defaults.
While the below printout shows the project-configured commands being successfully read after the internal commands, these are never applied — due to a bug in all versions of the commander library where commands are stored as an array structure where the first registered command with a given name is used (and silently failing upon re-registering a command later 😐).
image
Changelog:

[Breaking] Custom commands in react-native.config.js files in libraries or projects will now override built-in CLI commands if defined with the same command name
Test Plan
  • Set up more console.logs
  • Build
  • yarn link to local React Native project with extended config ⬇️
module.exports={commands: [
...ios.commands,
...android.commands,bundleCommand,ramBundleCommand,startCommand,],
image
✅ Command implementation for react-native start can be successfully overridden
cc @tido64 for any potential downstream impact on rnx-kit
tido64
tido64
reviewed
Jul 5, 2023
View reviewed changes
Comment threadpackages/cli/src/index.ts
Outdated

@huntie
huntieforce-pushed
the
fix-plugin-system
branch
from
889f00f to
6047aeeCompareJuly 5, 2023 10:43
@huntiehuntie
mentioned this pull request
Jul 6, 2023

Closed

shadowspawn
shadowspawn
reviewed
Jul 6, 2023
View reviewed changes
Comment threadpackages/cli/src/index.ts
Outdated

@huntie
huntieforce-pushed
the
fix-plugin-system
branch
from
6047aee to
f7d1176CompareJuly 7, 2023 15:22
@huntie
huntie
commented
Jul 17, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@tido64@thymikee Bump :)
tido64
tido64
approved these changes
Jul 17, 2023
View reviewed changes
@tido64tido64
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have my symbolic vote. 😄
szymonrybczak
szymonrybczak
approved these changes
Jul 18, 2023
View reviewed changes
@szymonrybczakszymonrybczak
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌
@thymikee
thymikee
merged commit ba362e6
into
react-native-community:mainJul 18, 2023
@huntie
huntie
deleted the

fix-plugin-system

branch
July 18, 2023 16:49
@huntiehuntie
mentioned this pull request
Aug 7, 2023
 Closed

facebook-github-bot pushed a commit
to react/react-native
that referenced
this pull request
Aug 10, 2023
@huntie@facebook-github-bot
Migrate cli-plugin-metro into repo (#38795)
e199880
Summary:
Pull Request resolved: #38795
## Context
RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641
## Changes
Inits new package `react-native/community-cli-plugin`. This migrates [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) into the React Native repo, to enable faster iteration by the React Native core team. Specifically:
- This package contains several `metro` dependencies, which when removed from CLI will no longer require us to ship new CLI releases to get Metro patches and features to users.
- This package contains the `start`, `bundle`, and `ram-bundle` commands (central to the React Native development experience), for which we have incoming debugging-related changes.
- This package now **only** exports commands to be attached via a RN CLI plugin. With this move, we're aiming to **internalise** the default implementations of these dev commands within React Native — other RN CLI plugins can continue to override these, but must do so wholesale. (See also the recent fix for this: react-native-community/cli#1999.)
In V15:
- (Microsoft feedback) Re-export `unstable_buildBundleWithConfig`, marking as unstable. This gives us a time buffer to consider how we repackage this functionality in future.
The package source has been converted from TypeScript to Flow, with a number of new `flow-typed/` defs added to meet type coverage requirements.
## To dos
- For now, we aren't removing the existing [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) source — until later PRs consolidate this move by changing dependencies in the `react-native` package.
- **Exported API is reduced!**: I'm working with szymonrybczak to decouple references from RN CLI packages react-native-community/cli#2021.
Changelog: [Internal]
Reviewed By: motiz88
Differential Revision: D46801501
fbshipit-source-id: 7f6b72941a69f487fb437768cdba125a9aa3418d
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@szymonrybczakszymonrybczakszymonrybczak approved these changes
@adamTrzadamTrzAwaiting requested review from adamTrz
@thymikeethymikeeAwaiting requested review from thymikeethymikee is a code owner

+2 more reviewers

@shadowspawnshadowspawnshadowspawn left review comments
@tido64tido64tido64 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

bugfix

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@huntie@tido64@shadowspawn@szymonrybczak@thymikee

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
breaking: Fix ability to override commands via config by huntie · Pull Request #1999 · react-native-community/cli · GitHub
Skip to content
breaking: Fix ability to override commands via config - #1999
Merged
thymikee merged 1 commit into
react-native-community:mainfrom 
huntie:fix-plugin-system
Jul 18, 2023
Merged
breaking: Fix ability to override commands via config#1999
thymikee merged 1 commit into
react-native-community:mainfrom 
huntie:fix-plugin-system
Conversation
@huntie
@huntiehuntie
commented
Jul 5, 2023

Copy link


Copy Markdown

Collaborator
Summary
I noticed a non-obvious bug when attempting to use react-native.config.js to override commands (i.e. the plugin system) over the CLI's built-in defaults.
While the below printout shows the project-configured commands being successfully read after the internal commands, these are never applied — due to a bug in all versions of the commander library where commands are stored as an array structure where the first registered command with a given name is used (and silently failing upon re-registering a command later 😐).
image
Changelog:

[Breaking] Custom commands in react-native.config.js files in libraries or projects will now override built-in CLI commands if defined with the same command name
Test Plan
  • Set up more console.logs
  • Build
  • yarn link to local React Native project with extended config ⬇️
module.exports={commands: [
...ios.commands,
...android.commands,bundleCommand,ramBundleCommand,startCommand,],
image
✅ Command implementation for react-native start can be successfully overridden
cc @tido64 for any potential downstream impact on rnx-kit
tido64
tido64
reviewed
Jul 5, 2023
View reviewed changes
Comment threadpackages/cli/src/index.ts
Outdated

@huntie
huntieforce-pushed
the
fix-plugin-system
branch
from
889f00f to
6047aeeCompareJuly 5, 2023 10:43
@huntiehuntie
mentioned this pull request
Jul 6, 2023

Closed

shadowspawn
shadowspawn
reviewed
Jul 6, 2023
View reviewed changes
Comment threadpackages/cli/src/index.ts
Outdated

@huntie
huntieforce-pushed
the
fix-plugin-system
branch
from
6047aee to
f7d1176CompareJuly 7, 2023 15:22
@huntie
huntie
commented
Jul 17, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@tido64@thymikee Bump :)
tido64
tido64
approved these changes
Jul 17, 2023
View reviewed changes
@tido64tido64
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have my symbolic vote. 😄
szymonrybczak
szymonrybczak
approved these changes
Jul 18, 2023
View reviewed changes
@szymonrybczakszymonrybczak
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌
@thymikee
thymikee
merged commit ba362e6
into
react-native-community:mainJul 18, 2023
@huntie
huntie
deleted the

fix-plugin-system

branch
July 18, 2023 16:49
@huntiehuntie
mentioned this pull request
Aug 7, 2023
 Closed

facebook-github-bot pushed a commit
to react/react-native
that referenced
this pull request
Aug 10, 2023
@huntie@facebook-github-bot
Migrate cli-plugin-metro into repo (#38795)
e199880
Summary:
Pull Request resolved: #38795
## Context
RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641
## Changes
Inits new package `react-native/community-cli-plugin`. This migrates [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) into the React Native repo, to enable faster iteration by the React Native core team. Specifically:
- This package contains several `metro` dependencies, which when removed from CLI will no longer require us to ship new CLI releases to get Metro patches and features to users.
- This package contains the `start`, `bundle`, and `ram-bundle` commands (central to the React Native development experience), for which we have incoming debugging-related changes.
- This package now **only** exports commands to be attached via a RN CLI plugin. With this move, we're aiming to **internalise** the default implementations of these dev commands within React Native — other RN CLI plugins can continue to override these, but must do so wholesale. (See also the recent fix for this: react-native-community/cli#1999.)
In V15:
- (Microsoft feedback) Re-export `unstable_buildBundleWithConfig`, marking as unstable. This gives us a time buffer to consider how we repackage this functionality in future.
The package source has been converted from TypeScript to Flow, with a number of new `flow-typed/` defs added to meet type coverage requirements.
## To dos
- For now, we aren't removing the existing [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) source — until later PRs consolidate this move by changing dependencies in the `react-native` package.
- **Exported API is reduced!**: I'm working with szymonrybczak to decouple references from RN CLI packages react-native-community/cli#2021.
Changelog: [Internal]
Reviewed By: motiz88
Differential Revision: D46801501
fbshipit-source-id: 7f6b72941a69f487fb437768cdba125a9aa3418d
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@szymonrybczakszymonrybczakszymonrybczak approved these changes
@adamTrzadamTrzAwaiting requested review from adamTrz
@thymikeethymikeeAwaiting requested review from thymikeethymikee is a code owner

+2 more reviewers

@shadowspawnshadowspawnshadowspawn left review comments
@tido64tido64tido64 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

bugfix

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@huntie@tido64@shadowspawn@szymonrybczak@thymikee

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
breaking: Fix ability to override commands via config by huntie · Pull Request #1999 · react-native-community/cli · GitHub
Skip to content
breaking: Fix ability to override commands via config - #1999
Merged
thymikee merged 1 commit into
react-native-community:mainfrom 
huntie:fix-plugin-system
Jul 18, 2023
Merged
breaking: Fix ability to override commands via config#1999
thymikee merged 1 commit into
react-native-community:mainfrom 
huntie:fix-plugin-system
Conversation
@huntie
@huntiehuntie
commented
Jul 5, 2023

Copy link


Copy Markdown

Collaborator
Summary
I noticed a non-obvious bug when attempting to use react-native.config.js to override commands (i.e. the plugin system) over the CLI's built-in defaults.
While the below printout shows the project-configured commands being successfully read after the internal commands, these are never applied — due to a bug in all versions of the commander library where commands are stored as an array structure where the first registered command with a given name is used (and silently failing upon re-registering a command later 😐).
image
Changelog:

[Breaking] Custom commands in react-native.config.js files in libraries or projects will now override built-in CLI commands if defined with the same command name
Test Plan
  • Set up more console.logs
  • Build
  • yarn link to local React Native project with extended config ⬇️
module.exports={commands: [
...ios.commands,
...android.commands,bundleCommand,ramBundleCommand,startCommand,],
image
✅ Command implementation for react-native start can be successfully overridden
cc @tido64 for any potential downstream impact on rnx-kit
tido64
tido64
reviewed
Jul 5, 2023
View reviewed changes
Comment threadpackages/cli/src/index.ts
Outdated

@huntie
huntieforce-pushed
the
fix-plugin-system
branch
from
889f00f to
6047aeeCompareJuly 5, 2023 10:43
@huntiehuntie
mentioned this pull request
Jul 6, 2023

Closed

shadowspawn
shadowspawn
reviewed
Jul 6, 2023
View reviewed changes
Comment threadpackages/cli/src/index.ts
Outdated

@huntie
huntieforce-pushed
the
fix-plugin-system
branch
from
6047aee to
f7d1176CompareJuly 7, 2023 15:22
@huntie
huntie
commented
Jul 17, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@tido64@thymikee Bump :)
tido64
tido64
approved these changes
Jul 17, 2023
View reviewed changes
@tido64tido64
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have my symbolic vote. 😄
szymonrybczak
szymonrybczak
approved these changes
Jul 18, 2023
View reviewed changes
@szymonrybczakszymonrybczak
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌
@thymikee
thymikee
merged commit ba362e6
into
react-native-community:mainJul 18, 2023
@huntie
huntie
deleted the

fix-plugin-system

branch
July 18, 2023 16:49
@huntiehuntie
mentioned this pull request
Aug 7, 2023
 Closed

facebook-github-bot pushed a commit
to react/react-native
that referenced
this pull request
Aug 10, 2023
@huntie@facebook-github-bot
Migrate cli-plugin-metro into repo (#38795)
e199880
Summary:
Pull Request resolved: #38795
## Context
RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641
## Changes
Inits new package `react-native/community-cli-plugin`. This migrates [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) into the React Native repo, to enable faster iteration by the React Native core team. Specifically:
- This package contains several `metro` dependencies, which when removed from CLI will no longer require us to ship new CLI releases to get Metro patches and features to users.
- This package contains the `start`, `bundle`, and `ram-bundle` commands (central to the React Native development experience), for which we have incoming debugging-related changes.
- This package now **only** exports commands to be attached via a RN CLI plugin. With this move, we're aiming to **internalise** the default implementations of these dev commands within React Native — other RN CLI plugins can continue to override these, but must do so wholesale. (See also the recent fix for this: react-native-community/cli#1999.)
In V15:
- (Microsoft feedback) Re-export `unstable_buildBundleWithConfig`, marking as unstable. This gives us a time buffer to consider how we repackage this functionality in future.
The package source has been converted from TypeScript to Flow, with a number of new `flow-typed/` defs added to meet type coverage requirements.
## To dos
- For now, we aren't removing the existing [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) source — until later PRs consolidate this move by changing dependencies in the `react-native` package.
- **Exported API is reduced!**: I'm working with szymonrybczak to decouple references from RN CLI packages react-native-community/cli#2021.
Changelog: [Internal]
Reviewed By: motiz88
Differential Revision: D46801501
fbshipit-source-id: 7f6b72941a69f487fb437768cdba125a9aa3418d
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@szymonrybczakszymonrybczakszymonrybczak approved these changes
@adamTrzadamTrzAwaiting requested review from adamTrz
@thymikeethymikeeAwaiting requested review from thymikeethymikee is a code owner

+2 more reviewers

@shadowspawnshadowspawnshadowspawn left review comments
@tido64tido64tido64 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

bugfix

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@huntie@tido64@shadowspawn@szymonrybczak@thymikee

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
breaking: Fix ability to override commands via config by huntie · Pull Request #1999 · react-native-community/cli · GitHub
Skip to content
breaking: Fix ability to override commands via config - #1999
Merged
thymikee merged 1 commit into
react-native-community:mainfrom 
huntie:fix-plugin-system
Jul 18, 2023
Merged
breaking: Fix ability to override commands via config#1999
thymikee merged 1 commit into
react-native-community:mainfrom 
huntie:fix-plugin-system
Conversation
@huntie
@huntiehuntie
commented
Jul 5, 2023

Copy link


Copy Markdown

Collaborator
Summary
I noticed a non-obvious bug when attempting to use react-native.config.js to override commands (i.e. the plugin system) over the CLI's built-in defaults.
While the below printout shows the project-configured commands being successfully read after the internal commands, these are never applied — due to a bug in all versions of the commander library where commands are stored as an array structure where the first registered command with a given name is used (and silently failing upon re-registering a command later 😐).
image
Changelog:

[Breaking] Custom commands in react-native.config.js files in libraries or projects will now override built-in CLI commands if defined with the same command name
Test Plan
  • Set up more console.logs
  • Build
  • yarn link to local React Native project with extended config ⬇️
module.exports={commands: [
...ios.commands,
...android.commands,bundleCommand,ramBundleCommand,startCommand,],
image
✅ Command implementation for react-native start can be successfully overridden
cc @tido64 for any potential downstream impact on rnx-kit
tido64
tido64
reviewed
Jul 5, 2023
View reviewed changes
Comment threadpackages/cli/src/index.ts
Outdated

@huntie
huntieforce-pushed
the
fix-plugin-system
branch
from
889f00f to
6047aeeCompareJuly 5, 2023 10:43
@huntiehuntie
mentioned this pull request
Jul 6, 2023

Closed

shadowspawn
shadowspawn
reviewed
Jul 6, 2023
View reviewed changes
Comment threadpackages/cli/src/index.ts
Outdated

@huntie
huntieforce-pushed
the
fix-plugin-system
branch
from
6047aee to
f7d1176CompareJuly 7, 2023 15:22
@huntie
huntie
commented
Jul 17, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@tido64@thymikee Bump :)
tido64
tido64
approved these changes
Jul 17, 2023
View reviewed changes
@tido64tido64
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have my symbolic vote. 😄
szymonrybczak
szymonrybczak
approved these changes
Jul 18, 2023
View reviewed changes
@szymonrybczakszymonrybczak
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌
@thymikee
thymikee
merged commit ba362e6
into
react-native-community:mainJul 18, 2023
@huntie
huntie
deleted the

fix-plugin-system

branch
July 18, 2023 16:49
@huntiehuntie
mentioned this pull request
Aug 7, 2023
 Closed

facebook-github-bot pushed a commit
to react/react-native
that referenced
this pull request
Aug 10, 2023
@huntie@facebook-github-bot
Migrate cli-plugin-metro into repo (#38795)
e199880
Summary:
Pull Request resolved: #38795
## Context
RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641
## Changes
Inits new package `react-native/community-cli-plugin`. This migrates [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) into the React Native repo, to enable faster iteration by the React Native core team. Specifically:
- This package contains several `metro` dependencies, which when removed from CLI will no longer require us to ship new CLI releases to get Metro patches and features to users.
- This package contains the `start`, `bundle`, and `ram-bundle` commands (central to the React Native development experience), for which we have incoming debugging-related changes.
- This package now **only** exports commands to be attached via a RN CLI plugin. With this move, we're aiming to **internalise** the default implementations of these dev commands within React Native — other RN CLI plugins can continue to override these, but must do so wholesale. (See also the recent fix for this: react-native-community/cli#1999.)
In V15:
- (Microsoft feedback) Re-export `unstable_buildBundleWithConfig`, marking as unstable. This gives us a time buffer to consider how we repackage this functionality in future.
The package source has been converted from TypeScript to Flow, with a number of new `flow-typed/` defs added to meet type coverage requirements.
## To dos
- For now, we aren't removing the existing [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) source — until later PRs consolidate this move by changing dependencies in the `react-native` package.
- **Exported API is reduced!**: I'm working with szymonrybczak to decouple references from RN CLI packages react-native-community/cli#2021.
Changelog: [Internal]
Reviewed By: motiz88
Differential Revision: D46801501
fbshipit-source-id: 7f6b72941a69f487fb437768cdba125a9aa3418d
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@szymonrybczakszymonrybczakszymonrybczak approved these changes
@adamTrzadamTrzAwaiting requested review from adamTrz
@thymikeethymikeeAwaiting requested review from thymikeethymikee is a code owner

+2 more reviewers

@shadowspawnshadowspawnshadowspawn left review comments
@tido64tido64tido64 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

bugfix

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@huntie@tido64@shadowspawn@szymonrybczak@thymikee

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
breaking: Fix ability to override commands via config by huntie · Pull Request #1999 · react-native-community/cli · GitHub
Skip to content
breaking: Fix ability to override commands via config - #1999
Merged
thymikee merged 1 commit into
react-native-community:mainfrom 
huntie:fix-plugin-system
Jul 18, 2023
Merged
breaking: Fix ability to override commands via config#1999
thymikee merged 1 commit into
react-native-community:mainfrom 
huntie:fix-plugin-system
Conversation
@huntie
@huntiehuntie
commented
Jul 5, 2023

Copy link


Copy Markdown

Collaborator
Summary
I noticed a non-obvious bug when attempting to use react-native.config.js to override commands (i.e. the plugin system) over the CLI's built-in defaults.
While the below printout shows the project-configured commands being successfully read after the internal commands, these are never applied — due to a bug in all versions of the commander library where commands are stored as an array structure where the first registered command with a given name is used (and silently failing upon re-registering a command later 😐).
image
Changelog:

[Breaking] Custom commands in react-native.config.js files in libraries or projects will now override built-in CLI commands if defined with the same command name
Test Plan
  • Set up more console.logs
  • Build
  • yarn link to local React Native project with extended config ⬇️
module.exports={commands: [
...ios.commands,
...android.commands,bundleCommand,ramBundleCommand,startCommand,],
image
✅ Command implementation for react-native start can be successfully overridden
cc @tido64 for any potential downstream impact on rnx-kit
tido64
tido64
reviewed
Jul 5, 2023
View reviewed changes
Comment threadpackages/cli/src/index.ts
Outdated

@huntie
huntieforce-pushed
the
fix-plugin-system
branch
from
889f00f to
6047aeeCompareJuly 5, 2023 10:43
@huntiehuntie
mentioned this pull request
Jul 6, 2023

Closed

shadowspawn
shadowspawn
reviewed
Jul 6, 2023
View reviewed changes
Comment threadpackages/cli/src/index.ts
Outdated

@huntie
huntieforce-pushed
the
fix-plugin-system
branch
from
6047aee to
f7d1176CompareJuly 7, 2023 15:22
@huntie
huntie
commented
Jul 17, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@tido64@thymikee Bump :)
tido64
tido64
approved these changes
Jul 17, 2023
View reviewed changes
@tido64tido64
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have my symbolic vote. 😄
szymonrybczak
szymonrybczak
approved these changes
Jul 18, 2023
View reviewed changes
@szymonrybczakszymonrybczak
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌
@thymikee
thymikee
merged commit ba362e6
into
react-native-community:mainJul 18, 2023
@huntie
huntie
deleted the

fix-plugin-system

branch
July 18, 2023 16:49
@huntiehuntie
mentioned this pull request
Aug 7, 2023
 Closed

facebook-github-bot pushed a commit
to react/react-native
that referenced
this pull request
Aug 10, 2023
@huntie@facebook-github-bot
Migrate cli-plugin-metro into repo (#38795)
e199880
Summary:
Pull Request resolved: #38795
## Context
RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641
## Changes
Inits new package `react-native/community-cli-plugin`. This migrates [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) into the React Native repo, to enable faster iteration by the React Native core team. Specifically:
- This package contains several `metro` dependencies, which when removed from CLI will no longer require us to ship new CLI releases to get Metro patches and features to users.
- This package contains the `start`, `bundle`, and `ram-bundle` commands (central to the React Native development experience), for which we have incoming debugging-related changes.
- This package now **only** exports commands to be attached via a RN CLI plugin. With this move, we're aiming to **internalise** the default implementations of these dev commands within React Native — other RN CLI plugins can continue to override these, but must do so wholesale. (See also the recent fix for this: react-native-community/cli#1999.)
In V15:
- (Microsoft feedback) Re-export `unstable_buildBundleWithConfig`, marking as unstable. This gives us a time buffer to consider how we repackage this functionality in future.
The package source has been converted from TypeScript to Flow, with a number of new `flow-typed/` defs added to meet type coverage requirements.
## To dos
- For now, we aren't removing the existing [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) source — until later PRs consolidate this move by changing dependencies in the `react-native` package.
- **Exported API is reduced!**: I'm working with szymonrybczak to decouple references from RN CLI packages react-native-community/cli#2021.
Changelog: [Internal]
Reviewed By: motiz88
Differential Revision: D46801501
fbshipit-source-id: 7f6b72941a69f487fb437768cdba125a9aa3418d
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@szymonrybczakszymonrybczakszymonrybczak approved these changes
@adamTrzadamTrzAwaiting requested review from adamTrz
@thymikeethymikeeAwaiting requested review from thymikeethymikee is a code owner

+2 more reviewers

@shadowspawnshadowspawnshadowspawn left review comments
@tido64tido64tido64 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

bugfix

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@huntie@tido64@shadowspawn@szymonrybczak@thymikee

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
breaking: Fix ability to override commands via config by huntie · Pull Request #1999 · react-native-community/cli · GitHub
Skip to content
breaking: Fix ability to override commands via config - #1999
Merged
thymikee merged 1 commit into
react-native-community:mainfrom 
huntie:fix-plugin-system
Jul 18, 2023
Merged
breaking: Fix ability to override commands via config#1999
thymikee merged 1 commit into
react-native-community:mainfrom 
huntie:fix-plugin-system
Conversation
@huntie
@huntiehuntie
commented
Jul 5, 2023

Copy link


Copy Markdown

Collaborator
Summary
I noticed a non-obvious bug when attempting to use react-native.config.js to override commands (i.e. the plugin system) over the CLI's built-in defaults.
While the below printout shows the project-configured commands being successfully read after the internal commands, these are never applied — due to a bug in all versions of the commander library where commands are stored as an array structure where the first registered command with a given name is used (and silently failing upon re-registering a command later 😐).
image
Changelog:

[Breaking] Custom commands in react-native.config.js files in libraries or projects will now override built-in CLI commands if defined with the same command name
Test Plan
  • Set up more console.logs
  • Build
  • yarn link to local React Native project with extended config ⬇️
module.exports={commands: [
...ios.commands,
...android.commands,bundleCommand,ramBundleCommand,startCommand,],
image
✅ Command implementation for react-native start can be successfully overridden
cc @tido64 for any potential downstream impact on rnx-kit
tido64
tido64
reviewed
Jul 5, 2023
View reviewed changes
Comment threadpackages/cli/src/index.ts
Outdated

@huntie
huntieforce-pushed
the
fix-plugin-system
branch
from
889f00f to
6047aeeCompareJuly 5, 2023 10:43
@huntiehuntie
mentioned this pull request
Jul 6, 2023

Closed

shadowspawn
shadowspawn
reviewed
Jul 6, 2023
View reviewed changes
Comment threadpackages/cli/src/index.ts
Outdated

@huntie
huntieforce-pushed
the
fix-plugin-system
branch
from
6047aee to
f7d1176CompareJuly 7, 2023 15:22
@huntie
huntie
commented
Jul 17, 2023

Copy link


Copy Markdown

CollaboratorAuthor
@tido64@thymikee Bump :)
tido64
tido64
approved these changes
Jul 17, 2023
View reviewed changes
@tido64tido64
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have my symbolic vote. 😄
szymonrybczak
szymonrybczak
approved these changes
Jul 18, 2023
View reviewed changes
@szymonrybczakszymonrybczak
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌
@thymikee
thymikee
merged commit ba362e6
into
react-native-community:mainJul 18, 2023
@huntie
huntie
deleted the

fix-plugin-system

branch
July 18, 2023 16:49
@huntiehuntie
mentioned this pull request
Aug 7, 2023
 Closed

facebook-github-bot pushed a commit
to react/react-native
that referenced
this pull request
Aug 10, 2023
@huntie@facebook-github-bot
Migrate cli-plugin-metro into repo (#38795)
e199880
Summary:
Pull Request resolved: #38795
## Context
RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641
## Changes
Inits new package `react-native/community-cli-plugin`. This migrates [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) into the React Native repo, to enable faster iteration by the React Native core team. Specifically:
- This package contains several `metro` dependencies, which when removed from CLI will no longer require us to ship new CLI releases to get Metro patches and features to users.
- This package contains the `start`, `bundle`, and `ram-bundle` commands (central to the React Native development experience), for which we have incoming debugging-related changes.
- This package now **only** exports commands to be attached via a RN CLI plugin. With this move, we're aiming to **internalise** the default implementations of these dev commands within React Native — other RN CLI plugins can continue to override these, but must do so wholesale. (See also the recent fix for this: react-native-community/cli#1999.)
In V15:
- (Microsoft feedback) Re-export `unstable_buildBundleWithConfig`, marking as unstable. This gives us a time buffer to consider how we repackage this functionality in future.
The package source has been converted from TypeScript to Flow, with a number of new `flow-typed/` defs added to meet type coverage requirements.
## To dos
- For now, we aren't removing the existing [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) source — until later PRs consolidate this move by changing dependencies in the `react-native` package.
- **Exported API is reduced!**: I'm working with szymonrybczak to decouple references from RN CLI packages react-native-community/cli#2021.
Changelog: [Internal]
Reviewed By: motiz88
Differential Revision: D46801501
fbshipit-source-id: 7f6b72941a69f487fb437768cdba125a9aa3418d
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@szymonrybczakszymonrybczakszymonrybczak approved these changes
@adamTrzadamTrzAwaiting requested review from adamTrz
@thymikeethymikeeAwaiting requested review from thymikeethymikee is a code owner

+2 more reviewers

@shadowspawnshadowspawnshadowspawn left review comments
@tido64tido64tido64 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

bugfix

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@huntie@tido64@shadowspawn@szymonrybczak@thymikee