Skip to content

fix(perf): ignore Pods and Hermes files when looking for AndroidManifest - #2014

Merged
thymikee merged 1 commit into
react-native-community:mainfrom
szymonrybczak:fix/add-paths-to-ignore-in-glob
Jul 11, 2023
Merged

fix(perf): ignore Pods and Hermes files when looking for AndroidManifest#2014
thymikee merged 1 commit into
react-native-community:mainfrom
szymonrybczak:fix/add-paths-to-ignore-in-glob

Conversation

@szymonrybczak

@szymonrybczakszymonrybczak commented Jul 11, 2023

Copy link
Copy Markdown
Collaborator

Summary:

Fixes#2012

It looks that the glob package was looking in wrong directories in my case (I tested this in RNTester on main). One thing that is interesting, before RN moved to monorepo the glob was finding AndroidManifest.xml immediately, but after RN moved fully to the monorepo, glob is looking into packages, which takes some time. But I think this change will make it enough fast.

Before this change:

0.710.72
CleanShot 2023-07-11 at 17 27 18@2xCleanShot 2023-07-11 at 17 28 51@2x

After this change:

0.710.72
CleanShot 2023-07-11 at 17 28 01@2xCleanShot 2023-07-11 at 17 30 34@2x

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-android

The first two logs:

info JS server already running.
info Installing the app...

should appear fast.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@thymikee

Copy link
Copy Markdown
Member

Mind adding a bit of context to the description? :)

@szymonrybczak

Copy link
Copy Markdown
CollaboratorAuthor

Mind adding a bit of context to the description? :)

Done ✅

@thymikeethymikee changed the title fix: add paths to ignore in globfix(perf): ignore Pods and Hermes files when looking for AndroidManifestJul 11, 2023
@thymikee
thymikee merged commit 151239f into react-native-community:mainJul 11, 2023
thymikee pushed a commit that referenced this pull request Jul 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI has a big delay in starting Android apps in newer versions of React Native

2 participants

@szymonrybczak@thymikee