fix: does not override user-defined reporter

[zhiqingchen]

Summary:

closes#2020

User-defined reporter on the current implementation will definitely be overridden.

Reimplemented eventsSocketEndpoint.reportEvent. If the customLogReporterPath does not exist, the reporter is not overwritten and only the update method of the reporter is modified.

Also modified some type definitions.

Test Plan:

• If I customize the reporter, the corresponding method will be called normally

const{getDefaultConfig, mergeConfig}=require('@react-native/metro-config');/** * Metro configuration * https://facebook.github.io/metro/docs/configuration * * @type {import('metro-config').MetroConfig} */constconfig={reporter: {update: (event)=>{console.log(1,event);},},};module.exports=mergeConfig(getDefaultConfig(__dirname),config);

• eventsSocketEndpoint.reportEvent(event) called as before.
• customLogReporterPath as effective as before.

Checklist

• Documentation is up to date to reflect these changes.
• Follows commit message convention described in CONTRIBUTING.md

[huntie]

Awesome PR 💯 Thanks! :)

[szymonrybczak]

Thank you! 🙌

[zhiqingchen]

hey @szymonrybczak , I would like to know how long this pr will be merge?

[szymonrybczak]

Hey @zhiqingchen, it'll be merged probably in the next week. But released probably in few months with 0.73. I would suggest you to use patch-package for now.

[zhiqingchen]

thanks @szymonrybczak

[zhiqingchen]

Summary:

closes#2020

User-defined reporter on the current implementation will definitely be overridden.

Reimplemented eventsSocketEndpoint.reportEvent. If the customLogReporterPath does not exist, the reporter is not overwritten and only the update method of the reporter is modified.

Also modified some type definitions.

Test Plan:

• If I customize the reporter, the corresponding method will be called normally

const{getDefaultConfig, mergeConfig}=require('@react-native/metro-config');/** * Metro configuration * https://facebook.github.io/metro/docs/configuration * * @type {import('metro-config').MetroConfig} */constconfig={reporter: {update: (event)=>{console.log(1,event);},},};module.exports=mergeConfig(getDefaultConfig(__dirname),config);

• eventsSocketEndpoint.reportEvent(event) called as before.
• customLogReporterPath as effective as before.

Checklist

• Documentation is up to date to reflect these changes.
• Follows commit message convention described in CONTRIBUTING.md

[huntie]

Awesome PR 💯 Thanks! :)

[szymonrybczak]

Thank you! 🙌

[zhiqingchen]

hey @szymonrybczak , I would like to know how long this pr will be merge?

[szymonrybczak]

Hey @zhiqingchen, it'll be merged probably in the next week. But released probably in few months with 0.73. I would suggest you to use patch-package for now.

[zhiqingchen]

thanks @szymonrybczak

[zhiqingchen]

Summary:

closes#2020

User-defined reporter on the current implementation will definitely be overridden.

Reimplemented eventsSocketEndpoint.reportEvent. If the customLogReporterPath does not exist, the reporter is not overwritten and only the update method of the reporter is modified.

Also modified some type definitions.

Test Plan:

• If I customize the reporter, the corresponding method will be called normally

const{getDefaultConfig, mergeConfig}=require('@react-native/metro-config');/** * Metro configuration * https://facebook.github.io/metro/docs/configuration * * @type {import('metro-config').MetroConfig} */constconfig={reporter: {update: (event)=>{console.log(1,event);},},};module.exports=mergeConfig(getDefaultConfig(__dirname),config);

• eventsSocketEndpoint.reportEvent(event) called as before.
• customLogReporterPath as effective as before.

Checklist

• Documentation is up to date to reflect these changes.
• Follows commit message convention described in CONTRIBUTING.md

[huntie]

Awesome PR 💯 Thanks! :)

[szymonrybczak]

Thank you! 🙌

[zhiqingchen]

hey @szymonrybczak , I would like to know how long this pr will be merge?

[szymonrybczak]

Hey @zhiqingchen, it'll be merged probably in the next week. But released probably in few months with 0.73. I would suggest you to use patch-package for now.

[zhiqingchen]

thanks @szymonrybczak

[zhiqingchen]

Summary:

closes#2020

User-defined reporter on the current implementation will definitely be overridden.

Reimplemented eventsSocketEndpoint.reportEvent. If the customLogReporterPath does not exist, the reporter is not overwritten and only the update method of the reporter is modified.

Also modified some type definitions.

Test Plan:

• If I customize the reporter, the corresponding method will be called normally

const{getDefaultConfig, mergeConfig}=require('@react-native/metro-config');/** * Metro configuration * https://facebook.github.io/metro/docs/configuration * * @type {import('metro-config').MetroConfig} */constconfig={reporter: {update: (event)=>{console.log(1,event);},},};module.exports=mergeConfig(getDefaultConfig(__dirname),config);

• eventsSocketEndpoint.reportEvent(event) called as before.
• customLogReporterPath as effective as before.

Checklist

• Documentation is up to date to reflect these changes.
• Follows commit message convention described in CONTRIBUTING.md

[huntie]

Awesome PR 💯 Thanks! :)

[szymonrybczak]

Thank you! 🙌

[zhiqingchen]

hey @szymonrybczak , I would like to know how long this pr will be merge?

[szymonrybczak]

Hey @zhiqingchen, it'll be merged probably in the next week. But released probably in few months with 0.73. I would suggest you to use patch-package for now.

[zhiqingchen]

thanks @szymonrybczak

[zhiqingchen]

Summary:

closes#2020

User-defined reporter on the current implementation will definitely be overridden.

Reimplemented eventsSocketEndpoint.reportEvent. If the customLogReporterPath does not exist, the reporter is not overwritten and only the update method of the reporter is modified.

Also modified some type definitions.

Test Plan:

• If I customize the reporter, the corresponding method will be called normally

const{getDefaultConfig, mergeConfig}=require('@react-native/metro-config');/** * Metro configuration * https://facebook.github.io/metro/docs/configuration * * @type {import('metro-config').MetroConfig} */constconfig={reporter: {update: (event)=>{console.log(1,event);},},};module.exports=mergeConfig(getDefaultConfig(__dirname),config);

• eventsSocketEndpoint.reportEvent(event) called as before.
• customLogReporterPath as effective as before.

Checklist

• Documentation is up to date to reflect these changes.
• Follows commit message convention described in CONTRIBUTING.md

[huntie]

Awesome PR 💯 Thanks! :)

[szymonrybczak]

Thank you! 🙌

[zhiqingchen]

hey @szymonrybczak , I would like to know how long this pr will be merge?

[szymonrybczak]

Hey @zhiqingchen, it'll be merged probably in the next week. But released probably in few months with 0.73. I would suggest you to use patch-package for now.

[zhiqingchen]

thanks @szymonrybczak

[zhiqingchen]

Summary:

closes#2020

User-defined reporter on the current implementation will definitely be overridden.

Reimplemented eventsSocketEndpoint.reportEvent. If the customLogReporterPath does not exist, the reporter is not overwritten and only the update method of the reporter is modified.

Also modified some type definitions.

Test Plan:

• If I customize the reporter, the corresponding method will be called normally

const{getDefaultConfig, mergeConfig}=require('@react-native/metro-config');/** * Metro configuration * https://facebook.github.io/metro/docs/configuration * * @type {import('metro-config').MetroConfig} */constconfig={reporter: {update: (event)=>{console.log(1,event);},},};module.exports=mergeConfig(getDefaultConfig(__dirname),config);

• eventsSocketEndpoint.reportEvent(event) called as before.
• customLogReporterPath as effective as before.

Checklist

• Documentation is up to date to reflect these changes.
• Follows commit message convention described in CONTRIBUTING.md

[huntie]

Awesome PR 💯 Thanks! :)

[szymonrybczak]

Thank you! 🙌

[zhiqingchen]

hey @szymonrybczak , I would like to know how long this pr will be merge?

[szymonrybczak]

Hey @zhiqingchen, it'll be merged probably in the next week. But released probably in few months with 0.73. I would suggest you to use patch-package for now.

[zhiqingchen]

thanks @szymonrybczak

[zhiqingchen]

Summary:

closes#2020

User-defined reporter on the current implementation will definitely be overridden.

Reimplemented eventsSocketEndpoint.reportEvent. If the customLogReporterPath does not exist, the reporter is not overwritten and only the update method of the reporter is modified.

Also modified some type definitions.

Test Plan:

• If I customize the reporter, the corresponding method will be called normally

const{getDefaultConfig, mergeConfig}=require('@react-native/metro-config');/** * Metro configuration * https://facebook.github.io/metro/docs/configuration * * @type {import('metro-config').MetroConfig} */constconfig={reporter: {update: (event)=>{console.log(1,event);},},};module.exports=mergeConfig(getDefaultConfig(__dirname),config);

• eventsSocketEndpoint.reportEvent(event) called as before.
• customLogReporterPath as effective as before.

Checklist

• Documentation is up to date to reflect these changes.
• Follows commit message convention described in CONTRIBUTING.md

[huntie]

Awesome PR 💯 Thanks! :)

[szymonrybczak]

Thank you! 🙌

[zhiqingchen]

hey @szymonrybczak , I would like to know how long this pr will be merge?

[szymonrybczak]

Hey @zhiqingchen, it'll be merged probably in the next week. But released probably in few months with 0.73. I would suggest you to use patch-package for now.

[zhiqingchen]

thanks @szymonrybczak

[zhiqingchen]

Summary:

closes#2020

User-defined reporter on the current implementation will definitely be overridden.

Reimplemented eventsSocketEndpoint.reportEvent. If the customLogReporterPath does not exist, the reporter is not overwritten and only the update method of the reporter is modified.

Also modified some type definitions.

Test Plan:

• If I customize the reporter, the corresponding method will be called normally

const{getDefaultConfig, mergeConfig}=require('@react-native/metro-config');/** * Metro configuration * https://facebook.github.io/metro/docs/configuration * * @type {import('metro-config').MetroConfig} */constconfig={reporter: {update: (event)=>{console.log(1,event);},},};module.exports=mergeConfig(getDefaultConfig(__dirname),config);

• eventsSocketEndpoint.reportEvent(event) called as before.
• customLogReporterPath as effective as before.

Checklist

• Documentation is up to date to reflect these changes.
• Follows commit message convention described in CONTRIBUTING.md

[huntie]

Awesome PR 💯 Thanks! :)

[szymonrybczak]

Thank you! 🙌

[zhiqingchen]

hey @szymonrybczak , I would like to know how long this pr will be merge?

[szymonrybczak]

Hey @zhiqingchen, it'll be merged probably in the next week. But released probably in few months with 0.73. I would suggest you to use patch-package for now.

[zhiqingchen]

thanks @szymonrybczak