Uh oh!
There was an error while loading. Please reload this page.
feat: opt-in pod install with ios commands - #2116
Merged
TMisiukiewicz merged 10 commits intoOct 31, 2023
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tido64
reviewed
Oct 13, 2023
tido64
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this ❤️
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Oct 13, 2023
TMisiukiewiczforce-pushed
the
feat/opt-in-pod-install
branch
from
October 16, 2023 07:43
9865045 to
d2336a8Comparetido64
approved these changes
Oct 16, 2023
Uh oh!
There was an error while loading. Please reload this page.
TMisiukiewiczforce-pushed
the
feat/opt-in-pod-install
branch
from
October 23, 2023 07:32
462ac6a to
98991d2Comparetido64
reviewed
Oct 23, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
TMisiukiewiczforce-pushed
the
feat/opt-in-pod-install
branch
from
October 23, 2023 12:30
98991d2 to
7c0fc7dCompareadamTrz
approved these changes
Oct 24, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
TMisiukiewiczforce-pushed
the
feat/opt-in-pod-install
branch
from
October 30, 2023 14:06
0fd861d to
7c163ffComparethymikee
approved these changes
Oct 30, 2023
TMisiukiewiczforce-pushed
the
feat/opt-in-pod-install
branch
from
October 31, 2023 11:21
57a47c3 to
453b07dCompareTMisiukiewiczforce-pushed
the
feat/opt-in-pod-install
branch
from
October 31, 2023 14:51
453b07d to
3f1ffcfCompare3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adding new config parameter
project.ios.automaticPodsInstallation.For existing apps, it means developers can opt-in for automatic CocoaPods installation when running
run-iosorbuild-ios. Some projects are running on non-standard setups or pods installation is simply not desired.For the users using
initcommand starting from 0.73, it will automatically create thereact-native.config.jsfile with this param set totrue. File is created by CLI after processing the template.Test Plan:
npx react-native initrun-iosand make sure CocoaPods step is skippedreact-native.config.jsfile and setproject.ios.automaticPodsInstallationtotruerun-iosagain and confirm that CocoaPods are getting installednode ./path/to/cli initnreact-native.config.jsfile existsrun-iosand verify pods are getting installedChecklist