feat: use Yarn v3 with `nodeLinker: node-modules` for new projects by szymonrybczak · Pull Request #2134 · react-native-community/cli

szymonrybczak · 2023-10-26T18:06:35Z

Summary:

Closes#1931

When creating new project we'll try to bump Yarn version to v3. We'll only do this if:

the project is initialised in fresh environment (not in existing Git repo),
~~and the Yarn version in the location is Yarn Classic~~bc8aaaa

Test Plan:

Clone the repository and do all the required steps from the Contributing guide
Run this command:

node /path/to/react-native-cli/packages/cli/build/bin.js init

Should use Yarn v3 🎉

Checklist

Documentation is up to date to reflect these changes.
Follows commit message convention described in CONTRIBUTING.md

szymonrybczak · 2023-10-26T18:07:25Z

@tido64 @satya164 I would really appreciate your review 🙏

szymonrybczak · 2023-10-26T18:39:32Z

One note here is that Yarn v4 was released few days ago, and it is working with React Native properly. With this change we're aiming for 0.74 so until that time it will be tested well in various production environments. Also Yarn v4 had 53 releases so we can assume that team tested it well 😅 So let''s wait for some minor fixes that probably will be released, and then will finally bump to Yarn v4 in CLI - with current setup it is just changing number.

tido64

LGTM

robhogan

Couple of questions/suggestions but LGTM in principle

robhogan · 2023-10-30T16:40:57Z

+ await executeCommand('yarn', ['set', 'version', YARN_VERSION], {
+ root,
+ silent,
+ });


Just to check my understanding here - this will install the requested version via corepack if it isn't currently on the machine? What if corepack isn't enabled?

Esemesek

Seems to be working fine on my machine. Code also seems to be LGTMT +1

Summary: Recently inside React Native Community CLI we added bumping Yarn version inside `init` command, more information here: react-native-community/cli#2134. In this Pull Request I added required rules in `.gitignore` for new projects created. ## Changelog: [GENERAL] [ADDED] - Add Yarn files to `.gitignore` in template Pull Request resolved: #42313 Test Plan: 1. Follow [Contributing guide](https://github.com/react-native-community/cli/blob/main/CONTRIBUTING.md) from React Native Community CLI repository to setup locally newest version of CLI. 2. Run this command: ```sh node /path/to/react-native-cli/packages/cli/build/bin.js init --template path/to/template ``` 3. Appropriate should be ignored. Reviewed By: NickGerleman Differential Revision: D52907962 Pulled By: cortinico fbshipit-source-id: f12dce8836e7e94257f8c690434b11227aa46446

Summary: Recently inside React Native Community CLI we added bumping Yarn version inside `init` command, more information here: react-native-community/cli#2134. In this Pull Request I added required rules in `.gitignore` for new projects created. ## Changelog: [GENERAL] [ADDED] - Add Yarn files to `.gitignore` in template Pull Request resolved: react/react-native#42313 Test Plan: 1. Follow [Contributing guide](https://github.com/react-native-community/cli/blob/main/CONTRIBUTING.md) from React Native Community CLI repository to setup locally newest version of CLI. 2. Run this command: ```sh node /path/to/react-native-cli/packages/cli/build/bin.js init --template path/to/template ``` 3. Appropriate should be ignored. Reviewed By: NickGerleman Differential Revision: D52907962 Pulled By: cortinico fbshipit-source-id: f12dce8836e7e94257f8c690434b11227aa46446 Original: react/react-native@965f2eb

Summary: Recently inside React Native Community CLI we added bumping Yarn version inside `init` command, more information here: react-native-community/cli#2134. In this Pull Request I added required rules in `.gitignore` for new projects created. ## Changelog: [GENERAL] [ADDED] - Add Yarn files to `.gitignore` in template Pull Request resolved: react/react-native#42313 Test Plan: 1. Follow [Contributing guide](https://github.com/react-native-community/cli/blob/main/CONTRIBUTING.md) from React Native Community CLI repository to setup locally newest version of CLI. 2. Run this command: ```sh node /path/to/react-native-cli/packages/cli/build/bin.js init --template path/to/template ``` 3. Appropriate should be ignored. Reviewed By: NickGerleman Differential Revision: D52907962 Pulled By: cortinico fbshipit-source-id: f12dce8836e7e94257f8c690434b11227aa46446 Original-Commit: react/react-native@965f2eb

noway · 2024-04-22T18:53:05Z

Sorry if this is not the right forum or if this is too much of a qualitative judgement, but I'd like to share my thoughts.

Yarn Modern is less popular than Yarn Classic. While Yarn Classic is deprecated (and to be fair, subtly broken in different ways), Yarn Modern hasn't shown enough resiliency and it's long term success is far from guaranteed.

Forcing new projects to start with Yarn v3 may send them on a path where they may end up with an unmaintained package manager few years down the track.

Is it a prudent decision to switch new projects to Yarn Modern, especially for users who are just starting out with React Native? NPM would be a much sure choice.

szymonrybczak requested review from adamTrz and thymikee as code owners October 26, 2023 18:06

github-actionsBot added the feature label Oct 26, 2023

szymonrybczak force-pushed the feat/use-yarn-3-in-init branch 2 times, most recently from 9afaa54 to 4457c77Compare October 26, 2023 18:38

szymonrybczak force-pushed the feat/use-yarn-3-in-init branch 2 times, most recently from c3bbbb5 to b9fb423Compare October 26, 2023 20:10

szymonrybczak commented Oct 26, 2023
View reviewed changes

Comment threadpackages/cli/src/tools/packageManager.ts Outdated

tido64 approved these changes Oct 27, 2023
View reviewed changes

szymonrybczak force-pushed the feat/use-yarn-3-in-init branch from 71f3dce to a04a792Compare October 27, 2023 07:15

szymonrybczak mentioned this pull request Oct 30, 2023
feat: create git repository in init command #2088
Merged
2 tasks

robhogan reviewed Oct 30, 2023
View reviewed changes

szymonrybczak force-pushed the feat/use-yarn-3-in-init branch 2 times, most recently from a8af0aa to 1b47345Compare November 2, 2023 09:24

satya164 requested changes Nov 4, 2023
View reviewed changes

Comment threadpackages/cli/src/commands/init/init.ts
Comment threadpackages/cli/src/commands/init/init.ts Outdated

szymonrybczak force-pushed the feat/use-yarn-3-in-init branch 3 times, most recently from 667da6d to bc0dc7dCompare November 6, 2023 21:12

satya164 approved these changes Nov 6, 2023
View reviewed changes

Esemesek approved these changes Dec 6, 2023
View reviewed changes

szymonrybczak force-pushed the feat/use-yarn-3-in-init branch from 86ccccf to 8f96a0eCompare December 18, 2023 20:30

szymonrybczak added 7 commits January 2, 2024 18:16

feat: use Yarn v3 when creating new project
d52857d

fix(ci): use YARN_ENABLE_IMMUTABLE_INSTALLS when installing packages
2554f20

feat: add to config nmHoistingLimits: workspaces
d4fdf35

chore: add more context on why we should specify explicit version
785af20

feat: skip bumping yarn version if project is inside git work tree
b7d6c80

fix: remove condition for yarn classic when bumping version
5624722

fix(e2e): update yarn specific files
fac59f2

szymonrybczak force-pushed the feat/use-yarn-3-in-init branch from 8f96a0e to fac59f2Compare January 2, 2024 17:17

thymikee merged commit f22be6d into mainJan 3, 2024

thymikee deleted the feat/use-yarn-3-in-init branch January 3, 2024 15:21

szymonrybczak mentioned this pull request Jan 9, 2024
fix(cli): initialising in projects using Yarn v3 microsoft/react-native-macos#2025
Merged
4 tasks

szymonrybczak mentioned this pull request Jan 16, 2024
feat(template): add Yarn files to .gitignorereact/react-native#42313
Closed

huntie mentioned this pull request Jan 22, 2024
Bump CLI to 13.5.1 react/react-native#42183
Closed

blakef mentioned this pull request Mar 18, 2024
fix: init uses yarn assuming version > 1.x #2329
Merged
2 tasks

Navigation Menu

Uh oh!

feat: use Yarn v3 with `nodeLinker: node-modules` for new projects - #2134

feat: use Yarn v3 with `nodeLinker: node-modules` for new projects#2134
thymikee merged 7 commits into
mainfrom
feat/use-yarn-3-in-init

szymonrybczak commented Oct 26, 2023•
edited
Loading

Uh oh!

szymonrybczak commented Oct 26, 2023

Uh oh!

szymonrybczak commented Oct 26, 2023

Uh oh!

Uh oh!

tido64 left a comment

Uh oh!

robhogan left a comment

Uh oh!

Uh oh!

Uh oh!

robhoganOct 30, 2023

Uh oh!

Uh oh!

Uh oh!

Esemesek left a comment

Uh oh!

noway commented Apr 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

szymonrybczak commented Oct 26, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Test Plan:

Checklist

Uh oh!

szymonrybczak commented Oct 26, 2023

Uh oh!

szymonrybczak commented Oct 26, 2023

Uh oh!

Uh oh!

tido64 left a comment

Choose a reason for hiding this comment

Uh oh!

robhogan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

robhoganOct 30, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Esemesek left a comment

Choose a reason for hiding this comment

Uh oh!

noway commented Apr 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

szymonrybczak commented Oct 26, 2023•
edited
Loading