Skip to content

fix: force users to use nodeLinker: node-modules when installing template packages - #2135

Merged
thymikee merged 1 commit into
mainfrom
feat/force-users-to-use-node-linker
Oct 31, 2023
Merged

fix: force users to use nodeLinker: node-modules when installing template packages#2135
thymikee merged 1 commit into
mainfrom
feat/force-users-to-use-node-linker

Conversation

@szymonrybczak

Copy link
Copy Markdown
Collaborator

Summary:

Fixes#1637

We need to be sure that node_modules directory exists, because then we're getting template from it. I tested and that command works in v1, v2, v3.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@szymonrybczak
szymonrybczakforce-pushed the feat/force-users-to-use-node-linker branch 2 times, most recently from e3317db to 080ef01CompareOctober 26, 2023 20:50
@szymonrybczak
szymonrybczakforce-pushed the feat/force-users-to-use-node-linker branch from 080ef01 to 17ea79cCompareOctober 30, 2023 15:23
@thymikeethymikee changed the title feat: force users to use nodeLinker: node-modules when installing template packagesfix: force users to use nodeLinker: node-modules when installing template packagesOct 31, 2023
@thymikee
thymikee merged commit f433381 into mainOct 31, 2023
@thymikee
thymikee deleted the feat/force-users-to-use-node-linker branch October 31, 2023 15:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Couldn't find template.config.js file inside "react-native" template. Please make sure the template is valid

2 participants

@szymonrybczak@thymikee