Skip to content

feat: adapt buildRun to properly open macOS apps - #2232

Merged
thymikee merged 5 commits into
mainfrom
feat/adapt-builder-to-launch-macos-app
Jan 8, 2024
Merged

feat: adapt buildRun to properly open macOS apps#2232
thymikee merged 5 commits into
mainfrom
feat/adapt-builder-to-launch-macos-app

Conversation

@szymonrybczak

@szymonrybczakszymonrybczak commented Dec 22, 2023

Copy link
Copy Markdown
Collaborator

Summary:

Related: #2217

Adapts buildRun function to properly open macOS apps. If the platform is macos, we're executing this command to start app:

❯ open "/path/to/app"

This PR will allows us to seamlessly remove local-cli from react-native-macos and replace it with the this implementation.

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-ios

Should work the same

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

Comment threadpackages/cli-platform-apple/src/commands/runCommand/createRun.ts Outdated
Comment threadpackages/cli-platform-apple/src/commands/runCommand/installApp.ts Outdated
Comment threadpackages/cli-platform-apple/src/commands/runCommand/getBuildPath.ts Outdated
Comment threadpackages/cli-platform-apple/src/commands/runCommand/getBuildPath.ts Outdated
Comment threadpackages/cli-platform-apple/src/commands/runCommand/installApp.ts Outdated
@thymikee

Copy link
Copy Markdown
Member

@szymonrybczak can you please rebase now that installing in opening are split?

@szymonrybczak
szymonrybczakforce-pushed the feat/adapt-builder-to-launch-macos-app branch from 22a770b to 800b5bcCompareJanuary 7, 2024 12:56
@szymonrybczak

Copy link
Copy Markdown
CollaboratorAuthor

E2E tests are failing due to the problem with boost pod, more context: react/react-native#42109. As for now there's a workaround with adding patch, but we cannot do it here, since we're creating new project.

Comment threadpackages/cli-platform-apple/src/commands/runCommand/openApp.ts Outdated
@thymikee
thymikee merged commit d864bc0 into mainJan 8, 2024
@thymikee
thymikee deleted the feat/adapt-builder-to-launch-macos-app branch January 8, 2024 12:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@szymonrybczak@thymikee@tido64@cipolleschi@okwasniewski