Uh oh!
There was an error while loading. Please reload this page.
feat: add support for react-native.config.ts - #2343
Merged
Merged
Conversation
szymonrybczak
commented
Mar 25, 2024
CollaboratorAuthor
I think we should export import{Config}from'@react-native-community/cli';constconfig: Config={commands: [{name: 'hello ',func: ()=>{console.log('hello');},},],};exportdefaultconfig;Right now it's exported through |
szymonrybczakforce-pushed
the
feat/add-support-for-react-native-config-ts
branch
from
March 25, 2024 09:46
3432ae2 to
493c8c7Comparethymikee
commented
Mar 25, 2024
Member
Let's add an e2e test that verifies a TS file is read |
szymonrybczak
marked this pull request as ready for review
March 28, 2024 15:45
szymonrybczakforce-pushed
the
feat/add-support-for-react-native-config-ts
branch
from
March 28, 2024 16:01
adb5c53 to
8221b51Compareszymonrybczak
commented
Apr 4, 2024
CollaboratorAuthor
Tests landed ✅ might giving review again? |
thymikee
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Closes#2253
Test Plan:
react-native.config.tswith some config.react-native.config.tsshould be visible inside command's output.Checklist