Uh oh!
There was an error while loading. Please reload this page.
fix(doctor): update Android Studio detection path on Windows - #2430
Merged
Conversation
szymonrybczakforce-pushed
the
fix/windows/detect-android-studio
branch
from
June 24, 2024 19:06
b17d969 to
0b20f0aComparethymikee
commented
Jun 27, 2024
Member
Is this some recent change or was always like that? |
szymonrybczak
commented
Jun 27, 2024
CollaboratorAuthor
Probably always, since we already have in the codebase executables names with architecture, as I've mentioned inside Pull Request description. |
Uh oh!
There was an error while loading. Please reload this page.
szymonrybczakforce-pushed
the
fix/windows/detect-android-studio
branch
from
June 27, 2024 10:50
31eb0f0 to
e9d7a07Comparethymikee
approved these changes
Jun 27, 2024
This was referenced Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Android Studio executable can sometimes contain architecture in the file name. Inside CLI we already honor architecture in the AS file name:
cli/packages/cli-doctor/src/tools/healthchecks/androidStudio.ts
Line 67 in b17d969
Test Plan:
Checklist