Skip to content

fix: invalid character in header on Windows - #2491

Merged
thymikee merged 1 commit into
mainfrom
fix/invalid-character-in-header
Aug 22, 2025
Merged

fix: invalid character in header on Windows#2491
thymikee merged 1 commit into
mainfrom
fix/invalid-character-in-header

Conversation

@szymonrybczak

@szymonrybczakszymonrybczak commented Aug 30, 2024

Copy link
Copy Markdown
Collaborator

Summary:

Fixes#2279
Fixes#2449

Some paths to current working directory contains characters that are invalid for header inside the request specifically on Windows - by wrapping path inside URL() class we're sure that characters are correctly coded.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@szymonrybczak
szymonrybczakforce-pushed the fix/invalid-character-in-header branch 2 times, most recently from 57c2180 to 92507c8CompareAugust 30, 2024 12:08
@szymonrybczak
szymonrybczakforce-pushed the fix/invalid-character-in-header branch from 92507c8 to d3f7d77CompareAugust 30, 2024 12:12
@szymonrybczakszymonrybczak changed the title fix: invalid character in header on Windowfix: invalid character in header on WindowsAug 30, 2024
@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

@szymonrybczak

Copy link
Copy Markdown
CollaboratorAuthor

cc @huntie can you take a look if this one doesn't introduce any regressions?

@huntiehuntie mentioned this pull request Feb 13, 2025
2 tasks
@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

@huntie

Copy link
Copy Markdown
Collaborator

@szymonrybczak I don't really have a Windows machine to hand, please validate on your end.

@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

@thymikeethymikee removed the stale label Aug 22, 2025
@thymikee
thymikee merged commit 26dd51a into mainAug 22, 2025
@thymikee
thymikee deleted the fix/invalid-character-in-header branch August 22, 2025 08:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

3 participants

@szymonrybczak@huntie@thymikee