Skip to content

fix(cli-tools): declare dependency on prompts - #2518

Merged
thymikee merged 1 commit into
react-native-community:mainfrom
tido64:tido/cli-tools/missing-prompts
Oct 2, 2024
Merged

fix(cli-tools): declare dependency on prompts#2518
thymikee merged 1 commit into
react-native-community:mainfrom
tido64:tido/cli-tools/missing-prompts

Conversation

@tido64

Copy link
Copy Markdown
Contributor

Summary:

prompts is used in cli-tools, but never declared as a dependency, causing commands to fail in pnpm setups:

Error: Cannot find module 'prompts'
Require stack:
- /~/node_modules/.store/@react-native-community-cli-tools-npm-14.0.1-fb5b1d1033/package/build/prompt.js
- /~/node_modules/.store/@react-native-community-cli-tools-npm-14.0.1-fb5b1d1033/package/build/index.js
- /~/node_modules/.store/@react-native-community-cli-npm-14.0.1-d30aee3125/package/build/commands/init/errors/InvalidNameError.js
- /~/node_modules/.store/@react-native-community-cli-npm-14.0.1-d30aee3125/package/build/commands/init/validate.js
- /~/node_modules/.store/@react-native-community-cli-npm-14.0.1-d30aee3125/package/build/commands/init/init.js

Test Plan:

n/a

@tido64

Copy link
Copy Markdown
ContributorAuthor

This needs to be cherry-picked to 14.x.

@thymikeethymikee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thymikee
thymikee merged commit 9da12a4 into react-native-community:mainOct 2, 2024
@tido64
tido64 deleted the tido/cli-tools/missing-prompts branch October 2, 2024 11:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tido64@thymikee