Uh oh!
There was an error while loading. Please reload this page.
fix: Use custom app name when getting build.gradle - #2524
Conversation
cortinico
commented
Oct 10, 2024
Is this documented somewhere or is it a new config? |
szymonrybczak
commented
Oct 10, 2024
If you mean the property |
cortinico
commented
Oct 10, 2024
yup that one 👍 thank you |
szymonrybczak
commented
Oct 11, 2024
Let's fix CI failures and it's good to go for me! |
szymonrybczak
commented
Nov 12, 2024
Ah, because of recent package refactors there are some merge conflicts 🥲 @TMisiukiewicz can you take a look? 🙏 |
thymikee
commented
Dec 30, 2024
@TMisiukiewicz let’s rebase this and we’re good to go :) |
| const buildGradlePath = findBuildGradle( | ||
| sourceDir, | ||
| false, | ||
| appName === '' ? 'app' : appName, |
There was a problem hiding this comment.
shouldn't this be just appName?
| appName==='' ? 'app' : appName, | |
| appName, |
There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
Summary:
It cannot access package name from
build.gradlewhen the module is named differently thanapp. This PR is fixing it.Closes#2516
Test Plan:
android/appfolder name toandroid/testreact-native.config.jsfile with the following content:androidcommand and verify the error about missing package name is not thrownChecklist