Skip to content

refactor: extract cli-config-android for linking - #2546

Merged
thymikee merged 1 commit into
mainfrom
refactor/cli-config-android
Nov 6, 2024
Merged

refactor: extract cli-config-android for linking#2546
thymikee merged 1 commit into
mainfrom
refactor/cli-config-android

Conversation

@thymikee

@thymikeethymikee commented Nov 5, 2024

Copy link
Copy Markdown
Member

Summary:

Extract a new cli-config-android package for linking purposes, so that we can import dependencyConfig and projectConfig without all the command code.

Test Plan:

Existing tests, no public API should be affected

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@github-actionsgithub-actionsBot added the docs Documentation change label Nov 5, 2024
szymonrybczak
szymonrybczak approved these changes Nov 5, 2024
View reviewed changes

@szymonrybczakszymonrybczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thymikee
thymikee merged commit 88f4a61 into mainNov 6, 2024
@thymikee
thymikee deleted the refactor/cli-config-android branch November 6, 2024 08:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szymonrybczakszymonrybczakszymonrybczak approved these changes
@cortinicocortinicoAwaiting requested review from cortinicocortinico is a code owner
@adamTrzadamTrzAwaiting requested review from adamTrz

Assignees

No one assigned

Labels

docsDocumentation change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thymikee@szymonrybczak