Skip to content

chore: remove unused native_modules files - #2547

Merged
thymikee merged 2 commits into
mainfrom
chore/remove-native-modules
Nov 7, 2024
Merged

chore: remove unused native_modules files#2547
thymikee merged 2 commits into
mainfrom
chore/remove-native-modules

Conversation

@thymikee

Copy link
Copy Markdown
Member

Summary:

Native autolinking logic for iOS and Android moved to the core react-native repository with RN 0.75, which ties to RNC CLI v14.x:

These files should essentially be unused now in 0.75+ apps.

Test Plan:

Adjusted the documentation accordingly and removed the integration test for iOS autolinking.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@github-actionsgithub-actionsBot added docs Documentation change infra Internal work not facing public APIs labels Nov 5, 2024

@szymonrybczakszymonrybczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@cortinicocortinico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup @thymikee

@@ -1,588 +0,0 @@
import groovy.json.JsonSlurper

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking instead of deleting this file we can just let it print a huge warning on what to do instead

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's very reasonable, will update

Comment threadpackages/cli-platform-android/native_modules.gradle
@thymikee

Copy link
Copy Markdown
MemberAuthor

This is how warning messages look like for:

Android (when running run-android):
Screenshot 2024-11-06 at 16 36 18

iOS (when running pod install):
Screenshot 2024-11-06 at 16 35 48

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation changeinfraInternal work not facing public APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@thymikee@cortinico@szymonrybczak