Skip to content

breaking: Remove cli-debugger-ui package - #2583

Merged
huntie merged 1 commit into
react-native-community:mainfrom
huntie:remove-remote-debugging-1
Jan 28, 2025
Merged

breaking: Remove cli-debugger-ui package#2583
huntie merged 1 commit into
react-native-community:mainfrom
huntie:remove-remote-debugging-1

Conversation

@huntie

@huntiehuntie commented Jan 27, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary:

Important

Breaking change: This is intended to target main / the future 18.x release of CLI (aligned with React Native 0.79).

Following our intent/announcement to remove Remote JS Debugging from React Native in 0.78, this PR removes the corresponding cli-debugger-ui frontend from the Community CLI.

Also deletes related middleware/WebSocket support code in cli-server-api:

  • /launch-js-devtools
  • debuggerProxyEndpoint

Test Plan:

✅ CI should pass

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@github-actionsgithub-actionsBot added the docs Documentation change label Jan 27, 2025
@huntiehuntie mentioned this pull request Jan 27, 2025
Merged
2 tasks
@huntie
huntieforce-pushed the remove-remote-debugging-1 branch from a793852 to 1afce36CompareJanuary 27, 2025 17:18
szymonrybczak
szymonrybczak reviewed Jan 27, 2025
View reviewed changes
Comment threadCONTRIBUTING.md Outdated
szymonrybczak
szymonrybczak reviewed Jan 27, 2025
View reviewed changes
Comment threadpackages/cli-server-api/package.json Outdated
szymonrybczak
szymonrybczak reviewed Jan 27, 2025
View reviewed changes

@szymonrybczakszymonrybczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, overall looks good!

Comment threadpackages/cli-server-api/package.json
Comment threadpackages/cli/package.json Outdated
Comment threadpackages/cli/package.json Outdated
@huntie

huntie commented Jan 27, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Very good spots @szymonrybczak — sorry I rebased my branch from my fork's main, rather than the up-to-date one!

@huntie

huntie commented Jan 27, 2025

Copy link
Copy Markdown
CollaboratorAuthor

For safety, latest push is a recreation of the commit after rebasing and re-deleting/searching for references.

@huntie
huntieforce-pushed the remove-remote-debugging-1 branch from 1afce36 to 5efa968CompareJanuary 27, 2025 17:35
szymonrybczak
szymonrybczak approved these changes Jan 27, 2025
View reviewed changes

@szymonrybczakszymonrybczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@huntiehuntie mentioned this pull request Jan 27, 2025
Merged
2 tasks
@huntie
huntieforce-pushed the remove-remote-debugging-1 branch from 5efa968 to 60d96aaCompareJanuary 27, 2025 18:00
@szymonrybczak

szymonrybczak commented Jan 28, 2025

Copy link
Copy Markdown
Collaborator

@huntie there's a conflict in packages/cli-server-api/index.ts file - can you take a look?

@huntie
huntieforce-pushed the remove-remote-debugging-1 branch from 60d96aa to 57ba392CompareJanuary 28, 2025 10:19
@huntie

huntie commented Jan 28, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@szymonrybczak Resolved.

@huntie
huntie merged commit 9113869 into react-native-community:mainJan 28, 2025
@huntie
huntie deleted the remove-remote-debugging-1 branch January 28, 2025 10:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szymonrybczakszymonrybczakszymonrybczak approved these changes
@adamTrzadamTrzAwaiting requested review from adamTrz
@thymikeethymikeeAwaiting requested review from thymikeethymikee is a code owner

Assignees

No one assigned

Labels

docsDocumentation change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@huntie@szymonrybczak