Uh oh!
There was an error while loading. Please reload this page.
feat(0.79): generate codegen before pod install - #2600
Conversation
cipolleschi
left a comment
There was a problem hiding this comment.
Left a couple of comments to make the code more maintainable!
But thank you for implementing this.
| newArchEnabled?: boolean; | ||
| iosFolderPath?: string; | ||
| platform: string; | ||
| root: string; |
There was a problem hiding this comment.
This should be the location of the xcodeproj file. f that's the case, we are good to go.
There was a problem hiding this comment.
@szymonrybczak let's call this cariable sourceDir instead of root then and pass proper value
There was a problem hiding this comment.
I don't think so, root is where package.json should be - based on this code:
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
cipolleschi
left a comment
There was a problem hiding this comment.
thanks for applying the suggestions!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Starting from React Native 0.79
pod installwon't invoke codegen generation logic so we have to do inside CLI.Test Plan
yarn iosin your project should generate codegen underios/buildand install Cocoapods properly.Checklist
react-nativecheckout (instructions).