Uh oh!
There was an error while loading. Please reload this page.
fix: restore open-url browser links while respecting CVE-2025-11953 - #2814
Merged
Conversation
MemberAuthor
Checked this against the 20.1.1 security change from #2758. This PR keeps the same regression coverage for CVE-2025-11953: non-string URLs are rejected, and the three attack vectors from #2758 are still rejected with 400: invalid hostname command substitution ( |
thymikee
marked this pull request as ready for review
June 25, 2026 14:20
thymikeeforce-pushed
the
codex/fix-open-url-browser-links
branch
from
June 25, 2026 14:34
a04ee31 to
2233857Comparethymikeeforce-pushed
the
codex/fix-open-url-browser-links
branch
from
June 25, 2026 14:41
2233857 to
7771736CompareUh oh!
There was an error while loading. Please reload this page.
leotm added a commit
to leotm/react-native-template-new-architecture
that referenced
this pull request
Jun 30, 2026
- revert d1b5e9c patch fix - bump @react-native-community/cli - bump @react-native-community/cli-platform-android - bump @react-native-community/cli-platform-ios Resolve: #1994 Supersedes - #1980 - #2012 - #2013 Ref - react-native-community/template#231 - react-native-community/template#232 - react/react-native#57344 Includes URL sanitisation fix (v20.1.1 regression) - react-native-community/cli#2814 - react-native-community/cli#2812 - react-native-community/cli#2758 - react-native-community/cli#2735 - react-native-community/cli#2697
leotm added a commit
to leotm/react-native-template-new-architecture
that referenced
this pull request
Jun 30, 2026
- revert d1b5e9c patch fix - bump @react-native-community/cli - bump @react-native-community/cli-platform-android - bump @react-native-community/cli-platform-ios Resolve: #1994 Supersedes - #1980 - #2012 - #2013 Ref - react-native-community/template#231 - react-native-community/template#232 - react/react-native#57344 Includes URL sanitisation fix (v20.1.1 regression) - react-native-community/cli#2814 - react-native-community/cli#2812 - react-native-community/cli#2758 - react-native-community/cli#2735 - react-native-community/cli#2697
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes#2812 by replacing the ESM-only
strict-url-sanitisedependency in/open-urlwith local URL validation that preserves normal React Native welcome-screen links while rejecting Windows shell metacharacter payloads.Removes the dependency from
cli-server-apiand refactors the middleware tests around a reusable request helper.Validation
yarn buildyarn test packages/cli-server-api/src/__tests__/openURLMiddleware.test.ts --runInBand -u/Users/thymikee/Developer/RNCLI83:https://reactnative.dev/docs/tutorialreturned 200 and opened Safari;https://evil.com?|calc.exeandhttps://example.com/?a=%¾TA%returned 400.