Uh oh!
There was an error while loading. Please reload this page.
fix(config): apply nested project defaults - #2828
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
automaticPodsInstallation: truebehavior whenproject.iosis omitted while preserving an explicitfalseinitcreatesreact-native.config.jsFixes#2825
Test Plan
yarn test packages/cli-config/src/__tests__/schema-test.ts --runInBandfailed before the schema change because both platform configs resolved to empty objectsyarn test packages/cli-config/src/__tests__/schema-test.ts --runInBand(5 passed)yarn test packages/cli-config/src/__tests__ --runInBand(23 passed)yarn test:ci:unit(56 suites, 318 passed, 1 pre-existing todo)yarn lint(0 errors; 2 pre-existing warnings outside this diff)yarn buildgit diff --checkChecklist
react-nativecheckout. This schema-only regression is covered directly at the validation boundary instead.