Uh oh!
There was an error while loading. Please reload this page.
feat: add a runtime config for debugger options - #17
Merged
okwasniewski merged 2 commits intoMar 24, 2025
Conversation
okwasniewski
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me! The build is failing for some reason. I'll also include @robik to take a quick look at the code
Saadnajmi
commented
Mar 19, 2025
Uh oh!
There was an error while loading. Please reload this page.
ContributorAuthor
Porting issue since |
robik
approved these changes
Mar 20, 2025
okwasniewski
approved these changes
Mar 21, 2025
okwasniewski
left a comment
Collaborator
There was a problem hiding this comment.
The E2E test is failing for some reason but I've checked locally and everything works. Thanks for this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See react/react-native#38942 for context.
This PR is a port of a PR I made to React Native macOS, that never made it to React Native Core. It adds a runtimeConfig to the JSC instance (similar to what Hermes has) so we can enable/disable debugging and set a target name. This is particularly useful when there are multiple JSC instances you could debug.
I'm not sure how to test this, since the code here is slightly different than what was in React Native / React Native macOS, and I mostly just copy/pasted my changes.