Uh oh!
There was an error while loading. Please reload this page.
feat: create releases where PATCH doesn't have to match react-native - #43
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
cortinico
commented
Aug 19, 2024
I'd like for @szymonrybczak to chime on this one and get his opinion here |
cipolleschi
left a comment
There was a problem hiding this comment.
This change makes sense to me. I left a few comments but they are mainly nits.
Accepting to unblock.
| inputs: | ||
| version: | ||
| description: "The version of the template we want to release. For example 0.75.0-rc.0" | ||
| description: "The version of the react-native we want to release. For example 0.75.0-rc.0" |
There was a problem hiding this comment.
we don't want to release a version of react-native, but a version of the template, don't we?
There was a problem hiding this comment.
Maybe:
"The version of react-native we want the template to use in this release. For example 0.75.0-rc.0."
Is a clearer description of what I intended here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
szymonrybczak
left a comment
There was a problem hiding this comment.
LGTM, let's answer @cipolleschi's comments and we're good to go!
Uh oh!
There was an error while loading. Please reload this page.
This feature needs to be released with react-native-community/cli#2475, which decouples the 1:1 release model we have for templates and react-native. Switching users to this is going to be difficult, and should only be rolled asap before 0.76. If we have to release a template fix, then only users with the latest CLI will be able to use that and subsequent versions. I'm not sure of how to clearly communicate that to users. - Added tests - Set dry_run to default
fb773c5 to
df950fbCompare…43) This feature needs to be released with react-native-community/cli#2475, which decouples the 1:1 release model we have for templates and react-native. Switching users to this is going to be difficult, and should only be rolled asap before 0.76. If we have to release a template fix, then only users with the latest CLI will be able to use that and subsequent versions. I'm not sure of how to clearly communicate that to users. - Added tests - Set dry_run to default
This feature needs to be released with react-native-community/cli#2475,
which decouples the 1:1 release model we have for templates and
react-native.
Switching users to this is going to be difficult, and should only be
rolled asap before 0.76. If we have to release a template fix, then only
users with the latest CLI will be able to use that and subsequent
versions.
I'm not sure of how to clearly communicate that to users.
WARNING: Do not merge until:
We have updated the calling step in react-native release step asks the template to publishNo changes needed here.We agree on a version of react-native that wants this to go live. When we do that, if it's 0.75 / 0.74 then also merge it into the 0.75-stable, etc... branch.0.75.2The CLI change (feat: determine react-native → template from npm registry data cli#2475) is committed and published.