Enzyme compatibility in Webpack config

[insin]

RE: #80 (comment)

This is what's required for Enzyme compatibility:

https://github.com/airbnb/enzyme/blob/master/docs/guides/webpack.md#react-15-compatability

externals: {
 'react/addons': true,
 'react/lib/ExecutionEnvironment': true,
 'react/lib/ReactContext': true
}

This project doesn't have a test-specific Webpack config, so where should this go?

[gaearon]

OK, happy to take a PR adding this.

[gaearon]

I’ve looked at it again and I don’t quite see the point. Presumably you’d run Enzyme outside of both npm start and npm run build anyway, wouldn’t you? And in this case you’d likely want a custom config anyway that’s tailored to tests.

What is the reasoning behind including these externals either in current dev or prod config?

cc @ariporad

[mxstbr]

What is the reasoning behind including these externals either in current dev or prod config?

Nothing, those should go in the testing specific webpack config if we had one as reflected in @insin's question at the end of the issue. 👍

[gaearon]

Okay, I’ll close then until we decide something on testing.