ESLint - no-unused-expressions warning for template tags

[ffxsam]

I'm using styled-components' injectGlobal template tag function, like so:

injectGlobal`
 .ant-btn-clicked:after {
 border: 0 solid ${mainTheme.primaryColor.toString()} !important;
 }

 .ant-switch-checked {
 background-color: ${mainTheme.primaryColor.toString()} !important;
 border-color: ${mainTheme.primaryColor.toString()} !important;
 }
`;

And I got warnings about injectGlobal being an unused expression. So I've modified my .eslintrc to be the following:

{
 "extends": "react-app",
 "rules": {
 "no-unused-expressions": ["error", {"allowTaggedTemplates": true}]
 }
}

This seems to stop ESLint warnings in Nuclide, but I'm still getting them in the browser console and shell:

./src/themes.js
 Line 20: Expected an assignment or function call and instead saw an expression no-unused-expressions

Am I configuring something wrong?

[gaearon]

Overriding our ESLint settings is not really supported. It technically "works" for IDEs so we documented it, but we still want everyone to have the same base configuration. This helps make sure it works correctly for everyone, that bugfixes are coordinated, and that everyone has mostly good experience out of the box.

In this particular case it seems like we should change our config. Our stance is that we try to create a config that's good for most users rather than allow users to make individual tweaks, thus keeping the base config less ideal.

If you send a PR for fixing this in our config I'm happy to take that in.

[denkristoffer]

This issue can be closed now 👍

[Timer]

Thanks!

[Timer]

This feature has been released as of v1.0.11. :)