Skip to content

WP5 - Update fork-ts-checker-webpack-plugin [DRAFT] - #10004

Closed
raix wants to merge 2 commits into
react:masterfrom
raix:wp5-update-fork-ts-checker-webpack-plugin
Closed

WP5 - Update fork-ts-checker-webpack-plugin [DRAFT]#10004
raix wants to merge 2 commits into
react:masterfrom
raix:wp5-update-fork-ts-checker-webpack-plugin

Conversation

@raix

@raixraix commented Nov 3, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Update fork-ts-checker-webpack-plugin@5.2.1

References:

Part of making way for Webpack 5 #9994

yarn docker:e2e --test-suite simple not yet tested but done manual QA locally*

cc. @piotr-oles regarding your comment maybe you can help review this one?

Potential breaking changes if anyone externally depends on react-dev-utils:

  • react-dev-utils/typescriptFormatter - it's removed as it's no longer needed in the CRA project
  • react-dev-utils/WebpackDevServerUtils - createCompiler no longer use arguments devSocket or tscCompileOnError

Removed to keep the code base small and clean

@raixraix mentioned this pull request Nov 3, 2020
Closed
25 tasks
@raixraix changed the title WP5-Update fork-ts-checker-webpack-pluginWP5 - Update fork-ts-checker-webpack-pluginNov 4, 2020
piotr-oles
piotr-oles suggested changes Nov 4, 2020
View reviewed changes

@piotr-olespiotr-oles left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, the only concern is issues hook tap :)

Comment threadpackages/react-dev-utils/WebpackDevServerUtils.js Outdated
@jasonwilliams

jasonwilliams commented Nov 14, 2020

Copy link
Copy Markdown
Contributor

https://github.com/TypeStrong/fork-ts-checker-webpack-plugin v6.0.1 is now out, might be worth bumping to that

@jasonwilliams

jasonwilliams commented Nov 14, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

@piotr-oles Thanks for the input - I'll try to resolve this in the weekend.
btw. I tried updating to v6.x but it started scanning node_modules (also added exclude patterns in both tsconfig.json and the overwrite but no change - not sure if there's an issue or just me :) )

We should raise that with them if it's doing that. It shouldn't be

raix
raix commented Dec 5, 2020
View reviewed changes
Comment threadpackages/react-scripts/config/webpack.config.js
raix
raix commented Dec 5, 2020
View reviewed changes
Comment threadpackages/react-dev-utils/WebpackDevServerUtils.js
@ianschmitzianschmitz added this to the 4.1 milestone Dec 8, 2020
@SamKirklandSamKirkland mentioned this pull request Dec 28, 2020
Open
mbarrien added a commit to chanzuckerberg/czgenepi that referenced this pull request Feb 10, 2021
@mbarrien
Revert ForkTsCheckerWebpackPlugin changes
e34b963
react/create-react-app#10004 makes changes to react-dev-utils
that are not present in the currently released version pulled down by npm. Revert and
reapply once new version of react-dev-utils is released (probably at same time as
create-react-app releases Webpack 5 compatible version).
@raixraix changed the title WP5 - Update fork-ts-checker-webpack-pluginWP5 - Update fork-ts-checker-webpack-plugin [DRAFT]Mar 20, 2021
@raix

raix commented Jul 1, 2021

Copy link
Copy Markdown
ContributorAuthor

Cherry picked into the wp5 branch - closing this pr

@raixraix closed this Jul 1, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianschmitzianschmitzAwaiting requested review from ianschmitz
@iansuiansuAwaiting requested review from iansu
@mrmckebmrmckebAwaiting requested review from mrmckeb
@petetntpetetntAwaiting requested review from petetnt
1 more reviewer
@piotr-olespiotr-olespiotr-oles requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signedtag: underlying tools

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

5 participants

@raix@jasonwilliams@piotr-oles@ianschmitz@facebook-github-bot