Skip to content

fix: remove generating .eslintcache - #10177

Closed
falinsky wants to merge 3 commits into
react:masterfrom
falinsky:fix-eslintcache-constantly-generated
Closed

fix: remove generating .eslintcache#10177
falinsky wants to merge 3 commits into
react:masterfrom
falinsky:fix-eslintcache-constantly-generated

Conversation

@falinsky

Copy link
Copy Markdown

fixes#10161

No need to generate eslint cache due to performance boost
gained in eslint-webpack-plugin 2.4.1

Pull-request where eslint cache generation was enabled: #9911
Following discussion about performance boost: #9886
Version of eslint-webpack-plugin with recompiling performance improvements: https://github.com/webpack-contrib/eslint-webpack-plugin/releases/tag/v2.4.1

fixesreact#10161
No need to generate eslint cache due to performance boost
gained in eslint-webpack-plugin 2.4.1
@ianschmitz

Copy link
Copy Markdown
Contributor

I'm probably missing some context here, but what does disable the cache improve?

@ianschmitzianschmitz added this to the 4.0.2 milestone Dec 2, 2020
@falinsky

Copy link
Copy Markdown
Author

I'm probably missing some context here, but what does disable the cache improve?

The cache was enabled in #9911 in order to improve recompilation time slowness.

It turned out that after enabling it - file .eslintcache started to be generated constantly in the root of the project. That fact annoys different people and provides some issues with errors persisting (see more in #10161).

However, eslint-webpack-plugin got updated to 2.4.1 where issues with slowness were fixed - so now enabling cache is not necessary at all (so it brings only issues without benefits, I guess).

This was referenced Dec 4, 2020
@ianschmitz

Copy link
Copy Markdown
Contributor

We are moving the file into node_modules in #9977, so #10161 should be taken care of. I'm sure the webpack guys would love to hear if caching is slowing the build down. I'm hesitant to disable without any data to back it up.

@falinskyfalinsky closed this Dec 8, 2020
ginpei added a commit to ginpei/shortcuts-demo that referenced this pull request Dec 16, 2020
@edksam

Copy link
Copy Markdown

This fix doesn't work please. And this is slowing down development for us rookies and it's giving me and my team no joy. A lot of data in terms of frustrations going on web now. I really don't see the need for caching in development and as a noob..

@falinskyfalinsky reopened this Dec 23, 2020
@falinsky

Copy link
Copy Markdown
Author

@ianschmitz reopening this pull-request due to an increasing amount of complaints regarding having eslint caching enabled (#10161)

@cruzzil

Copy link
Copy Markdown

Cache enabled causes serving old data: #10301

@mcchong

Copy link
Copy Markdown

Cache enabled causes serving old data: #10301

Hey hope this makes the next release. I keep running into the above issue where .eslintcache gets stale and the dev server needs to be restarted. It's a bit of a killer.

@iansuiansu modified the milestones: 4.0.2, 4.0.3Feb 3, 2021
@iansuiansu modified the milestones: 4.0.3, 4.0.4Feb 22, 2021
@iansu

Copy link
Copy Markdown
Contributor

This has been addressed in #10177. The cache directory has been moved into node_modules.

@iansuiansu closed this May 26, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.eslintcache constantly generated

7 participants

@falinsky@ianschmitz@edksam@cruzzil@mcchong@iansu@facebook-github-bot