Uh oh!
There was an error while loading. Please reload this page.
Add support for non-interactive terminal - #1032
Conversation
sheerun
commented
Nov 10, 2016
Also added a commit that should fix #873 |
There was a problem hiding this comment.
There was a problem hiding this comment.
"A numeric file descriptor", it's correct
There was a problem hiding this comment.
Right, so 1 is a magical number that means the standard output. Perhaps process.stdout.isTTY would be clearer?
There was a problem hiding this comment.
I was testing this branch and after making a change the terminal screen just went blank. I thought the compiler had got stuck. Why did we change this behavior?
There was a problem hiding this comment.
Perhaps we could only show The app is running at... after the first compile, but keep showing Compiled successfully! after each successful rebuild?
There was a problem hiding this comment.
Hmm. This should be non-interactive only change. It's to prevent duplicate output in non-interactive terminal. I've just fixed it.
There was a problem hiding this comment.
Can we please simplify this condition by extracting some boolean variables? It's getting crowdy and hard to tell when it's true.
sheerun
commented
Nov 20, 2016
It should be ready to merge.. |
fson
commented
Nov 20, 2016
I tested the non-interactive shell with concurrently. The output after starting the server, changing a file and waiting a few seconds looks like this: I'm not normally using a setup like this, so I'm not sure which alternative would be better, but the current behaviour doesn't seem right. |
sheerun
commented
Nov 23, 2016
@fson I've changed code so it always displays "Compiled successfully!". Could we merge? |
fson
commented
Nov 23, 2016
Thanks @sheerun, nice work! |

This should fix#869