Skip to content

Add instructions to use flow-typed - #1067

Closed
rricard wants to merge 2 commits into
react:masterfrom
rricard:flow-typed
Closed

Add instructions to use flow-typed#1067
rricard wants to merge 2 commits into
react:masterfrom
rricard:flow-typed

Conversation

@rricard

Copy link
Copy Markdown
Contributor

No description provided.

@rricard

Copy link
Copy Markdown
ContributorAuthor

Followup from #72.

Requires flow-typed/flow-typed#467 to be merged first.

@rricard

rricard commented Nov 22, 2016

Copy link
Copy Markdown
ContributorAuthor

Alright! flow-typed/flow-typed#467 is merged so what is written here is true!

However, the CI failed on yarn for no clear reason (I just changed the README)

@denkristofferdenkristoffer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, indicate to flow where to get those annotations by adding the following [libs] section to your .flowconfig:

Is this instruction necessary when flow checks flow-typed/ by default?

@rricard

Copy link
Copy Markdown
ContributorAuthor

@sachse I'm now concentrating on #1152 that will make this PR unnecessary.

@rricard

Copy link
Copy Markdown
ContributorAuthor

Closing in favor of #1152 that is almost there!

@rricardrricard closed this Dec 13, 2016
@rricard
rricard deleted the flow-typed branch December 13, 2016 16:04
@locklockBot locked and limited conversation to collaborators Jan 21, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rricard@denkristoffer@facebook-github-bot