Skip to content

chore: migrate to @babel/eslint-parser - #10761

Merged
iansu merged 10 commits into
react:mainfrom
JLHwung:switch-to-babel-eslint-parser
Jul 14, 2021
Merged

chore: migrate to @babel/eslint-parser#10761
iansu merged 10 commits into
react:mainfrom
JLHwung:switch-to-babel-eslint-parser

Conversation

@JLHwung

@JLHwungJLHwung commented Mar 29, 2021

Copy link
Copy Markdown
Contributor

Fixes#10636

I am not familiar with the codebase, let me know I misses something. Thanks!

ianschmitz
ianschmitz reviewed Mar 31, 2021
View reviewed changes

@ianschmitzianschmitz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JLHwung !

Comment threadpackages/eslint-config-react-app/base.js Outdated
Comment threadpackages/eslint-config-react-app/package.json
@ianschmitzianschmitz added this to the 4.0.4 milestone Mar 31, 2021
@iansuiansu mentioned this pull request Mar 31, 2021
Closed
21 tasks
JLHwung
JLHwung commented Mar 31, 2021
View reviewed changes
Comment threadpackages/eslint-config-react-app/base.js Outdated
@JLHwung
JLHwungforce-pushed the switch-to-babel-eslint-parser branch from ed6430c to 29ca1b2CompareMarch 31, 2021 19:05
@ljosberinnljosberinn mentioned this pull request Apr 21, 2021
Open
kaicataldo
kaicataldo reviewed Apr 22, 2021
View reviewed changes
Comment threadpackages/eslint-config-react-app/base.js
@JLHwung
JLHwungforce-pushed the switch-to-babel-eslint-parser branch from 5a2da07 to 4afd4a6CompareApril 22, 2021 18:37
@JLHwung

JLHwung commented Apr 22, 2021

Copy link
Copy Markdown
ContributorAuthor

The CI reports that react-app can not be loaded by eslint, likely because @babel/eslint-parser is not provided in certain e2e fixture package.json. However I don't know where are these package.json, help will be appreciated.

/cc @ianschmitz

@karlhorkykarlhorky mentioned this pull request May 11, 2021
Closed
@karlhorky

karlhorky commented May 11, 2021

Copy link
Copy Markdown

Is it maybe having to update the yarn.lock.cached file?

https://github.com/JLHwung/create-react-app/blob/f7109764702dcd376c39c25cc9cadb145472f4f4/packages/create-react-app/yarn.lock.cached#L2431-L2441

@karlhorkykarlhorky mentioned this pull request May 11, 2021
Closed
@JLHwung
JLHwungforce-pushed the switch-to-babel-eslint-parser branch from c50ef6b to 3d18c0aCompareMay 14, 2021 14:23
@mrmckebmrmckeb self-assigned this Jun 11, 2021
@mrnossiommrnossiom mentioned this pull request Jun 12, 2021
Closed
@chohannahchohannah mentioned this pull request Sep 14, 2024
Open
@b4nngb4nng mentioned this pull request Sep 15, 2024
Open
@chohannahchohannah mentioned this pull request Sep 15, 2024
Open
@patrickrizzardipatrickrizzardi mentioned this pull request Sep 15, 2024
Closed
@b4nngb4nng mentioned this pull request Sep 17, 2024
Open
@chohannahchohannah mentioned this pull request Sep 17, 2024
Open
@patrickrizzardipatrickrizzardi mentioned this pull request Sep 17, 2024
Closed
@b4nngb4nng mentioned this pull request Sep 18, 2024
Open
@chohannahchohannah mentioned this pull request Sep 18, 2024
Open
@patrickrizzardipatrickrizzardi mentioned this pull request Sep 18, 2024
Closed
@chohannahchohannah mentioned this pull request Sep 19, 2024
Open
@b4nngb4nng mentioned this pull request Sep 19, 2024
Open
@patrickrizzardipatrickrizzardi mentioned this pull request Sep 19, 2024
Closed
@chohannahchohannah mentioned this pull request Sep 20, 2024
Open
@patrickrizzardipatrickrizzardi mentioned this pull request Sep 20, 2024
Closed
@chohannahchohannah mentioned this pull request Sep 21, 2024
Open
This was referenced Sep 21, 2024
Open
Open
@b4nngb4nng mentioned this pull request Sep 22, 2024
Open
@patrickrizzardipatrickrizzardi mentioned this pull request Sep 22, 2024
Closed
@fredyvaronfredyvaron mentioned this pull request Sep 23, 2024
Open
@HiranyapeHiranyape mentioned this pull request Sep 27, 2024
Open
@patrickrizzardipatrickrizzardi mentioned this pull request Oct 3, 2024
Closed
This was referenced Oct 3, 2024
Open
Open
@OmrisnykOmrisnyk mentioned this pull request Oct 15, 2024
Open
@nerdy-tech-com-gitubnerdy-tech-com-gitub mentioned this pull request Oct 23, 2024
Open
@patrickrizzardipatrickrizzardi mentioned this pull request Oct 31, 2024
Closed
@barunslickbarunslick mentioned this pull request Oct 31, 2024
Open
@GregBrimbleGregBrimble mentioned this pull request Nov 8, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iansuiansuAwaiting requested review from iansu
@petetntpetetntAwaiting requested review from petetnt
3 more reviewers
@ianschmitzianschmitzianschmitz left review comments
@kaicataldokaicataldokaicataldo left review comments
@mrmckebmrmckebmrmckeb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mrmckebmrmckeb

Labels

CLA Signedtag: breaking changetag: underlying tools

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

[Package Update] Switch from babel-eslint to @babel/eslint-parser to get latests fixes

10 participants

@JLHwung@karlhorky@mrmckeb@iansu@FontEndArt@ryota-murakami@devinrhode2@ianschmitz@kaicataldo@facebook-github-bot