Skip to content

Suggest sass instead of node-sass package - #10779

Merged
ianschmitz merged 2 commits into
react:masterfrom
andrewywong:move-away-from-node-sass-and-update-related-docs
Apr 12, 2021
Merged

Suggest sass instead of node-sass package#10779
ianschmitz merged 2 commits into
react:masterfrom
andrewywong:move-away-from-node-sass-and-update-related-docs

Conversation

@andrewywong

@andrewywongandrewywong commented Apr 5, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

In addition to updating the docs to reference sass and its latest features, I've also updated the docs to reflect the fact that we don't need the '~' prefix to resolve modules from node_modules anymore.

Closes#10045, closes#10771

@facebook-github-bot

facebook-github-bot commented Apr 5, 2021

Copy link
Copy Markdown

Hi @andrewywong!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

facebook-github-bot commented Apr 5, 2021

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitzianschmitz added this to the 4.1 milestone Apr 12, 2021
@ianschmitzianschmitz changed the title Move away from node sass and update related docsSuggest sass instead of node-sass packageApr 12, 2021
@ianschmitz
ianschmitz merged commit 71cbe59 into react:masterApr 12, 2021
@ianschmitz

ianschmitz commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

Thanks @andrewywong!

@matiushenkoamatiushenkoa mentioned this pull request Apr 12, 2021
Closed
wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021
@andrewywongRowan Crawford
Suggest sass instead of node-sass package (react#10779)
afa3438
@BenJenkinsonBenJenkinson mentioned this pull request Jun 29, 2021
Open
@polarathenepolarathene mentioned this pull request Jul 9, 2021
Closed
sumanthratna pushed a commit to sumanthratna/create-react-app that referenced this pull request Aug 4, 2021
@andrewywong@sumanthratna
Suggest sass instead of node-sass package (react#10779)
19fe396
PhilippWendler added a commit to sosy-lab/benchexec that referenced this pull request Sep 28, 2021
@PhilippWendler
Switch from node-sass to sass
1fb020d
node-sass is deprecated and this is the suggested replacement:
react/create-react-app#10779
@snyk-botsnyk-bot mentioned this pull request Nov 13, 2021
Closed
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
@andrewywong@abhiisheek
Suggest sass instead of node-sass package (react#10779)
d454c17
@OmrisnykOmrisnyk mentioned this pull request Nov 27, 2023
Open
@OmrisnykOmrisnyk mentioned this pull request Feb 12, 2024
Open
@OmrisnykOmrisnyk mentioned this pull request Mar 22, 2024
Open
@OmrisnykOmrisnyk mentioned this pull request May 14, 2024
Open
@ntnguyencsentnguyencse mentioned this pull request May 18, 2024
Open
@OmrisnykOmrisnyk mentioned this pull request May 23, 2024
Open
This was referenced May 23, 2024
Closed
Closed
@chohannahchohannah mentioned this pull request Sep 14, 2024
Open
@b4nngb4nng mentioned this pull request Sep 15, 2024
Open
@chohannahchohannah mentioned this pull request Sep 15, 2024
Open
@patrickrizzardipatrickrizzardi mentioned this pull request Sep 15, 2024
Closed
@b4nngb4nng mentioned this pull request Sep 17, 2024
Open
@chohannahchohannah mentioned this pull request Sep 17, 2024
Open
@patrickrizzardipatrickrizzardi mentioned this pull request Sep 17, 2024
Closed
@b4nngb4nng mentioned this pull request Sep 18, 2024
Open
@chohannahchohannah mentioned this pull request Sep 18, 2024
Open
@patrickrizzardipatrickrizzardi mentioned this pull request Sep 18, 2024
Closed
@chohannahchohannah mentioned this pull request Sep 19, 2024
Open
@b4nngb4nng mentioned this pull request Sep 19, 2024
Open
@patrickrizzardipatrickrizzardi mentioned this pull request Sep 19, 2024
Closed
@chohannahchohannah mentioned this pull request Sep 20, 2024
Open
@patrickrizzardipatrickrizzardi mentioned this pull request Sep 20, 2024
Closed
@chohannahchohannah mentioned this pull request Sep 21, 2024
Open
This was referenced Sep 21, 2024
Open
Open
@b4nngb4nng mentioned this pull request Sep 22, 2024
Open
@patrickrizzardipatrickrizzardi mentioned this pull request Sep 22, 2024
Closed
@fredyvaronfredyvaron mentioned this pull request Sep 23, 2024
Open
@HiranyapeHiranyape mentioned this pull request Sep 27, 2024
Open
@patrickrizzardipatrickrizzardi mentioned this pull request Oct 3, 2024
Closed
This was referenced Oct 3, 2024
Open
Open
@OmrisnykOmrisnyk mentioned this pull request Oct 15, 2024
Open
@nerdy-tech-com-gitubnerdy-tech-com-gitub mentioned this pull request Oct 23, 2024
Open
@patrickrizzardipatrickrizzardi mentioned this pull request Oct 31, 2024
Closed
@barunslickbarunslick mentioned this pull request Oct 31, 2024
Open
@GregBrimbleGregBrimble mentioned this pull request Nov 8, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianschmitzianschmitzAwaiting requested review from ianschmitz
@iansuiansuAwaiting requested review from iansu
@mrmckebmrmckebAwaiting requested review from mrmckeb
@petetntpetetntAwaiting requested review from petetnt

Assignees

No one assigned

Labels

CLA Signedtag: documentation

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

Change node-sass to sass because node-sass is deprecated Move away from node-sass and update documentation related to it

3 participants

@andrewywong@facebook-github-bot@ianschmitz