Uh oh!
There was an error while loading. Please reload this page.
Unpin babel dependencies - #10797
Conversation
facebook-github-bot
commented
Apr 8, 2021
Hi @mohd-akram! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
commented
Apr 8, 2021
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ianschmitz
left a comment
There was a problem hiding this comment.
There's a few other package.json files that should be updated to match:
Do you mind updating:
packages/babel-plugin-named-asset-import/package.jsonpackages/react-dev-utils/package.jsonpackages/react-error-overlay/package.jsonpackages/react-scripts/package.json
The latest commits seem to have unpinned most packages. Let's keep it scoped to babel packages for now. |
mrmckeb
commented
May 30, 2021
@ianschmitz are you OK to merge this one now? It looks like all changes have been made as requested. |
mrmckeb
commented
May 31, 2021
Thanks for your efforts @mohd-akram, and for the reviews @ianschmitz and @MichaelDeBoey. |
This prevents unnecessary duplication of dependencies, and matches upstream.