Uh oh!
There was an error while loading. Please reload this page.
fix: resolve dependency issues in v5 alpha - #11294
Conversation
raix
commented
Aug 18, 2021
Terser is shipped in webpack 5 not sure this is the way to go? |
merceyz
commented
Aug 18, 2021
It's required by |
raix
commented
Aug 18, 2021
I'll have to check, anyways we should use the terser plug-in already available in webpack 5 https://webpack.js.org/plugins/terser-webpack-plugin/ |
raix
commented
Aug 18, 2021
(Adding the terser dependency is webpack 4 style...) |
raix
commented
Aug 18, 2021
That said, I've seen a warning from babel when the babel cache is empty, so the config has an issue |
Those docs also specify to declare it as a dependency
|
raix
commented
Sep 3, 2021
@merceyz you are right 👍 - I completely missed that detail |
2d3daeb to
80b8a29Compare
What's the problem this PR addresses?
The v5 alpha regressed to have dependency issues.
How did you fix it?
terser-webpack-pluginas a dependency again@babel/runtimefrombabel-preset-react-app