Skip to content

Remove cached lockfile - #11706

Merged
iansu merged 1 commit into
react:mainfrom
lukekarrys:lk/rm-cached-lockfile
Dec 2, 2021
Merged

Remove cached lockfile#11706
iansu merged 1 commit into
react:mainfrom
lukekarrys:lk/rm-cached-lockfile

Conversation

@lukekarrys

@lukekarryslukekarrys commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

To go along with facebook#11474, we no longer need the cached lockfile after unpinning all the dependencies.

This PR removes all references to it in the creation of new projects and the tests. It also refactors the integration test to assert that all files exist and no extra ones are being written.

To go along with react#11474, we no longer need the cached lockfile after unpinning all the dependencies.
This PR removes all references to it in the creation of new projects and the tests. It also refactors the integration test to assert that all files exist and no extra ones are being written.
@iansuiansu added this to the 5.0 milestone Dec 2, 2021
@iansu
iansu merged commit 69321b0 into react:mainDec 2, 2021
@iansu

iansu commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

Thanks!

@lukekarrys
lukekarrys deleted the lk/rm-cached-lockfile branch December 3, 2021 00:15
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lukekarrys@iansu@facebook-github-bot