Uh oh!
There was an error while loading. Please reload this page.
fix: resolve dependency issues - #11751
Conversation
giulianf
commented
Dec 25, 2021
is there any deadline for this version 5.0.1? |
AndyDyer
commented
Dec 27, 2021
+1 |
aramis-it
commented
Jan 6, 2022
How to use it before release? |
blu3r4y
commented
Jan 6, 2022
Add the missing dependency in your Additionally, I did |
7076f9d to
6807108Comparejakeklassen
commented
Mar 9, 2022
Anyone know how I can use this before release with pnpm? I am seeing errors with @babel/plugin-proposal-private-property-in-object |
9731d78 to
3a1eb28Compare| @@ -143,9 +143,9 @@ module.exports = function (webpackEnv) { | |||
| config: false, | |||
There was a problem hiding this comment.
We should also need to specify the path to the postcss:
{// Options for PostCSS as we reference these options twice// Adds vendor prefixing based on your specified browser support in// package.jsonloader: require.resolve('postcss-loader'),implementation: require.resolve("postcss"),options: {postcssOptions: {There was a problem hiding this comment.
That's not necessary, postcss-loader declares postcss as a peer dependency so it will get it from the parent (react-scripts) on its own.
There was a problem hiding this comment.
Thanks for your reply, the problem I'm having is that under node_modules is postcss v7, but plugins like postcss-flexbugs-fixes depend on postcss v8, which causes errors when compiling.
So I think it might be better to specify implementation.
…vate-property-in-object`
3a1eb28 to
074bf9cCompareindutny
commented
Feb 17, 2023
Could this be merged? |
hellenfc
commented
May 26, 2023
Issue still existing, can this be merged? |
MuyangAmigo
commented
Jul 6, 2023
Can this fix be merged? |
briandiaz
commented
Aug 21, 2023
News on this? |
duereg
commented
Sep 12, 2023
I'm pretty sure this project is no longer maintained |
giulianf
commented
Sep 13, 2023
I think you right. |
What's the problem this PR addresses?
The project created by
create-react-app@5.0.0has dependency issues.How did you fix it?
@babel/plugin-proposal-private-property-in-objectas a dependency tobabel-preset-react-app@types/testing-library__jest-domto the typescript template to fix typechecking under strict dependency environmentsrequire.resolvethe PostCSS pluginsrequire.resolvethe Jest watch pluginstypescriptas an optional peer dependency toeslint-config-react-app