fix(webpackDevServer): fix deprecation warning by zhaomengfan · Pull Request #11862 · react/create-react-app

zhaomengfan · 2021-12-31T08:02:25Z

update webpack-dev-server + fix deprecation warning (#11860)

…rning

facebook-github-bot · 2021-12-31T08:02:28Z

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot · 2021-12-31T09:24:34Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

yann-combarnous · 2022-01-07T16:27:56Z

@raix , could this be added to 5.0.1, by any chance? It would reduce CRA verbosity on startup.

wcedmisten-reify · 2022-01-11T17:50:38Z

@zhaomengfan Recommend upgrading webpack-dev-server to 4.7.3 to include a recent security patch

ramdaniAli · 2022-01-15T16:54:21Z

Will this deprecation be fixed in a future release?

fitrarhm

It work. The warning it's gone.

This makes several significant changes to our dependencies: - react-scripts (i.e. create-react-app) is now v5 (from v4) - tailwindcss is now v3 (from a variant of v2 targeting postcss v7) - postcss is now v8 (from v7) - autoprefixer is now v10 (from v9) - craco is no longer used because react-scripts v5 natively supports tailwindcss The postcss and autoprefixer upgrades required no changes on our end, as they're used only through tailwindcss. The craco removal required minor changes to package.json to go back to invoking react-scripts directly. The react-scripts upgrade didn't require any changes apart from the other dependency upgrades. However, it did introduce a couple new harmless warnings to the build. The first is a pair of "DeprecationWarning" messages from webpack-dev-server for which a fix has already been submitted upstream to create-react-app[1]. The second is three "Failed to parse source map" messages from source-map-loader. These are due to a bug in plausible-tracker for which I've submitted a fix[2]. The tailwindcss upgrade was the most invasive and required a number of changes to our CSS and config. I fully followed the upgrade guide[3] and tested as much functionality as I could. As far as I can tell, the site behaves and appears identical to how it did before. [1] react/create-react-app#11862 [2] plausible/plausible-tracker#23 [3] https://tailwindcss.com/docs/upgrade-guide

This makes several significant changes to our dependencies: - react-scripts (i.e. create-react-app) is now v5 (from v4) - tailwindcss is now v3 (from a variant of v2 targeting postcss v7) - postcss is now v8 (from v7) - autoprefixer is now v10 (from v9) - craco is no longer used because react-scripts v5 natively supports tailwindcss The postcss and autoprefixer upgrades required no changes on our end, as they're used only through tailwindcss. The craco removal required minor changes to package.json to go back to invoking react-scripts directly. The react-scripts upgrade didn't require any changes apart from the other dependency upgrades. However, it did introduce a pair of harmless "DeprecationWarning" messages from webpack-dev-server to the build, for which a fix has already been submitted upstream to create-react-app[1]. The tailwindcss upgrade was the most invasive and required a number of changes to our CSS and config. I fully followed the upgrade guide[2] and tested as much functionality as I could. As far as I can tell, the site behaves and appears identical to how it did before. [1] react/create-react-app#11862 [2] https://tailwindcss.com/docs/upgrade-guide

brookjordan · 2022-03-07T06:18:43Z

Would love to see this implemented to reduce developer confusion.

Meligy · 2022-04-26T00:56:49Z

Is there a workaround until this PR is merged?

Or else, is there anything that can help with it? I assume external user review / approval will not count.

icey-franken · 2022-05-13T23:06:41Z

bump

sbaggott · 2022-05-17T19:56:51Z

This is actually breaking our app locally. With react-scripts 5.0.1, when we run npm start, despite it just being a warning it stops the dev server with the deprecation warning. Is there any way to fix this while we wait for 5.0.2?

pat-ryb · 2022-05-23T18:31:08Z

It work. The warning it's gone.

It really does the trick.

dirkesquire · 2022-06-16T14:16:15Z

At the moment my app won't start up using react-scripts@5.0.1. I see a lot of failing tests in the requested Review? How do we get this reviewed/fixed/merged in?

Meligy · 2022-08-06T08:27:46Z

Is this planned for 5.0.2?

ithrforu · 2022-11-09T21:46:44Z

bump.

akhileshgoud2504 · 2022-11-16T20:38:28Z

The issue got fixed with the changes in the below link
https://github.com/facebook/create-react-app/pull/11862/files/2dff88610f9ad215349424d1769b88e0a0d2fa1d
Thank you..!

micktdj · 2022-12-26T23:31:11Z

Is this still planned for 5.0.2 patch ?

MikeMcC399 · 2023-01-10T18:15:02Z

Is there anybody sponsoring or working on this PR? It fails 7 out of 9 tests.
The issue Use of deprecated webpack DevServer onBeforeSetupMiddleware and onAfterSetupMiddleware options #11860 is still open.

BalaM314 · 2023-04-28T13:52:18Z

I can't see the failure reason anymore as Azure dropped the run results, does anyone know why the tests are failing?

MikeMcC399 · 2023-04-28T14:09:20Z

@BalaM314

The whole PR is now stale, so either the original submitter @zhaomengfan would need to rebase or somebody else would need to be active. Considering that the last commit to the master branch was in September 2022 it seems that the repository is no longer being actively maintained.

Edit: See also issue Archive the repository if the project is dead. #13393

Abel13 · 2023-07-20T16:56:46Z

how can I use this branch on my code?

nathanwiles

not sure if I'll be able to make it work, but it's worth a shot, my school project recommends using create-react-app

morremeyer · 2023-11-19T21:23:58Z

@nathanwiles Your school project's recommendation is outdated. Take a look at e.g. vite. create-react-app is unmaintained.

misraelson · 2023-12-20T17:02:06Z

IMO CRA should be maintained. Lots and lots of production apps still use CRA. This isn't breaking my app, but I do see a warning pop up for a split second before the local server runs. It's wild that this PR is still open, how can we merge it in? @zhaomengfan please merge this

Jay-Patel-Developer · 2024-05-16T07:44:48Z

Hi Guys, Will this be fixed in any new releases?

MikeMcC399 · 2024-05-16T08:42:34Z

@jaypatel22222

Hi Guys, Will this be fixed in any new releases?

You should probably read Archive the repository if the project is dead. #13393 for background information. It sounds highly unlikely that there will be any new release.

Ben-CA · 2024-11-28T18:21:31Z

+1 Would like to see this merged.

fix(webpackDevServer): update webpack-dev-server + fix deprecation wa…
a5bbe7d
…rning

zhaomengfan requested review from iansu and mrmckeb as code owners December 31, 2021 08:02

zhaomengfan changed the title ~~fix(webpackDevServer): update webpack-dev-server + fix deprecation warning(#11860)~~fix(webpackDevServer): fix deprecation warning(#11860)Dec 31, 2021

facebook-github-bot added the CLA Signed label Dec 31, 2021

zhaomengfan changed the title ~~fix(webpackDevServer): fix deprecation warning(#11860)~~fix(webpackDevServer): fix deprecation warningJan 4, 2022

cduff mentioned this pull request Jan 5, 2022
Use of deprecated webpack DevServer onBeforeSetupMiddleware and onAfterSetupMiddleware options #11860
Open

raix added this to the 5.0.1 milestone Jan 9, 2022

chore(deps): update webpack-dev-server
2dff886

fitrarhm reviewed Jan 21, 2022
View reviewed changes

kyclai mentioned this pull request Feb 8, 2022
Data Mapper: Resolved package vulnerabilities microsoft/iomt-fhir#169
Merged

joshkel reviewed Mar 29, 2022
View reviewed changes

Comment threadpackages/react-scripts/config/webpackDevServer.config.js
Comment threadpackages/react-scripts/config/webpackDevServer.config.js

iansu modified the milestones: 5.0.1, 5.0.2 Apr 12, 2022

Merge branch 'facebook:main' into main
ad6e0b7

jongio mentioned this pull request Apr 25, 2022
[Issue] WebPack warning (React app) Azure/azure-dev#403
Closed

Merge branch 'facebook:main' into main
0de2b0e

Eng-Fouad mentioned this pull request Aug 6, 2022
DeprecationWarning: 'onAfterSetupMiddleware' option is deprecated #12035
Open

zhaomengfanand others added 4 commits August 27, 2022 11:56

Merge branch 'facebook:main' into main
b3ccb52

Merge branch 'facebook:main' into main
51b77f6

fix(webpackDevServer): remove useless prompts
c295bd6

fix(webpackDevServer): Correct the order of middlewares
7a41287

fix(webpackDevServer): fix 'https' is deprecated
d7b696d

imnasnainaec mentioned this pull request May 8, 2023
Deprecated middleware options sillsdev/TheCombine#2133
Closed

Merge branch 'facebook:main' into main
4f668bc

nathanwiles reviewed Nov 19, 2023
View reviewed changes

Merge branch 'facebook:main' into main
87fa4b8

Uh oh!

Uh oh!

Conversation

zhaomengfan commented Dec 31, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Dec 31, 2021

Action Required

Process

Uh oh!

facebook-github-bot commented Dec 31, 2021

Uh oh!

yann-combarnous commented Jan 7, 2022

Uh oh!

wcedmisten-reify commented Jan 11, 2022

Uh oh!

ramdaniAli commented Jan 15, 2022

Uh oh!

fitrarhm left a comment

Choose a reason for hiding this comment

Uh oh!

brookjordan commented Mar 7, 2022

Uh oh!

Uh oh!

Uh oh!

Meligy commented Apr 26, 2022

Uh oh!

icey-franken commented May 13, 2022

Uh oh!

sbaggott commented May 17, 2022

Uh oh!

pat-ryb commented May 23, 2022

Uh oh!

dirkesquire commented Jun 16, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Meligy commented Aug 6, 2022

Uh oh!

ithrforu commented Nov 9, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akhileshgoud2504 commented Nov 16, 2022

Uh oh!

micktdj commented Dec 26, 2022

Uh oh!

MikeMcC399 commented Jan 10, 2023

Uh oh!

BalaM314 commented Apr 28, 2023

Uh oh!

MikeMcC399 commented Apr 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Abel13 commented Jul 20, 2023

Uh oh!

nathanwiles left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

morremeyer commented Nov 19, 2023

Uh oh!

misraelson commented Dec 20, 2023

Uh oh!

Jay-Patel-Developer commented May 16, 2024

Uh oh!

MikeMcC399 commented May 16, 2024

Uh oh!

Ben-CA commented Nov 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

zhaomengfan commented Dec 31, 2021•
edited
Loading

dirkesquire commented Jun 16, 2022•
edited
Loading

ithrforu commented Nov 9, 2022•
edited
Loading

MikeMcC399 commented Apr 28, 2023•
edited
Loading

nathanwiles left a comment •
edited
Loading