Skip to content

Instruct Jest to load native components from RNW instead of RN - #1201

Merged
gaearon merged 1 commit into
react:masterfrom
ross-rosario:bugfix/1085-jest-rnw
Dec 8, 2016
Merged

Instruct Jest to load native components from RNW instead of RN#1201
gaearon merged 1 commit into
react:masterfrom
ross-rosario:bugfix/1085-jest-rnw

Conversation

@ross-rosario

@ross-rosarioross-rosario commented Dec 8, 2016

Copy link
Copy Markdown
Contributor

This small change fixes#1085. Basically it includes @gaearon's suggested fix.

@facebook-github-bot

facebook-github-bot commented Dec 8, 2016

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@ross-rosarioross-rosario mentioned this pull request Dec 8, 2016
Closed
@facebook-github-bot

facebook-github-bot commented Dec 8, 2016

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
gaearon merged commit adbc1a2 into react:masterDec 8, 2016
@gaearon

gaearon commented Dec 8, 2016

Copy link
Copy Markdown
Contributor

Thank you!

@gaearongaearon mentioned this pull request Dec 8, 2016
Merged
@gaearon

gaearon commented Dec 8, 2016

Copy link
Copy Markdown
Contributor

Should be in 0.8.3.

alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
@ross-rosario@alexdriaguine
Instruct Jest to load native components from RNW instead of RN (react…
443c0c0
…#1201)
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
@ross-rosario@randycoulman
Instruct Jest to load native components from RNW instead of RN (react…
cf698e5
…#1201)
@locklockBot locked and limited conversation to collaborators Jan 21, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signedtag: bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests fail in a react-native-web app with __DEV__ is not defined

3 participants

@ross-rosario@facebook-github-bot@gaearon