Uh oh!
There was an error while loading. Please reload this page.
docs: fix link of "Building for Relative Paths" - #12691
Conversation
facebook-github-bot
commented
Aug 25, 2022
Hi @jackblackevo! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
commented
Aug 25, 2022
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
jesec
commented
Aug 30, 2022
Docs are deployed via Docusaurus. See https://create-react-app.dev/docs/advanced-configuration for the deployed page of the file referred in this PR. Users would get 404 if |
jackblackevo
commented
Sep 6, 2022
Hi @jesec! I checked the Docusaurus document:
Then I checked another link which reference to another document on this page, such as the " https://github.com/facebook/create-react-app/blob/f34d88e30c7d8be7181f728d1abc4fd8d5cd07d3/docusaurus/docs/advanced-configuration.md?plain=1#L6 The file path above is included But in that case below: https://github.com/facebook/create-react-app/blob/f34d88e30c7d8be7181f728d1abc4fd8d5cd07d3/docusaurus/docs/advanced-configuration.md?plain=1#L20 The file path not included |
jesec
left a comment
There was a problem hiding this comment.
Re-formatting is required. See https://github.com/facebook/create-react-app/runs/8218127528.
Otherwise, lg2m.
jackblackevo
commented
Sep 7, 2022
Thank you @jesec! |
<!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! -->
docs: fix link of "Building for Relative Paths" (react#12691)
<!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! --> <!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! -->
docs: fix link of "Building for Relative Paths" (react#12691)
bulutuu
commented
Apr 28, 2024
|
bulutuu
commented
Apr 28, 2024
|
bulutuu
commented
Apr 28, 2024
|


Add the missing
.mdto fix link of "Building for Relative Paths"