Uh oh!
There was an error while loading. Please reload this page.
fix: upgrade RTL version to avoid peer-deps mismatch - #13738
Conversation
|
JoeBrar
commented
Jan 19, 2025
Hi, when will this PR get accepted and merged into main branch? |
Co-authored-by: Rajhans Jadhao <rajhans.jadhao@gmail.com>
rickhanlonii
commented
Jan 28, 2025
The remaining test failure seems legit but I'm not sure how to fix. |
JoeBrar
commented
Jan 28, 2025
Looks like the failing tests needs to be updated according to the latest React version |
iamrajhans
commented
Jan 28, 2025
hi @rickhanlonii, I think will need to use the react-testing-lib for the failing test cases just like here Reference link - https://kentcdodds.com/blog/common-mistakes-with-react-testing-library#not-using-screen |
rickhanlonii
commented
Jan 28, 2025
@iamrajhans no, these tests are not using RTL. The issue is that the webpack config for SVGs uses an old version of |
Resolves#13721
This PR upgrades the installed version of RTL to resolve the peer deps issue.
It also installs DTL because RTL version 16 requires DTL to be installed.